https now automatically added if not present #1

Merged

swaggboi merged 2 commits from :main into main

2023-11-14 01:58:30 +00:00

drudgesentinel commented

2023-11-14 00:48:45 +00:00

Collaborator

What this does sort:

People putting 'google.com' or whatever in. This will automatically become https://google.com

It doesn't sort sanitizing the URL entirely, e.g. 'google' will now go to https://google and choke. However, no more stack trace which isn't exactly nothing, but I don't know if it's going to actually be easier to work on.

Initially as experimenting with try catch in the routes but that's going to have to wait for another day.

I segmented helper stuff into another file, I'm not married to the name but I like having separation

What this does sort: People putting 'google.com' or whatever in. This will automatically become https://google.com It doesn't sort sanitizing the URL entirely, e.g. 'google' will now go to https://google and choke. However, no more stack trace which isn't exactly nothing, but I don't know if it's going to actually be easier to work on. Initially as experimenting with try catch in the routes but that's going to have to wait for another day. I segmented helper stuff into another file, I'm not married to the name but I like having separation

drudgesentinel added 1 commit 2023-11-14 00:48:46 +00:00

f7dd150728 https now automatically added if not present

swaggboi changed title from ~~https now automatically added if not present~~ to https now automatically added if not present

2023-11-14 01:17:42 +00:00

swaggboi changed target branch from main to add-scheme

2023-11-14 01:17:43 +00:00

swaggboi commented

2023-11-14 01:21:43 +00:00

Owner

Per Dr. K:

Please default to http
Try using single-quotes in regex to avoid escaping: /^https? '://'/

Good call with the Helper class and catching stack traces... I should be mindful of this before going to 'production'

Per Dr. K: - Please default to `http` - Try using single-quotes in regex to avoid escaping: `/^https? '://'/` Good call with the Helper class and catching stack traces... I should be mindful of this before going to 'production'

drudgesentinel added 1 commit 2023-11-14 01:51:59 +00:00

278924da0d change regex spacing for mr. fancy britches from the uptown

swaggboi changed title from ~~https now automatically added if not present~~ to https now automatically added if not present

2023-11-14 01:57:37 +00:00

swaggboi changed target branch from add-scheme to main

2023-11-14 01:57:38 +00:00

swaggboi commented

2023-11-14 01:58:16 +00:00

Owner

LGTM!!

swaggboi merged commit 78b81897c9 into main

2023-11-14 01:58:30 +00:00