1
0
Fork 1
mirror of https://github.com/mastodon/mastodon.git synced 2024-12-22 17:17:32 +00:00
Commit graph

461 commits

Author SHA1 Message Date
Matt Jankowski b2c5b20ef2
Fix RSpec/AnyInstance cop () 2023-11-14 14:52:59 +00:00
Claire 07a4059901
Add support for invite codes in the registration API () 2023-11-13 13:27:00 +00:00
Eugen Rochko 0d14fcebae
Change link previews to keep original URL from the status () 2023-11-13 09:58:28 +00:00
Matt Jankowski 69d00e2721
Fix RSpec/InstanceVariable cop () 2023-11-08 15:42:30 +00:00
Matt Jankowski 45770c9306
Fix Performance/MapMethodChain cop () 2023-11-07 13:01:09 +00:00
Matt Jankowski 49e2772064
Fix RSpec/MessageSpies cop () 2023-11-07 09:46:28 +00:00
Matt Jankowski b06284c572
Fix RSpec/HookArgument cop () 2023-11-07 09:10:36 +00:00
Jeong Arm 8f998cd96a
Handle featured collections without items () 2023-10-27 02:36:22 +00:00
Matt Jankowski bcd0171e5e
Fix Lint/UselessAssignment cop () 2023-10-19 16:55:06 +02:00
Matt Jankowski f8afa0f614
Remove unused stub json ld context () 2023-10-16 15:38:27 +02:00
Claire 27e84c0691
Fix duplicate reports being sent when reporting some remote posts () 2023-10-10 16:00:50 +02:00
Claire 6273416292
Fix post edits not being forwarded as expected () 2023-09-15 19:54:32 +02:00
Claire 16681e0f20
Add admin notifications for new Mastodon versions () 2023-09-01 17:47:07 +02:00
Eugen Rochko 2304cc6456
Fix bad search type heuristic () 2023-08-28 17:08:37 +02:00
Nick Schonning b970ed6098
Update rubocop and rubocop-rspec () 2023-08-22 09:31:40 +02:00
Claire 30c64bf616
Fix list import concurrently creating lists of the same name () 2023-08-07 17:59:20 +02:00
Emelia Smith e258b4cb64
Refactor: replace whitelist_mode mentions with limited_federation_mode () 2023-08-02 19:32:48 +02:00
Matt Jankowski 6f1fa1364f
Fix RSpec/EmptyExampleGroup cop () 2023-07-28 23:15:33 +02:00
Christian Schmidt f96e4b3047
Use original URL in preview if it redirects to 4xx page () 2023-07-28 23:02:08 +02:00
Matt Jankowski 2d9808f648
Reformat large key values in service specs () 2023-07-26 09:45:50 +02:00
Matt Jankowski 7d62e3b198
Reformat large text arg in FetchLinkCardService spec () 2023-07-26 09:44:51 +02:00
Claire 1e3b19230a
Add stricter protocol fields validation for accounts () 2023-07-20 18:23:48 +02:00
Matt Jankowski 1cceb62afd
Fix Lint/Void cop () 2023-07-20 17:31:34 +02:00
Claire f18618d7f9
Fix some incorrect tests () 2023-07-17 13:13:43 +02:00
Matt Jankowski 6c5a2233a8
Fix RSpec/StubbedMock cop ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-07-12 10:20:10 +02:00
Matt Jankowski 658742b3cd
Fix Lint/AmbiguousBlockAssociation cop () 2023-07-12 10:02:41 +02:00
Matt Jankowski 74806deb2c
Fix RSpec/SubjectStub cop ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-07-12 10:02:19 +02:00
Matt Jankowski c75df62ccc
Fix RSpec/SubjectDeclaration cop () 2023-07-12 09:49:33 +02:00
jsgoldstein 99be47f8b9
Change searching with # to include account index () 2023-07-10 20:58:13 +02:00
Claire c27b82a437
Add forward_to_domains parameter to POST /api/v1/reports () 2023-07-10 18:26:56 +02:00
Eugen Rochko 93e8a15415
Add forwarding of reported replies to servers being replied to () 2023-07-08 20:00:02 +02:00
Daniel M Brasil 383c00819c
Fix /api/v2/search not working with following query param () 2023-07-03 18:06:57 +02:00
Claire a209d1e683
Fix ResolveURLService not resolving local URLs for remote content () 2023-06-29 14:48:54 +02:00
jsgoldstein 4581a528f7
Change account search to match by text when opted-in ()
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
2023-06-29 13:05:21 +02:00
Matt Jankowski 05f9e39b32
Fix RSpec/VerifiedDoubles cop () 2023-06-22 14:55:22 +02:00
Matt Jankowski 0b39b9abee
Speed-up on BackupService spec () 2023-06-22 11:53:28 +02:00
Matt Jankowski 4c5aa0e470
Update rubocop-rspec to version 2.22.0, fix RSpec/IndexedLet cop () 2023-06-14 16:44:37 +02:00
Matt Jankowski 62c996b52d
Reduce RSpec/MultipleExpectations cop max to 8 () 2023-06-10 18:38:22 +02:00
Matt Jankowski 6c0e3f490a
Fix RSpec/MissingExampleGroupArgument cop () 2023-06-06 15:51:42 +02:00
Matt Jankowski c42591356d
Fix RSpec/DescribedClass cop () 2023-06-06 13:58:33 +02:00
Claire 8884d1ece0
Add support for importing lists () 2023-06-01 14:47:31 +02:00
Renaud Chaput 942d850b0a
Allow carets in URL search params () 2023-06-01 12:14:49 +02:00
Christian Schmidt 69057467cb
Translate CW, poll options and media descriptions ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-06-01 00:10:21 +02:00
Matt Jankowski 0f2c16ac4b
Fix RSpec/NoExpectationExample cop () 2023-05-26 09:41:12 +02:00
Matt Jankowski d2e5430d4a
Fix RSpec/ExpectChange cop () 2023-05-24 11:23:40 +02:00
Matt Jankowski b896b16cb3
Fix RSpec/PredicateMatcher cop () 2023-05-23 16:49:11 +02:00
Emelia Smith 19f9098551
Allow reports with long comments from remote instances, but truncate () 2023-05-22 13:15:21 +02:00
Nick Schonning 99e2e9b81f
Fix minor typos in comments and spec names () 2023-05-19 17:13:29 +02:00
Claire b805b7f021
Add tests for avatar/header in backup service () 2023-05-19 12:04:18 +02:00
Matt Jankowski bf3ebeb42f
Fix RSpec/SharedContext cop () 2023-05-12 09:25:43 +02:00
Matt Jankowski a610a02d4f
Fix RSpec/ScatteredSetup cop () 2023-05-11 10:32:09 +02:00
Matt Jankowski 710745e16b
Fix RSpec/ContextWording cop () 2023-05-04 05:49:08 +02:00
Matt Jankowski bdcd8a9e88
Misc spec cleanup () 2023-05-04 05:47:52 +02:00
Claire b233da5996
Optimize archive export service and export zip files instead of gzipped tar files () 2023-05-02 15:09:43 +02:00
Claire 32a030dd74
Rewrite import feature () 2023-05-02 12:08:48 +02:00
Nick Schonning a3393d0d07
Autofix Rubocop RSpec/MatchArray () 2023-04-26 20:21:54 +02:00
Matt Jankowski 10f0de4212
Refactor race condition reblog service spec () 2023-04-14 14:42:10 +02:00
Claire f53d009778
Refactor Status._insert_record slightly and tighten the test around reblogs of discarded statuses () 2023-04-12 12:47:05 +02:00
Eugen Rochko a9b5598c97
Change user settings to be stored in a more optimal way ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-03-30 14:44:00 +02:00
Christian Schmidt eb38e9df31
Requeue expiration notification () 2023-03-29 10:52:40 +02:00
Matt Jankowski 9da52ac044
Update rspec-rails to version 6.0.1 () 2023-03-02 15:55:37 +01:00
Nick Schonning 6bd7003799
Fix mispelled spec filenames () 2023-02-23 11:28:56 +01:00
Nick Schonning 84cc805cae
Enable Style/FrozenStringLiteralComment for specs () 2023-02-22 09:55:31 +09:00
Nick Schonning 5116347eb7
Autofix Rubocop RSpec/BeEq () 2023-02-20 06:14:50 +01:00
Nick Schonning bf785df9fe
Audofix Rubocop Style/WordArray () 2023-02-20 06:14:10 +01:00
Nick Schonning 4552685f6b
Autofix Rubocop RSpec/LeadingSubject () 2023-02-20 13:24:14 +09:00
Nick Schonning 5179c47087
Autofix Rubocops RSpec/ScatteredLet () 2023-02-20 11:17:41 +09:00
Nick Schonning bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject () 2023-02-20 02:46:00 +01:00
Nick Schonning 65ba0d92ef
Enable Rubocop RSpec/NotToNot () 2023-02-20 02:33:27 +01:00
Nick Schonning 81ad6c2e39
Autofix Rubocop Style/StringLiterals () 2023-02-19 07:38:14 +09:00
Nick Schonning 3680e032b4
Autofix Rubocop RSpec/EmptyLineAfterFinalLet () 2023-02-19 07:10:19 +09:00
Nick Schonning 08289a38fa
Autofix Rubocop Style/TrailingCommaInArrayLiteral () 2023-02-19 06:54:30 +09:00
Nick Schonning 5069769cbe
Autofix Rubocop Style/TrailingCommaInHashLiteral () 2023-02-18 23:33:41 +09:00
Nick Schonning c38bd17657
Autofix Rubocop Style/TrailingCommaInArguments () 2023-02-18 12:39:58 +01:00
Nick Schonning e5cf23cf3a
Enable Rubocop RSpec/HooksBeforeExamples () 2023-02-18 03:59:57 +01:00
Nick Schonning 634368c491
Autofix Rubocop Lint/SymbolConversion () 2023-02-18 03:23:49 +01:00
Nick Schonning 669f6d2c0a
Run rubocop formatting except line length () 2023-02-18 06:56:20 +09:00
Nick Schonning 6ed6c41724
Autofix Rubocop RSpec/EmptyLineAfterExample () 2023-02-17 21:46:00 +09:00
Nick Schonning 936204b9ea
Autofix Rubocop Style/NestedParenthesizedCalls () 2023-02-17 21:43:10 +09:00
Nick Schonning 37914c8757
Autofix Rubocop Style/MethodCallWithoutArgsParentheses () 2023-02-17 21:36:14 +09:00
Claire d6930b3847
Add API parameter to safeguard unexpect mentions in new posts () 2023-02-13 16:36:29 +01:00
Claire 0c9eac80d8
Fix unbounded recursion in post discovery ()
* Add a limit to how many posts can get fetched as a result of a single request

* Add tests

* Always pass `request_id` when processing `Announce` activities

---------

Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>
2023-02-10 22:16:37 +01:00
Markus Unterwaditzer f2a6e71bb6
Suppress AddressFamilyError in link verification ()
* Suppress AddressFamilyError

* clarify comment
2023-01-23 13:05:54 +01:00
Claire 4b92e59f4f
Add support for editing media description and focus point of already-posted statuses ()
* Add backend support for editing media attachments of existing posts

* Allow editing media attachments of already-posted toots

* Add tests
2023-01-18 16:33:55 +01:00
Markus Unterwaditzer 0c689b9d01
fix: allow verification when page size exceeds 1MB (using HTML5 parser) ()
* fix: allow verification when page size exceeds 1MB
Truncates the page after 1MB instead

Closes 

* switch to HTML5 parser, fix rubocop errors

* undo rubocop fixes

Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>
2023-01-11 21:59:13 +01:00
Claire 18fb01ef7c
Fix possible race conditions when suspending/unsuspending accounts ()
* Fix possible race conditions when suspending/unsuspending accounts

* Fix tests

Tests were assuming SuspensionWorker and UnsuspensionWorker would do the
suspending/unsuspending themselves, but this has changed.
2023-01-05 13:47:21 +01:00
Claire c8849d6cee
Fix unbounded recursion in account discovery ()
* Fix trying to fetch posts from other users when fetching featured posts

* Rate-limit discovery of new subdomains

* Put a limit on recursively discovering new accounts
2022-12-07 00:15:24 +01:00
Claire 625216d8e1
Fix attachments of edited statuses not being fetched ()
* Fix attachments of edited statuses not being fetched

* Fix tests
2022-11-27 20:39:05 +01:00
Rose 4f15fd0ba1
Fix style for hashes ()
* Fix style for hashes

Make the style for hashes consistent.

* New style

More consistency
2022-11-17 11:05:39 +01:00
Joshua Wood daf6f3453e
Handle links with no href in VerifyLinkService ()
Before this change, the following error would cause VerifyAccountLinksWorker to fail:

NoMethodError: undefined method `downcase' for nil:NilClass
  [PROJECT_ROOT]/app/services/verify_link_service.rb:31 :in `block in link_back_present?`
2022-11-17 10:59:35 +01:00
Hampton Lintorn-Catlin 147d8bd8fc
Support UTF-8 Characters in Domains During CSV Import ()
* Support UTF-8 Characters in Domains During Import

* Update Changelong
2022-11-14 05:52:13 +01:00
Claire bbf74498f5
Fix validation error in SynchronizeFeaturedTagsCollectionWorker ()
* Fix followers count not being updated when migrating follows

Fixes 

* Fix validation error in SynchronizeFeaturedTagsCollectionWorker

Also saves remote user's chosen case for hashtags

* Limit remote featured tags before validation
2022-11-07 22:35:53 +01:00
Claire 4fb0aae636
Change mentions of blocked users to not be processed ()
Fixes 
2022-11-04 13:19:12 +01:00
Claire 9387beb3b3
Change flaky AccountSearchService test () 2022-11-03 23:12:08 +01:00
Yamagishi Kazutoshi 94feb2b93f
Fix FetchFeaturedCollectionService spec ()
Regression from 
2022-10-21 11:48:22 +02:00
Claire 7165e89362
Add tests to ActivityPub::FetchRemoteKeyService () 2022-09-24 08:33:27 +02:00
Claire 26c51cfa07
Fix various rspec warnings in ReportService tests ()
* Fix various rspec warnings in ReportService tests

* Add tests to ReportService
2022-09-21 22:46:35 +02:00
Claire 8cf7006d4e
Refactor ActivityPub handling to prepare for non-Account actors ()
* Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService

ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is
specifically required to be an Account

* Refactor SignatureVerification to allow non-Account actors

* fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService

* Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors

* Refactor inbound ActivityPub payload processing to accept non-Account actors

* Refactor inbound ActivityPub processing to accept activities relayed through non-Account

* Refactor how Account key URIs are built

* Refactor Request and drop unused key_id_format parameter

* Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`
2022-09-21 22:45:57 +02:00
Eugen Rochko 50948b46aa
Add ability to filter followed accounts' posts by language () 2022-09-20 23:51:21 +02:00
Claire 1145dbd327
Improve error reporting and logging when processing remote accounts ()
* Add a more descriptive PrivateNetworkAddressError exception class

* Remove unnecessary exception class to rescue clause

* Remove unnecessary include to JsonLdHelper

* Give more neutral error message when too many webfinger redirects

* Remove unnecessary guard condition

* Rework how “ActivityPub::FetchRemoteAccountService” handles errors

Add “suppress_errors” keyword argument to avoid raising errors in
ActivityPub::FetchRemoteAccountService#call (default/previous behavior).

* Rework how “ActivityPub::FetchRemoteKeyService” handles errors

Add “suppress_errors” keyword argument to avoid raising errors in
ActivityPub::FetchRemoteKeyService#call (default/previous behavior).

* Fix Webfinger::RedirectError not being a subclass of Webfinger::Error

* Add suppress_errors option to ResolveAccountService

Defaults to true (to preserve previous behavior). If set to false,
errors will be raised instead of caught, allowing the caller to be
informed of what went wrong.

* Return more precise error when failing to fetch account signing AP payloads

* Add tests

* Fixes

* Refactor error handling a bit

* Fix various issues

* Add specific error when provided Digest is not 256 bits of base64-encoded data

* Please CodeClimate

* Improve webfinger error reporting
2022-09-20 23:30:26 +02:00
Eugen Rochko d83faa1a89
Add ability to block sign-ups from IP () 2022-08-24 19:00:37 +02:00
Claire 1b4054256f
Fix crash when a remote Flag activity mentions a private post ()
* Add tests

* Fix crash when a remote Flag activity mentions a private post
2022-07-04 11:08:30 +02:00
Claire e0bdaeab65
Fix NoMethodError when resolving a link that redirects to a local post ()
* Fix NoMethodError when resolving a link that redirects to a local post

* Fix tests
2022-05-17 14:52:26 +02:00
Claire 71d02ffcf3
Fix compatibility with Friendica regarding pinned posts ()
* Fix multiple database queries when fetching pinned posts for remote account

* Fix compatibility with Friendica regarding pinned posts

Fixes 

* Add tests
2022-05-02 17:41:01 +02:00
Eugen Rochko 7b0fe4aef9
Fix opening and closing Redis connections instead of using a pool ()
* Fix opening and closing Redis connections instead of using a pool

* Fix Redis connections not being returned to the pool in CLI commands
2022-04-29 22:43:07 +02:00
Claire 84d991988e
Fix temporary network/remote server error prevent from interactions with remote accounts ()
* Fix temporary network/remote server error prevent from interactions with remote accounts

* Fix and add tests
2022-04-28 20:19:10 +02:00
Eugen Rochko 3917353645
Fix single Redis connection being used across all threads ()
* Fix single Redis connection being used across all Sidekiq threads

* Fix tests
2022-04-28 17:47:34 +02:00
Claire 8f91e304a5
Fix spurious edits and require incoming edits to be explicitly marked as such ()
* Change post text edit to not be considered significant if it's identical after reformatting

* We don't need to clear previous change information anymore

* Require status edits to be explicit, except for poll tallies

* Fix tests

* Add some tests

* Add poll-related tests

* Add HTML-formatting related tests
2022-04-06 21:01:02 +02:00
Claire 30658924a8
Fix test-related issues ()
* Remove obsolete RSS::Serializer test

Since , RSS::Serializer no longer has specific code for deleted statuses,
but it is never called on deleted statuses anyway.

* Rename erroneously-named test files

* Fix failing test

* Fix test deprecation warnings

* Update CircleCI Ruby orb

1.4.0 has a bug that does not match all the test files due to incorrect
globbing
2022-03-28 12:43:58 +02:00
Eugen Rochko 71f2b95106
Fix edits with no actual changes being allowed ()
* Fix edits with no actual changes being allowed locally

* Fix edits with no actual changes being allowed through ActivityPub

* Fix false positive changes caused by description processing in model

* Fix not recording poll expiration update

* Fix test

* Revert changes to ProcessStatusUpdateService

* Various fixes and improvements

* Fix code style issues

* Various changes and improvements

* Add guard clause
2022-03-26 00:38:44 +01:00
Claire 92a86b958e
Fix issues with processing toot edits ()
* Fix searching for an already-known status by URL not working

* Fix Update processing from statuses prior to 20220302232632

`ordered_media_attachment_ids_changed?` would return `true` when going from
`nil` to anything (including `[]`).

* Add tests
2022-03-12 19:33:10 +01:00
Eugen Rochko ddbe906c25
Fix not updating a status when newer version is fetched manually () 2022-03-12 09:11:36 +01:00
Claire 5ccd6cbfda
Add test for reblog race condition fix ()
Follow-up to 
2022-03-10 00:11:49 +01:00
Claire 63c9d2bc28
Add tests for CVE-2022-24307 ()
Follow-up to 
2022-03-10 00:11:40 +01:00
Eugen Rochko d17fb70131
Change how changes to media attachments are stored for edits ()
* Change how changes to media attachments are stored for edits

Fix not being able to re-order media attachments

* Fix not broadcasting updates when polls/media is changed through ActivityPub

* Various fixes and improvements

* Update app/models/report.rb

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Add tracking of media attachment description changes

* Change poll in status edit to have a structure closer to the real one

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2022-03-09 09:06:17 +01:00
Josh Soref b5329e0035
Spelling ()
* spelling: account

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: affiliated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: appearance

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: autosuggest

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cacheable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: component

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: conversations

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: domain.example

Clarify what's distinct and use RFC friendly domain space.

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: environment

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exceeds

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: functional

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: inefficiency

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: not

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: notifications

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: occurring

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: position

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: progress

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: promotable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: reblogging

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: repetitive

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resolve

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: saturated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: similar

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: strategies

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: success

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: targeting

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: thumbnails

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unauthorized

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unsensitizes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: validations

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: various

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-03-06 22:51:40 +01:00
luzpaz 73f5e4a1d9
Fix various typos ()
Found via `codespell -q 3 -S ./CHANGELOG.md,./AUTHORS.md,./config/locales,./app/javascript/mastodon/locales -L ba,keypair,medias,ro`
2022-02-22 20:14:17 +01:00
Claire d4e6774a0c
Fix Undo Announce sometimes inlining the originally Announced status ()
* Change tests to have more specific expectations on sent ActivityPub payloads

* Check that payload doesn't actually contain the contents of the boosted toot

* Fix Undo Announce sometimes inlining the originally Announced status
2022-02-11 14:52:07 +01:00
Claire 472bc89611
Fix some flaky tests that randomly failed because of item ordering () 2022-02-10 22:00:10 +01:00
Claire 2af03164cb
Improve tests involving push_bulk ()
sidekiq-bulk's push_bulk can either accept arguments directly or run them
through a block.

Setting expectations on the result of evaluating the blocks allows testing
more code (the block itself) and the test is moved closer to the *interface*
of the tested code than its precise implementation.
2022-02-10 19:42:45 +01:00
Claire 63854bee6c
Fix poll votes not being properly reset on poll change ()
* Fix poll votes not being properly reset on poll change

* Fix and add tests

* Fix poll update handling when the number of options changes
2022-02-10 14:26:54 +01:00
Eugen Rochko 63002cde03
Add editing for published statuses ()
* Add editing for published statuses

* Fix change of multiple-choice boolean in poll not resetting votes

* Remove the ability to update existing media attachments for now
2022-02-10 00:15:30 +01:00
Claire e38fc319dc
Refactor and improve tests ()
* Change account and user fabricators to simplify and improve tests

- `Fabricate(:account)` implicitly fabricates an associated `user` if
  no `domain` attribute is given (an account with `domain: nil` is
  considered a local account, but no user record was created), unless
  `user: nil` is passed
- `Fabricate(:account, user: Fabricate(:user))` should still be possible
  but is discouraged.

* Fix and refactor tests

- avoid passing unneeded attributes to `Fabricate(:user)` or
  `Fabricate(:account)`
- avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other
  way around
- prefer `Fabricate(:user, account_attributes: …)` to
  `Fabricate(:user, account: Fabricate(:account, …)`
- also, some tests were using remote accounts with local user records, which is
  not representative of production code.
2022-01-28 00:46:42 +01:00
Eugen Rochko 1060666c58
Add support for editing for published statuses ()
* Add support for editing for published statuses

* Fix references to stripped-out code

* Various fixes and improvements

* Further fixes and improvements

* Fix updates being potentially sent to unauthorized recipients

* Various fixes and improvements

* Fix wrong words in test

* Fix notifying accounts that were tagged but were not in the audience

* Fix mistake
2022-01-19 22:37:27 +01:00
Claire 7f803c41e2
Add ability to purge undeliverable domains from admin interface ()
* Add ability to purge undeliverable domains from admin interface

* Add tests
2021-12-17 23:01:21 +01:00
Eugen Rochko 7de0ee7aba
Remove Keybase integration () 2021-11-26 05:58:18 +01:00
Claire 013bee6afb
Fix filtering DMs from non-followed users () 2021-11-25 23:46:30 +01:00
Eugen Rochko 39cdf61ab7
Add support for structured data and more OpenGraph tags to link cards ()
Save preview cards under their canonical URL

Increase max redirects to follow from 2 to 3
2021-11-05 23:23:05 +01:00
Claire ec059317fa
Fix some link previews being incorrectly generated from other prior links ()
* Add tests

* Fix some link previews being incorrectly generated from different prior links

PR  added a cache to avoid redundant queries when the OEmbed endpoint can
be guessed from the URL. This caching mechanism is not perfectly correct as
there is no guarantee that all pages from a given domain share the same
OEmbed provider endpoint.

This PR prevents the FetchOEmbedService from caching OEmbed endpoint that
cannot be generalized by replacing a fully-qualified URL from the endpoint's
parameters, greatly reducing the number of incorrect cached generalizations.
2021-10-21 20:39:35 +02:00
Claire 3f9b28ce26
Add support for fetching Create and Announce activities by URI ()
* Add support for fetching Create and Announce activities by URI

This should improve compatibility with ZAP and offer a way to fetch boosts,
which is currently not possible.

* Add tests
2021-10-21 01:14:04 +02:00
Takeshi Umeda 17f4e457b3
Add remove from followers api ()
* Add followed_by? to account_interactions

* Add RemoveFromFollowersService

* Fix AccountBatch to use RemoveFromFollowersService

* Add remove from followers API
2021-10-18 12:02:35 +02:00
Claire 216570ad98
Fix scheduled statuses decreasing statuses counts ()
* Add tests

* Fix scheduled statuses decreasing statuses counts

Fixes 
2021-10-14 19:59:21 +02:00
Claire 2b18f7a943
Fix processing mentions to domains with non-ascii TLDs ()
Fixes 
2021-09-01 22:06:40 +02:00
Claire 6702148472
Add tests for SuspendAccountService and UnsuspendAccountService ()
* Add tests for SuspendAccountService

* Add tests for UnsuspendAccountService
2021-08-20 10:53:33 +01:00
Claire 13b08610a0
Fix crash when encountering invalid account fields ()
* Add test

* Fix crash when encountering invalid account fields
2021-08-11 16:40:55 +02:00
Claire 4ac78e2a06
Add feature to automatically delete old toots ()
* Add account statuses cleanup policy model

* Record last inspected toot to delete to speed up successive calls to statuses_to_delete

* Add service to cleanup a given account's statuses within a budget

* Add worker to go through account policies and delete old toots

* Fix last inspected status id logic

All existing statuses older or equal to last inspected status id must be
kept by the current policy. This is an invariant that must be kept so that
resuming deletion from the last inspected status remains sound.

* Add tests

* Refactor scheduler and add tests

* Add user interface

* Add support for discriminating based on boosts/favs

* Add UI support for min_reblogs and min_favs, rework UI

* Address first round of review comments

* Replace Snowflake#id_at_start with with_random parameter

* Add tests

* Add tests for StatusesCleanupController

* Rework settings page

* Adjust load-avoiding mechanisms

* Please CodeClimate
2021-08-09 23:11:50 +02:00
Claire 763ab0c7eb
Fix owned account notes not being deleted when an account is deleted ()
* Add account_notes relationship

* Add tests

* Fix owned account notes not being deleted when an account is deleted

* Add post-migration to clean up orphaned account notes
2021-08-08 15:29:57 +02:00
Claire 225c6582d1
Add tests for BootstrapTimelineService () 2021-07-07 21:12:43 +02:00
Claire afb7882189
Fix blocking someone not clearing up list feeds () 2021-05-10 17:31:55 +02:00
Eugen Rochko 1294f9ee4f
Remove PubSubHubbub-related columns from accounts table () 2021-05-07 19:32:58 +02:00
Eugen Rochko daccc07dc1
Change auto-following admin-selected accounts, show in recommendations () 2021-04-24 17:01:43 +02:00
Claire 5614e6724e
Fix URL scanning in note length validator and preview card fetching ()
* Add tests

* Fix URL scanning in note length validator and preview card fetching
2021-03-04 00:12:26 +01:00
Claire 5f4c0b79c2
Change ResolveAccountService's handling of skip_webfinger ()
* Change ResolveAccountService's handling of skip_webfinger

Change it so it never makes any webfinger query, as the name would imply.

* Add tests

* Change FollowService to not take an URI for target_account

* Restore domain-block check in FollowService

* Fix tests
2021-02-24 06:32:13 +01:00
ThibG 3249d35bdc
Improve account deletion performances further ()
* Delete status records by batches of 50

* Do not precompute values that are only used once

* Do not generate redis events for removal of public toots older than two weeks

* Filter reported toots a priori for polls and status deletion

* Do not process reblogs when cleaning up public timelines

As in Mastodon proper, reblogs don't appear in public TLs

* Clean the deleted account's own feed in one go

* Refactor Account#clean_feed_manager and List#clean_feed_manager

* Delete instead of destroy a few more associations

* Fix preloading

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2020-12-22 23:57:46 +01:00
Eugen Rochko 9915d11c0d
Fix unnecessary queries when batch-removing statuses, 100x faster () 2020-12-22 17:13:55 +01:00
ThibG 43961035a9
Fix some notifications not being deleted on poll/status deletion ()
* Fix deleting polls not deleting notifications

* Fix fav notification deletion when deleting a toot

* Refactor DeleteAccountService spec

* Add DeleteAccountService tests for other associations and notifications

* Add favourite handling spec in status removal

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2020-12-21 18:22:17 +01:00
ThibG a60d9335d8
Fix resolving accounts sometimes creating duplicate records for a given AP id ()
* Fix ResolveAccountService accepting mismatching acct: URI

* Set attributes that should be updated regardless of suspension

* Fix key fetching

* Automatically merge remote accounts with duplicate `uri`

* Add tests

* Add "tootctl accounts fix-duplicates"

Finds duplicate accounts sharing a same ActivityPub `id`, re-fetch them and
merge them under the canonical `acct:` URI.

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2020-12-18 23:26:26 +01:00
ThibG b1feb47055
Improve searching for private toots from URL ()
* Improve searching for private toots from URL

Most of the time, when sharing toots, people use the toot URL rather than
the toot URI, which makes sense since it is the user-facing URL.

In Mastodon's case, the URL and URI are different, and Mastodon does not
have an index on URL, which means searching a private toot by URL is done
with a slow query that will only succeed for very recent toots.

This change gets rid of the slow query, and attempts to guess the URI from
URL instead, as Mastodon's are predictable.

* Add tests

* Only return status with guessed uri if url matches

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2020-12-17 06:51:49 +01:00
ThibG 8b8004a962
Fix webfinger redirect handling in ResolveAccountService ()
* Fix webfinger redirect handling in ResolveAccountService

ResolveAccountService#process_webfinger! handled a one-step webfinger
redirection, but only accepting the result if it matched the exact URI passed
as input, defeating the point of a redirection check.

Instead, use the same logic as in `ActivityPub::FetchRemoteAccountService`,
updating the resulting `acct:` URI with the result of the first webfinger
query.

* Add tests
2020-11-19 19:52:06 +01:00
ThibG 96c1e71329
Add import/export feature for bookmarks ()
* Add ability to export bookmarks

* Add support for importing bookmarks

* Add bookmark import tests

* Add bookmarks export test
2020-11-19 17:48:13 +01:00