1
0
Fork 0
forked from fedi/mastodon
mastodon/app/models
Patrick Figel 8ac7fca5d0 Set correct attachment type for rejected media (#2599)
In #2110, a new attachment type "unknown" was introduced for
attachments that were rejected due to a domain being blocked using
reject_media. However, the "type" field was never set to "unknown"
because a default value of "0" (image) is set for that column,
causing the `type.blank?` expression to always equal false.

This version uses type_changed? instead, causing the type to be set
to "unknown" unless a type has been explicitly set. This introduces
a small change in behaviour causing the type to be set to unknown
before paperclip calls `before_post_process`. Presumably this
behaviour is more appropriate than the current one because the
attachment type has not been determined by that point.

Included are new tests for `ProcessFeedService` and
`UpdateRemoteProfileService` which now check that remote media is
downloaded for non-blocked domains and is rejected for others.
2017-04-29 00:18:32 +02:00
..
concerns Remove .keep in models (#1892) 2017-04-16 16:28:52 +02:00
form Fix #795, fix #704, fix #835 - 2FA requires confirmation to be enabled (#1278) 2017-04-08 22:20:08 +02:00
web Persist UI settings, add missing localizations for German 2017-01-09 14:00:55 +01:00
account.rb More controller specs (#2561) 2017-04-28 15:12:37 +02:00
account_filter.rb Admin accounts controller cleanup (#1664) 2017-04-13 13:04:23 +02:00
application_record.rb Fix rubocop issues, introduce usage of frozen literal to improve performance 2016-11-15 16:56:29 +01:00
block.rb Rename cache key to exclude_account_ids_for:id, adjust formatting 2017-04-18 01:14:02 +02:00
domain_block.rb Punycode URI normalization (#2370) 2017-04-25 02:47:31 +02:00
export.rb Settings export refactor (#1646) 2017-04-13 13:02:02 +02:00
favourite.rb Required foreign keys (#2003) 2017-04-17 15:54:33 +02:00
feed.rb Only call regeneration worker after first login after a 14 day break 2017-04-04 02:00:10 +02:00
follow.rb fix rubocop issues 2017-04-05 00:47:17 +02:00
follow_request.rb add more tests to models 2017-04-05 00:29:56 +02:00
import.rb Add presence validation to Import (#1928) 2017-04-16 16:28:26 +02:00
media_attachment.rb Set correct attachment type for rejected media (#2599) 2017-04-29 00:18:32 +02:00
mention.rb add more tests to models 2017-04-05 00:29:56 +02:00
mute.rb Rename cache key to exclude_account_ids_for:id, adjust formatting 2017-04-18 01:14:02 +02:00
notification.rb API param to exclude notification types from response (#1341) 2017-04-10 23:45:29 +02:00
preview_card.rb OEmbed support for PreviewCard (#2337) 2017-04-27 14:42:22 +02:00
remote_follow.rb strip leading & trailing spaces from remote follow acct (#997) (#2321) 2017-04-22 15:08:30 +02:00
report.rb Report processing improvements (#2349) 2017-04-24 00:44:37 +02:00
report_filter.rb Admin reports with accounts (#2092) 2017-04-18 19:36:18 +02:00
setting.rb Add digest e-mails 2017-03-04 00:00:48 +01:00
status.rb More status specs (#2564) 2017-04-28 15:10:41 +02:00
stream_entry.rb Rewrite Atom generation from stream entries to use Ox instead of Nokogiri (#1124) 2017-04-07 05:56:56 +02:00
subscription.rb Required foreign keys (#2003) 2017-04-17 15:54:33 +02:00
tag.rb Search cleanup (#1333) 2017-04-09 14:45:01 +02:00
user.rb Admin UI for confirming users (#2245) 2017-04-23 04:43:42 +02:00
web.rb Add extended about page stub 2017-01-13 03:24:41 +01:00