forked from fedi/mastodon
e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
54 lines
1.8 KiB
Ruby
54 lines
1.8 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Settings::ProfilesController, type: :controller do
|
|
render_views
|
|
|
|
let!(:user) { Fabricate(:user) }
|
|
let(:account) { user.account }
|
|
|
|
before do
|
|
sign_in user, scope: :user
|
|
end
|
|
|
|
describe "GET #show" do
|
|
it "returns http success" do
|
|
get :show
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
end
|
|
|
|
describe 'PUT #update' do
|
|
before do
|
|
user.account.update(display_name: 'Old name')
|
|
end
|
|
|
|
it 'updates the user profile' do
|
|
allow(ActivityPub::UpdateDistributionWorker).to receive(:perform_async)
|
|
put :update, params: { account: { display_name: 'New name' } }
|
|
expect(account.reload.display_name).to eq 'New name'
|
|
expect(response).to redirect_to(settings_profile_path)
|
|
expect(ActivityPub::UpdateDistributionWorker).to have_received(:perform_async).with(account.id)
|
|
end
|
|
end
|
|
|
|
describe 'PUT #update with new profile image' do
|
|
it 'updates profile image' do
|
|
allow(ActivityPub::UpdateDistributionWorker).to receive(:perform_async)
|
|
expect(account.avatar.instance.avatar_file_name).to be_nil
|
|
|
|
put :update, params: { account: { avatar: fixture_file_upload('avatar.gif', 'image/gif') } }
|
|
expect(response).to redirect_to(settings_profile_path)
|
|
expect(account.reload.avatar.instance.avatar_file_name).not_to be_nil
|
|
expect(ActivityPub::UpdateDistributionWorker).to have_received(:perform_async).with(account.id)
|
|
end
|
|
end
|
|
|
|
describe 'PUT #update with oversized image' do
|
|
it 'gives the user an error message' do
|
|
allow(ActivityPub::UpdateDistributionWorker).to receive(:perform_async)
|
|
put :update, params: { account: { avatar: fixture_file_upload('4096x4097.png', 'image/png') } }
|
|
expect(response.body).to include('images are not supported')
|
|
end
|
|
end
|
|
end
|