1
0
Fork 0
forked from fedi/mastodon
mastodon/spec/policies/backup_policy_spec.rb
Claire e38fc319dc
Refactor and improve tests ()
* Change account and user fabricators to simplify and improve tests

- `Fabricate(:account)` implicitly fabricates an associated `user` if
  no `domain` attribute is given (an account with `domain: nil` is
  considered a local account, but no user record was created), unless
  `user: nil` is passed
- `Fabricate(:account, user: Fabricate(:user))` should still be possible
  but is discouraged.

* Fix and refactor tests

- avoid passing unneeded attributes to `Fabricate(:user)` or
  `Fabricate(:account)`
- avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other
  way around
- prefer `Fabricate(:user, account_attributes: …)` to
  `Fabricate(:user, account: Fabricate(:account, …)`
- also, some tests were using remote accounts with local user records, which is
  not representative of production code.
2022-01-28 00:46:42 +01:00

46 lines
974 B
Ruby

# frozen_string_literal: true
require 'rails_helper'
require 'pundit/rspec'
RSpec.describe BackupPolicy do
let(:subject) { described_class }
let(:john) { Fabricate(:account) }
permissions :create? do
context 'not user_signed_in?' do
it 'denies' do
expect(subject).to_not permit(nil, Backup)
end
end
context 'user_signed_in?' do
context 'no backups' do
it 'permits' do
expect(subject).to permit(john, Backup)
end
end
context 'backups are too old' do
it 'permits' do
travel(-8.days) do
Fabricate(:backup, user: john.user)
end
expect(subject).to permit(john, Backup)
end
end
context 'backups are newer' do
it 'denies' do
travel(-3.days) do
Fabricate(:backup, user: john.user)
end
expect(subject).to_not permit(john, Backup)
end
end
end
end
end