1
0
Fork 1
forked from fedi/mastodon
mastodon/app
Stephen Burgess 4cfc155560 Improve aria support - Columns and Navigation Drawer Icons (#2299)
* feat(aria): Add aria-labels to underlabelled tab nav items

The drawer tabs which control primary navigation are only labelled by a title which is not available to many screenreaders. Add an aria-label attribute to each link to improve readability with screenreaders. Organize link attributes so link target is first followed by classname.
Issue #1349

* feat(aria): Replace abstract aria role of section with region

Abstract aria roles such as section should not be used in content. Use non-abstract 'region' aria role instead. That role expects an aria-labelledby attribute with an id. Pass an ID to the column header. Remove the aria-label attribute on the ColumnHeader because the same value is output in plaintext as its child.
Issue #1349

* fix(aria): Remove aria-controls attribute until solution is found

Columns do not have wrappers, so these icons can't point to a column wrapper which it controls. Instead these icons function as triggers to show or hide individual columns.
#1349

* fix(typo): Remove type of aria-labelledby instead of aria-label
2017-04-22 17:30:35 +02:00
..
assets Improve aria support - Columns and Navigation Drawer Icons (#2299) 2017-04-22 17:30:35 +02:00
controllers 2FA controller cleanup (#2296) 2017-04-22 04:23:17 +02:00
helpers Add tests for StreamEntriesHelper#rtl? (#2286) 2017-04-22 00:13:37 +02:00
lib [WIP] Html lang on statuses (#2297) 2017-04-22 04:26:25 +02:00
mailers Instance helper to replace site title helper (#2038) 2017-04-18 00:16:32 +02:00
models strip leading & trailing spaces from remote follow acct (#997) (#2321) 2017-04-22 15:08:30 +02:00
presenters Adds version to about/more and API (#2181) 2017-04-21 03:30:59 +02:00
services Improve bio compatibility (#2278) 2017-04-22 03:33:24 +02:00
validators Organize coverage dirs (#1695) 2017-04-13 16:00:31 +02:00
views Add og:url tags (#2298) 2017-04-22 17:29:46 +02:00
workers Quick best practice cleanup of views/helpers (#1546) 2017-04-12 18:24:18 +02:00