forked from fedi/mastodon
ec059317fa
* Add tests * Fix some link previews being incorrectly generated from different prior links PR #12403 added a cache to avoid redundant queries when the OEmbed endpoint can be guessed from the URL. This caching mechanism is not perfectly correct as there is no guarantee that all pages from a given domain share the same OEmbed provider endpoint. This PR prevents the FetchOEmbedService from caching OEmbed endpoint that cannot be generalized by replacing a fully-qualified URL from the endpoint's parameters, greatly reducing the number of incorrect cached generalizations.
203 lines
7.6 KiB
Ruby
203 lines
7.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe FetchOEmbedService, type: :service do
|
|
subject { described_class.new }
|
|
|
|
before do
|
|
stub_request(:get, "https://host.test/provider.json").to_return(status: 404)
|
|
stub_request(:get, "https://host.test/provider.xml").to_return(status: 404)
|
|
stub_request(:get, "https://host.test/empty_provider.json").to_return(status: 200)
|
|
end
|
|
|
|
describe 'discover_provider' do
|
|
context 'when status code is 200 and MIME type is text/html' do
|
|
context 'when OEmbed endpoint contains URL as parameter' do
|
|
before do
|
|
stub_request(:get, 'https://www.youtube.com/watch?v=IPSbNdBmWKE').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_youtube.html'),
|
|
)
|
|
stub_request(:get, 'https://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DIPSbNdBmWKE').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_json_empty.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider' do
|
|
subject.call('https://www.youtube.com/watch?v=IPSbNdBmWKE')
|
|
expect(subject.endpoint_url).to eq 'https://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DIPSbNdBmWKE'
|
|
expect(subject.format).to eq :json
|
|
end
|
|
|
|
it 'stores URL template' do
|
|
subject.call('https://www.youtube.com/watch?v=IPSbNdBmWKE')
|
|
expect(Rails.cache.read('oembed_endpoint:www.youtube.com')[:endpoint]).to eq 'https://www.youtube.com/oembed?format=json&url={url}'
|
|
end
|
|
end
|
|
|
|
context 'Both of JSON and XML provider are discoverable' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_json_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider if :format option is set to :json' do
|
|
subject.call('https://host.test/oembed.html', format: :json)
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.json'
|
|
expect(subject.format).to eq :json
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for XML provider if :format option is set to :xml' do
|
|
subject.call('https://host.test/oembed.html', format: :xml)
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.xml'
|
|
expect(subject.format).to eq :xml
|
|
end
|
|
|
|
it 'does not cache OEmbed endpoint' do
|
|
subject.call('https://host.test/oembed.html', format: :xml)
|
|
expect(Rails.cache.exist?('oembed_endpoint:host.test')).to eq false
|
|
end
|
|
end
|
|
|
|
context 'JSON provider is discoverable while XML provider is not' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_json.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider' do
|
|
subject.call('https://host.test/oembed.html')
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.json'
|
|
expect(subject.format).to eq :json
|
|
end
|
|
|
|
it 'does not cache OEmbed endpoint' do
|
|
subject.call('https://host.test/oembed.html')
|
|
expect(Rails.cache.exist?('oembed_endpoint:host.test')).to eq false
|
|
end
|
|
end
|
|
|
|
context 'XML provider is discoverable while JSON provider is not' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for XML provider' do
|
|
subject.call('https://host.test/oembed.html')
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.xml'
|
|
expect(subject.format).to eq :xml
|
|
end
|
|
|
|
it 'does not cache OEmbed endpoint' do
|
|
subject.call('https://host.test/oembed.html')
|
|
expect(Rails.cache.exist?('oembed_endpoint:host.test')).to eq false
|
|
end
|
|
end
|
|
|
|
context 'Invalid XML provider is discoverable while JSON provider is not' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_invalid_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns nil' do
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'Neither of JSON and XML provider is discoverable' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_undiscoverable.html')
|
|
)
|
|
end
|
|
|
|
it 'returns nil' do
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'Empty JSON provider is discoverable' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_json_empty.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider' do
|
|
subject.call('https://host.test/oembed.html')
|
|
expect(subject.endpoint_url).to eq 'https://host.test/empty_provider.json'
|
|
expect(subject.format).to eq :json
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
context 'when endpoint is cached' do
|
|
before do
|
|
stub_request(:get, 'http://www.youtube.com/oembed?format=json&url=https://www.youtube.com/watch?v=dqwpQarrDwk').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_json_empty.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new provider without fetching original URL first' do
|
|
subject.call('https://www.youtube.com/watch?v=dqwpQarrDwk', cached_endpoint: { endpoint: 'http://www.youtube.com/oembed?format=json&url={url}', format: :json })
|
|
expect(a_request(:get, 'https://www.youtube.com/watch?v=dqwpQarrDwk')).to_not have_been_made
|
|
expect(subject.endpoint_url).to eq 'http://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DdqwpQarrDwk'
|
|
expect(subject.format).to eq :json
|
|
expect(a_request(:get, 'http://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DdqwpQarrDwk')).to have_been_made
|
|
end
|
|
end
|
|
|
|
context 'when status code is not 200' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 400,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns nil' do
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when MIME type is not text/html' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
body: request_fixture('oembed_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns nil' do
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
|
end
|
|
end
|
|
end
|
|
end
|