specter/CyTube
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix another bug with prometheus socket.io emtrics

Browse source
This commit is contained in:
Calvin Montgomery 2017-09-19 19:03:43 -07:00
parent 9a1d50dcd3
commit de5cc3352a
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/io/ioserver.js
View file

@ -275,6 +275,7 @@ const promSocketDisconnect = new Counter({
}); });
function emitMetrics(sock) { function emitMetrics(sock) {
try { try {
let closed = false;
let transportName = sock.client.conn.transport.name; let transportName = sock.client.conn.transport.name;
promSocketCount.inc({ transport: transportName }); promSocketCount.inc({ transport: transportName });
promSocketAccept.inc(1, new Date()); promSocketAccept.inc(1, new Date());
@ -282,7 +283,7 @@ function emitMetrics(sock) {
sock.client.conn.on('upgrade', newTransport => { sock.client.conn.on('upgrade', newTransport => {
try { try {
// Sanity check // Sanity check
if (newTransport.name !== transportName) { if (!closed && newTransport.name !== transportName) {
promSocketCount.dec({ transport: transportName }); promSocketCount.dec({ transport: transportName });
transportName = newTransport.name; transportName = newTransport.name;
promSocketCount.inc({ transport: transportName }); promSocketCount.inc({ transport: transportName });
@ -295,6 +296,7 @@ function emitMetrics(sock) {
sock.once('disconnect', () => { sock.once('disconnect', () => {
try { try {
closed = true;
promSocketCount.dec({ transport: transportName }); promSocketCount.dec({ transport: transportName });
promSocketDisconnect.inc(1, new Date()); promSocketDisconnect.inc(1, new Date());
} catch (error) { } catch (error) {