specter/CyTube
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Handle some common error conditions in the ffprobe preflight path

Browse source
This commit is contained in:
Calvin Montgomery 2020-11-11 21:26:02 -08:00
parent 750509eaf1
commit 66fadab492
1 changed files with 31 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
src/ffmpeg.js
View file

@ -34,6 +34,10 @@ const ECODE_MESSAGES = {
"The remote server is unreachable from this server. " + "The remote server is unreachable from this server. " +
"Please contact the video server's administrator for assistance." "Please contact the video server's administrator for assistance."
), ),
ENOMEM: _e => (
"An out of memory error caused the request to fail. Please contact an " +
"administrator for assistance."
),
DEPTH_ZERO_SELF_SIGNED_CERT: _e => ( DEPTH_ZERO_SELF_SIGNED_CERT: _e => (
'The remote server provided an invalid ' + 'The remote server provided an invalid ' +
@ -41,6 +45,12 @@ const ECODE_MESSAGES = {
'trusted certificate. See https://letsencrypt.org/ to get ' + 'trusted certificate. See https://letsencrypt.org/ to get ' +
'a free, trusted certificate.' 'a free, trusted certificate.'
), ),
SELF_SIGNED_CERT_IN_CHAIN: _e => (
'The remote server provided an invalid ' +
'(self-signed) SSL certificate. Raw file support requires a ' +
'trusted certificate. See https://letsencrypt.org/ to get ' +
'a free, trusted certificate.'
),
UNABLE_TO_VERIFY_LEAF_SIGNATURE: _e => ( UNABLE_TO_VERIFY_LEAF_SIGNATURE: _e => (
"The remote server's SSL certificate chain could not be validated. " + "The remote server's SSL certificate chain could not be validated. " +
"Please contact the administrator of the server to correct their " + "Please contact the administrator of the server to correct their " +
@ -49,6 +59,16 @@ const ECODE_MESSAGES = {
CERT_HAS_EXPIRED: _e => ( CERT_HAS_EXPIRED: _e => (
"The remote server's SSL certificate has expired. Please contact " + "The remote server's SSL certificate has expired. Please contact " +
"the administrator of the server to renew the certificate." "the administrator of the server to renew the certificate."
),
ERR_TLS_CERT_ALTNAME_INVALID: _e => (
"The remote server's SSL connection is misconfigured and has served " +
"a certificate invalid for the given link."
),
// node's http parser barfs when careless servers ignore RFC 2616 and send a
// response body in reply to a HEAD request
HPE_INVALID_CONSTANT: _e => (
"The remote server for this link is misconfigured."
) )
}; };
@ -208,22 +228,19 @@ function testUrl(url, cb, params = { redirCount: 0, cookie: '' }) {
return; return;
} }
// HPE_INVALID_CONSTANT comes from node's HTTP parser because LOGGER.error(
// facebook's CDN violates RFC 2616 by sending a body even though "Error sending preflight request: %s (code=%s) (link: %s)",
// the request uses the HEAD method. err.message,
// Avoid logging this because it's a known issue. err.code,
if (!(err.code === 'HPE_INVALID_CONSTANT' && /fbcdn/.test(url))) { url
LOGGER.error( );
"Error sending preflight request: %s (code=%s) (link: %s)",
err.message,
err.code,
url
);
}
cb("An unexpected error occurred while trying to process the link. " + cb("An unexpected error occurred while trying to process the link. " +
"Try again, and contact support for further troubleshooting if the " + "If this link is hosted on a server you own, it is likely " +
"problem continues." + (err.code ? (" Error code: " + err.code) : "")); "misconfigured and you can join community support for assistance. " +
"If you are attempting to add links from third party websites, the " +
"developers do not provide support for this." +
(err.code ? (" Error code: " + err.code) : ""));
}); });
req.end(); req.end();