specter/CyTube
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

soundcloud: fix volume issue

Browse source 
It took them 4 years, but they finally did actually make the player
accept volume in the range 0-100 like their documentation suggests.

*slow clap*
This commit is contained in:
Calvin Montgomery 2017-07-10 21:38:27 -07:00
parent fc66e758ac
commit 30a5657d62
2 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
player/soundcloud.coffee
View file

@ -91,13 +91,8 @@ window.SoundCloudPlayer = class SoundCloudPlayer extends Player
@soundcloud.seekTo(time * 1000)
setVolume: (volume) ->
# NOTE: SoundCloud's documentation claims that setVolume() accepts
# volumes in the range [0, 100], however it *actually* accepts volumes
# in the range [0, 1] (anything larger than 1 is treated as 1). I
# emailed them about this 2 years ago and they still haven't fixed
# their documentation.
if @soundcloud and @soundcloud.ready
@soundcloud.setVolume(volume)
@soundcloud.setVolume(volume * 100)
getTime: (cb) ->
if @soundcloud and @soundcloud.ready

6
www/js/player.js
View file

@ -452,10 +452,10 @@
console.error('sortSources() called with null source list');
return [];
}
qualities = ['1080', '720', '480', '360', '240'];
qualities = ['2160', '1440', '1080', '720', '540', '480', '360', '240'];
pref = String(USEROPTS.default_quality);
if (USEROPTS.default_quality === 'best') {
pref = '1080';
pref = '2160';
}
idx = qualities.indexOf(pref);
if (idx < 0) {
@ -880,7 +880,7 @@
SoundCloudPlayer.prototype.setVolume = function(volume) {
if (this.soundcloud && this.soundcloud.ready) {
return this.soundcloud.setVolume(volume);
return this.soundcloud.setVolume(volume * 100);
}
};