specter/CyTube
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix incorrect parsing of x-forwarded-for in webserver.ipForRequest

Browse source
This commit is contained in:
calzoneman 2014-04-17 00:03:32 -05:00
parent d4885951fb
commit 2a507fcac5
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/web/webserver.js
View file

@ -37,11 +37,18 @@ function ipForRequest(req) {
var ip = req.ip; var ip = req.ip;
if (ip === "127.0.0.1" || ip === "::1") { if (ip === "127.0.0.1" || ip === "::1") {
var xforward = req.header("x-forwarded-for"); var xforward = req.header("x-forwarded-for");
if (typeof xforward !== "string" || !net.isIP(xforward)) { if (typeof xforward !== "string") {
return ip; xforward = [];
} else { } else {
return xforward; xforward = xforward.split(",");
} }
for (var i = 0; i < xforward.length; i++) {
if (net.isIP(xforward[i])) {
return xforward[i];
}
}
return ip;
} }
return ip; return ip;
} }