specter/CyTube
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Give up early if username is invalid for rank change

Browse source
This commit is contained in:
calzoneman 2014-09-01 20:33:11 -05:00
parent 66865f718c
commit 12447ce5dc
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/channel/ranks.js
View file

@ -35,7 +35,7 @@ RankModule.prototype.sendChannelRanks = function (users) {
if (err) { if (err) {
return; return;
} }
users.forEach(function (u) { users.forEach(function (u) {
if (u.account.effectiveRank >= 3) { if (u.account.effectiveRank >= 3) {
u.socket.emit("channelRanks", ranks); u.socket.emit("channelRanks", ranks);
@ -70,6 +70,13 @@ RankModule.prototype.handleRankChange = function (user, data) {
var userrank = user.account.effectiveRank; var userrank = user.account.effectiveRank;
var name = data.name.substring(0, 20).toLowerCase(); var name = data.name.substring(0, 20).toLowerCase();
if (!name.match(/^[a-zA-Z0-9_-]{1,20}$/)) {
user.socket.emit("channelRankFail", {
msg: "Invalid target name " + data.name
});
return;
}
if (isNaN(rank) || rank < 1 || (rank >= userrank && !(userrank === 4 && rank === 4))) { if (isNaN(rank) || rank < 1 || (rank >= userrank && !(userrank === 4 && rank === 4))) {
user.socket.emit("channelRankFail", { user.socket.emit("channelRankFail", {
msg: "Updating user rank failed: You can't promote someone to a rank equal " + msg: "Updating user rank failed: You can't promote someone to a rank equal " +