From 9775db753f1bbbf06e6297ef127cf8a24205825a Mon Sep 17 00:00:00 2001
From: Ryan Stafford <ryan@nanorex.net>
Date: Tue, 9 Jul 2024 22:04:02 -0400
Subject: [PATCH] dont set default cookies

---
 routes.go | 31 ++++++++++++++++++++++---------
 1 file changed, 22 insertions(+), 9 deletions(-)

diff --git a/routes.go b/routes.go
index b467e5e..2d498ba 100644
--- a/routes.go
+++ b/routes.go
@@ -264,10 +264,17 @@ func RegReplace(input string, match string, replace string) string {
 	return re.ReplaceAllString(input, replace)
 }
 
-func getenv(key, fallback string) string {
+func getenv(key string) string {
 	value := os.Getenv(key)
 	if len(value) == 0 {
-		return fallback
+		switch key {
+		case "SORT", "COMMENT_SORT":
+			return "Hot"
+		case "LISTING":
+			return "All"
+		default:
+			return ""
+		}
 	}
 	return value
 }
@@ -343,13 +350,13 @@ func Initialize(Host string, r *http.Request) (State, error) {
 	}
 	state.ParseQuery(r.URL.RawQuery)
 	if state.Sort == "" {
-		state.Sort = getenv("SORT", "Hot")
+		state.Sort = getenv("SORT")
 	}
 	if state.CommentSort == "" {
-		state.CommentSort = getenv("COMMENT_SORT", "Hot")
+		state.CommentSort = getenv("COMMENT_SORT")
 	}
 	if state.Listing == "" || state.Session == nil && state.Listing == "Subscribed" {
-		state.Listing = getenv("LISTING", "All")
+		state.Listing = getenv("LISTING")
 	}
 	if linksInNewWindow := getCookie(r, "LinksInNewWindow"); linksInNewWindow != "" {
 		state.LinksInNewWindow = linksInNewWindow != "0"
@@ -832,10 +839,12 @@ func setCookies(w http.ResponseWriter, state *State) {
 	bools["CollapseMedia"] = state.CollapseMedia
 	bools["LinksInNewWindow"] = state.LinksInNewWindow
 	for k, v := range bools {
-		if v {
-			setCookie(w, "", k, "1")
-		} else if e, ok := env[k]; ok && os.Getenv(e) != "" {
+		e, ok := env[k]
+		ev := (ok && os.Getenv(e) != "")
+		if !v && ev {
 			setCookie(w, "", k, "0")
+		} else if v && !ev {
+			setCookie(w, "", k, "1")
 		} else {
 			deleteCookie(w, "", k)
 		}
@@ -845,7 +854,11 @@ func setCookies(w http.ResponseWriter, state *State) {
 	strings["DefaultListingType"] = state.Listing
 	strings["DefaultCommentSortType"] = state.CommentSort
 	for k, v := range strings {
-		setCookie(w, "", k, v)
+		if e, ok := env[k]; ok && getenv(e) == v {
+			deleteCookie(w, "", k)
+		} else {
+			setCookie(w, "", k, v)
+		}
 	}
 	if state.Dark == nil {
 		deleteCookie(w, "", "Dark")