mirror of
https://github.com/mastodon/mastodon.git
synced 2024-12-12 05:24:56 +00:00
4b68e82a19
Ditto for ending with \b.
Consider muting the phrase "(hot take)". I stipulate it is reasonable
to enter this with the default "match whole word" behavior. Under the
old behavior, this would be encoded as
\b\(hot\ take\)\b
However, if \b is before the first character in the string and the first
character in the string is not a word character, then the match will
fail. Ditto for after. In our example, "(" is not a word character, so
this will not match statuses containing "(hot take)", and that's a very
surprising behavior.
To address this, we only add leading and trailing \b to keywords that
start or end with word characters.
90 lines
2.8 KiB
Ruby
90 lines
2.8 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Glitch::KeywordMute, type: :model do
|
|
let(:alice) { Fabricate(:account, username: 'alice').tap(&:save!) }
|
|
let(:bob) { Fabricate(:account, username: 'bob').tap(&:save!) }
|
|
|
|
describe '.matcher_for' do
|
|
let(:matcher) { Glitch::KeywordMute.matcher_for(alice) }
|
|
|
|
describe 'with no mutes' do
|
|
before do
|
|
Glitch::KeywordMute.delete_all
|
|
end
|
|
|
|
it 'does not match' do
|
|
expect(matcher =~ 'This is a hot take').to be_falsy
|
|
end
|
|
end
|
|
|
|
describe 'with mutes' do
|
|
it 'does not match keywords set by a different account' do
|
|
Glitch::KeywordMute.create!(account: bob, keyword: 'take')
|
|
|
|
expect(matcher =~ 'This is a hot take').to be_falsy
|
|
end
|
|
|
|
it 'does not match if no keywords match the status text' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: 'cold')
|
|
|
|
expect(matcher =~ 'This is a hot take').to be_falsy
|
|
end
|
|
|
|
it 'considers word boundaries when matching' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: 'bob', whole_word: true)
|
|
|
|
expect(matcher =~ 'bobcats').to be_falsy
|
|
end
|
|
|
|
it 'matches substrings if whole_word is false' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: 'take', whole_word: false)
|
|
|
|
expect(matcher =~ 'This is a shiitake mushroom').to be_truthy
|
|
end
|
|
|
|
it 'matches keywords at the beginning of the text' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: 'take')
|
|
|
|
expect(matcher =~ 'Take this').to be_truthy
|
|
end
|
|
|
|
it 'matches keywords at the beginning of the text' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: 'take')
|
|
|
|
expect(matcher =~ 'This is a hot take').to be_truthy
|
|
end
|
|
|
|
it 'matches if at least one keyword case-insensitively matches the text' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: 'hot')
|
|
|
|
expect(matcher =~ 'This is a HOT take').to be_truthy
|
|
end
|
|
|
|
it 'matches keywords surrounded by non-alphanumeric ornamentation' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: 'hot')
|
|
|
|
expect(matcher =~ '(hot take)').to be_truthy
|
|
end
|
|
|
|
it 'escapes metacharacters in keywords' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: '(hot take)')
|
|
|
|
expect(matcher =~ '(hot take)').to be_truthy
|
|
end
|
|
|
|
it 'uses case-folding rules appropriate for more than just English' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: 'großeltern')
|
|
|
|
expect(matcher =~ 'besuch der grosseltern').to be_truthy
|
|
end
|
|
|
|
it 'matches keywords that are composed of multiple words' do
|
|
Glitch::KeywordMute.create!(account: alice, keyword: 'a shiitake')
|
|
|
|
expect(matcher =~ 'This is a shiitake').to be_truthy
|
|
expect(matcher =~ 'This is shiitake').to_not be_truthy
|
|
end
|
|
end
|
|
end
|
|
end
|