mirror of
https://github.com/mastodon/mastodon.git
synced 2024-12-23 17:44:24 +00:00
8cf7006d4e
* Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is specifically required to be an Account * Refactor SignatureVerification to allow non-Account actors * fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService * Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors * Refactor inbound ActivityPub payload processing to accept non-Account actors * Refactor inbound ActivityPub processing to accept activities relayed through non-Account * Refactor how Account key URIs are built * Refactor Request and drop unused key_id_format parameter * Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`
237 lines
7.4 KiB
Ruby
237 lines
7.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe ActivityPub::OutboxesController, type: :controller do
|
|
let!(:account) { Fabricate(:account) }
|
|
|
|
shared_examples 'cacheable response' do
|
|
it 'does not set cookies' do
|
|
expect(response.cookies).to be_empty
|
|
expect(response.headers['Set-Cookies']).to be nil
|
|
end
|
|
|
|
it 'does not set sessions' do
|
|
response
|
|
expect(session).to be_empty
|
|
end
|
|
|
|
it 'returns public Cache-Control header' do
|
|
expect(response.headers['Cache-Control']).to include 'public'
|
|
end
|
|
end
|
|
|
|
before do
|
|
Fabricate(:status, account: account, visibility: :public)
|
|
Fabricate(:status, account: account, visibility: :unlisted)
|
|
Fabricate(:status, account: account, visibility: :private)
|
|
Fabricate(:status, account: account, visibility: :direct)
|
|
Fabricate(:status, account: account, visibility: :limited)
|
|
end
|
|
|
|
before do
|
|
allow(controller).to receive(:signed_request_actor).and_return(remote_account)
|
|
end
|
|
|
|
describe 'GET #show' do
|
|
context 'without signature' do
|
|
let(:remote_account) { nil }
|
|
|
|
subject(:response) { get :show, params: { account_username: account.username, page: page } }
|
|
subject(:body) { body_as_json }
|
|
|
|
context 'with page not requested' do
|
|
let(:page) { nil }
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'returns application/activity+json' do
|
|
expect(response.media_type).to eq 'application/activity+json'
|
|
end
|
|
|
|
it 'returns totalItems' do
|
|
expect(body[:totalItems]).to eq 4
|
|
end
|
|
|
|
it_behaves_like 'cacheable response'
|
|
|
|
it 'does not have a Vary header' do
|
|
expect(response.headers['Vary']).to be_nil
|
|
end
|
|
|
|
context 'when account is permanently suspended' do
|
|
before do
|
|
account.suspend!
|
|
account.deletion_request.destroy
|
|
end
|
|
|
|
it 'returns http gone' do
|
|
expect(response).to have_http_status(410)
|
|
end
|
|
end
|
|
|
|
context 'when account is temporarily suspended' do
|
|
before do
|
|
account.suspend!
|
|
end
|
|
|
|
it 'returns http forbidden' do
|
|
expect(response).to have_http_status(403)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with page requested' do
|
|
let(:page) { 'true' }
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'returns application/activity+json' do
|
|
expect(response.media_type).to eq 'application/activity+json'
|
|
end
|
|
|
|
it 'returns orderedItems with public or unlisted statuses' do
|
|
expect(body[:orderedItems]).to be_an Array
|
|
expect(body[:orderedItems].size).to eq 2
|
|
expect(body[:orderedItems].all? { |item| item[:to].include?(ActivityPub::TagManager::COLLECTIONS[:public]) || item[:cc].include?(ActivityPub::TagManager::COLLECTIONS[:public]) }).to be true
|
|
end
|
|
|
|
it_behaves_like 'cacheable response'
|
|
|
|
it 'returns Vary header with Signature' do
|
|
expect(response.headers['Vary']).to include 'Signature'
|
|
end
|
|
|
|
context 'when account is permanently suspended' do
|
|
before do
|
|
account.suspend!
|
|
account.deletion_request.destroy
|
|
end
|
|
|
|
it 'returns http gone' do
|
|
expect(response).to have_http_status(410)
|
|
end
|
|
end
|
|
|
|
context 'when account is temporarily suspended' do
|
|
before do
|
|
account.suspend!
|
|
end
|
|
|
|
it 'returns http forbidden' do
|
|
expect(response).to have_http_status(403)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with signature' do
|
|
let(:remote_account) { Fabricate(:account, domain: 'example.com') }
|
|
let(:page) { 'true' }
|
|
|
|
context 'when signed request account does not follow account' do
|
|
before do
|
|
get :show, params: { account_username: account.username, page: page }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'returns application/activity+json' do
|
|
expect(response.media_type).to eq 'application/activity+json'
|
|
end
|
|
|
|
it 'returns orderedItems with public or unlisted statuses' do
|
|
json = body_as_json
|
|
expect(json[:orderedItems]).to be_an Array
|
|
expect(json[:orderedItems].size).to eq 2
|
|
expect(json[:orderedItems].all? { |item| item[:to].include?(ActivityPub::TagManager::COLLECTIONS[:public]) || item[:cc].include?(ActivityPub::TagManager::COLLECTIONS[:public]) }).to be true
|
|
end
|
|
|
|
it 'returns private Cache-Control header' do
|
|
expect(response.headers['Cache-Control']).to eq 'max-age=60, private'
|
|
end
|
|
end
|
|
|
|
context 'when signed request account follows account' do
|
|
before do
|
|
remote_account.follow!(account)
|
|
get :show, params: { account_username: account.username, page: page }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'returns application/activity+json' do
|
|
expect(response.media_type).to eq 'application/activity+json'
|
|
end
|
|
|
|
it 'returns orderedItems with private statuses' do
|
|
json = body_as_json
|
|
expect(json[:orderedItems]).to be_an Array
|
|
expect(json[:orderedItems].size).to eq 3
|
|
expect(json[:orderedItems].all? { |item| item[:to].include?(ActivityPub::TagManager::COLLECTIONS[:public]) || item[:cc].include?(ActivityPub::TagManager::COLLECTIONS[:public]) || item[:to].include?(account_followers_url(account, ActionMailer::Base.default_url_options)) }).to be true
|
|
end
|
|
|
|
it 'returns private Cache-Control header' do
|
|
expect(response.headers['Cache-Control']).to eq 'max-age=60, private'
|
|
end
|
|
end
|
|
|
|
context 'when signed request account is blocked' do
|
|
before do
|
|
account.block!(remote_account)
|
|
get :show, params: { account_username: account.username, page: page }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'returns application/activity+json' do
|
|
expect(response.media_type).to eq 'application/activity+json'
|
|
end
|
|
|
|
it 'returns empty orderedItems' do
|
|
json = body_as_json
|
|
expect(json[:orderedItems]).to be_an Array
|
|
expect(json[:orderedItems].size).to eq 0
|
|
end
|
|
|
|
it 'returns private Cache-Control header' do
|
|
expect(response.headers['Cache-Control']).to eq 'max-age=60, private'
|
|
end
|
|
end
|
|
|
|
context 'when signed request account is domain blocked' do
|
|
before do
|
|
account.block_domain!(remote_account.domain)
|
|
get :show, params: { account_username: account.username, page: page }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'returns application/activity+json' do
|
|
expect(response.media_type).to eq 'application/activity+json'
|
|
end
|
|
|
|
it 'returns empty orderedItems' do
|
|
json = body_as_json
|
|
expect(json[:orderedItems]).to be_an Array
|
|
expect(json[:orderedItems].size).to eq 0
|
|
end
|
|
|
|
it 'returns private Cache-Control header' do
|
|
expect(response.headers['Cache-Control']).to eq 'max-age=60, private'
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|