mirror of
https://github.com/mastodon/mastodon.git
synced 2024-11-14 02:44:13 +00:00
e95bdec7c5
- Use statuses controller for embeds instead of stream entries controller - Prefer /@:username/:id/embed URL for embeds - Use /@:username as author_url in OEmbed - Add follow link to embeds which opens web intent in new window - Use redis cache in development - Cache entire embed
103 lines
4.9 KiB
Plaintext
103 lines
4.9 KiB
Plaintext
{
|
|
"ignored_warnings": [
|
|
{
|
|
"warning_type": "Dynamic Render Path",
|
|
"warning_code": 15,
|
|
"fingerprint": "44d3f14e05d8fbb5b23e13ac02f15aa38b2a2f0f03b9ba76bab7f98e155a4a4e",
|
|
"check_name": "Render",
|
|
"message": "Render path contains parameter value",
|
|
"file": "app/views/stream_entries/embed.html.haml",
|
|
"line": 3,
|
|
"link": "http://brakemanscanner.org/docs/warning_types/dynamic_render_path/",
|
|
"code": "render(action => \"stream_entries/#{Account.find_local!(params[:account_username]).statuses.find(params[:id]).stream_entry.activity_type.downcase}\", { Account.find_local!(params[:account_username]).statuses.find(params[:id]).stream_entry.activity_type.downcase.to_sym => Account.find_local!(params[:account_username]).statuses.find(params[:id]).stream_entry.activity, :centered => true })",
|
|
"render_path": [{"type":"controller","class":"StatusesController","method":"embed","line":35,"file":"app/controllers/statuses_controller.rb"}],
|
|
"location": {
|
|
"type": "template",
|
|
"template": "stream_entries/embed"
|
|
},
|
|
"user_input": "params[:id]",
|
|
"confidence": "Weak",
|
|
"note": ""
|
|
},
|
|
{
|
|
"warning_type": "Dynamic Render Path",
|
|
"warning_code": 15,
|
|
"fingerprint": "9f31d941f3910dba2e9bfcd81aef4513249bd24c02d0f98e13ad44fdeeccd0e8",
|
|
"check_name": "Render",
|
|
"message": "Render path contains parameter value",
|
|
"file": "app/views/admin/accounts/index.html.haml",
|
|
"line": 63,
|
|
"link": "http://brakemanscanner.org/docs/warning_types/dynamic_render_path/",
|
|
"code": "render(action => filtered_accounts.page(params[:page]), {})",
|
|
"render_path": [{"type":"controller","class":"Admin::AccountsController","method":"index","line":10,"file":"app/controllers/admin/accounts_controller.rb"}],
|
|
"location": {
|
|
"type": "template",
|
|
"template": "admin/accounts/index"
|
|
},
|
|
"user_input": "params[:page]",
|
|
"confidence": "Weak",
|
|
"note": ""
|
|
},
|
|
{
|
|
"warning_type": "Redirect",
|
|
"warning_code": 18,
|
|
"fingerprint": "bb7e94e60af41decb811bb32171f1b27e9bf3f4d01e9e511127362e22510eb11",
|
|
"check_name": "Redirect",
|
|
"message": "Possible unprotected redirect",
|
|
"file": "app/controllers/remote_follow_controller.rb",
|
|
"line": 18,
|
|
"link": "http://brakemanscanner.org/docs/warning_types/redirect/",
|
|
"code": "redirect_to(RemoteFollow.new(resource_params).subscribe_address_for(Account.find_local!(params[:account_username])))",
|
|
"render_path": null,
|
|
"location": {
|
|
"type": "method",
|
|
"class": "RemoteFollowController",
|
|
"method": "create"
|
|
},
|
|
"user_input": "RemoteFollow.new(resource_params).subscribe_address_for(Account.find_local!(params[:account_username]))",
|
|
"confidence": "High",
|
|
"note": ""
|
|
},
|
|
{
|
|
"warning_type": "Dynamic Render Path",
|
|
"warning_code": 15,
|
|
"fingerprint": "c5d6945d63264af106d49367228d206aa2f176699ecdce2b98fac101bc6a96cf",
|
|
"check_name": "Render",
|
|
"message": "Render path contains parameter value",
|
|
"file": "app/views/admin/reports/index.html.haml",
|
|
"line": 24,
|
|
"link": "http://brakemanscanner.org/docs/warning_types/dynamic_render_path/",
|
|
"code": "render(action => filtered_reports.page(params[:page]), {})",
|
|
"render_path": [{"type":"controller","class":"Admin::ReportsController","method":"index","line":9,"file":"app/controllers/admin/reports_controller.rb"}],
|
|
"location": {
|
|
"type": "template",
|
|
"template": "admin/reports/index"
|
|
},
|
|
"user_input": "params[:page]",
|
|
"confidence": "Weak",
|
|
"note": ""
|
|
},
|
|
{
|
|
"warning_type": "Dynamic Render Path",
|
|
"warning_code": 15,
|
|
"fingerprint": "fbd0fc59adb5c6d44b60e02debb31d3af11719f534c9881e21435bbff87404d6",
|
|
"check_name": "Render",
|
|
"message": "Render path contains parameter value",
|
|
"file": "app/views/stream_entries/show.html.haml",
|
|
"line": 23,
|
|
"link": "http://brakemanscanner.org/docs/warning_types/dynamic_render_path/",
|
|
"code": "render(partial => \"stream_entries/#{Account.find_local!(params[:account_username]).statuses.find(params[:id]).stream_entry.activity_type.downcase}\", { :locals => ({ Account.find_local!(params[:account_username]).statuses.find(params[:id]).stream_entry.activity_type.downcase.to_sym => Account.find_local!(params[:account_username]).statuses.find(params[:id]).stream_entry.activity, :include_threads => true }) })",
|
|
"render_path": [{"type":"controller","class":"StatusesController","method":"show","line":20,"file":"app/controllers/statuses_controller.rb"}],
|
|
"location": {
|
|
"type": "template",
|
|
"template": "stream_entries/show"
|
|
},
|
|
"user_input": "params[:id]",
|
|
"confidence": "Weak",
|
|
"note": ""
|
|
}
|
|
],
|
|
"updated": "2017-08-30 05:14:04 +0200",
|
|
"brakeman_version": "3.7.2"
|
|
}
|