mirror of
https://github.com/mastodon/mastodon.git
synced 2024-11-30 00:30:40 +00:00
9d3c6f1849
* Fetch up to 5 replies when discovering a new remote status This is used for resolving threads downwards. The originating server must add a “replies” attributes with such replies for it to be useful. * Add some tests for ActivityPub::FetchRepliesWorker * Add specs for ActivityPub::FetchRepliesService * Serialize up to 5 public self-replies for ActivityPub notes * Add specs for ActivityPub::NoteSerializer * Move exponential backoff logic to a worker concern * Fetch first page of paginated collections when fetching thread replies * Add specs for paginated collections in replies * Move Note replies serialization to a first CollectionPage The collection isn't actually paginable yet as it has no id nor a `next` field. This may come in another PR. * Use pluck(:uri) instead of map(&:uri) to improve performances * Fix fetching replies when they are in a CollectionPage
123 lines
5 KiB
Ruby
123 lines
5 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe ActivityPub::FetchRepliesService, type: :service do
|
|
let(:actor) { Fabricate(:account, domain: 'example.com', uri: 'http://example.com/account') }
|
|
let(:status) { Fabricate(:status, account: actor) }
|
|
let(:collection_uri) { 'http://example.com/replies/1' }
|
|
|
|
let(:items) do
|
|
[
|
|
'http://example.com/self-reply-1',
|
|
'http://example.com/self-reply-2',
|
|
'http://example.com/self-reply-3',
|
|
'http://other.com/other-reply-1',
|
|
'http://other.com/other-reply-2',
|
|
'http://other.com/other-reply-3',
|
|
'http://example.com/self-reply-4',
|
|
'http://example.com/self-reply-5',
|
|
'http://example.com/self-reply-6',
|
|
]
|
|
end
|
|
|
|
let(:payload) do
|
|
{
|
|
'@context': 'https://www.w3.org/ns/activitystreams',
|
|
type: 'Collection',
|
|
id: collection_uri,
|
|
items: items,
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
subject { described_class.new }
|
|
|
|
describe '#call' do
|
|
context 'when the payload is a Collection with inlined replies' do
|
|
context 'when passing the collection itself' do
|
|
it 'spawns workers for up to 5 replies on the same server' do
|
|
allow(FetchReplyWorker).to receive(:push_bulk)
|
|
subject.call(status, payload)
|
|
expect(FetchReplyWorker).to have_received(:push_bulk).with(['http://example.com/self-reply-1', 'http://example.com/self-reply-2', 'http://example.com/self-reply-3', 'http://example.com/self-reply-4', 'http://example.com/self-reply-5'])
|
|
end
|
|
end
|
|
|
|
context 'when passing the URL to the collection' do
|
|
before do
|
|
stub_request(:get, collection_uri).to_return(status: 200, body: Oj.dump(payload))
|
|
end
|
|
|
|
it 'spawns workers for up to 5 replies on the same server' do
|
|
allow(FetchReplyWorker).to receive(:push_bulk)
|
|
subject.call(status, collection_uri)
|
|
expect(FetchReplyWorker).to have_received(:push_bulk).with(['http://example.com/self-reply-1', 'http://example.com/self-reply-2', 'http://example.com/self-reply-3', 'http://example.com/self-reply-4', 'http://example.com/self-reply-5'])
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the payload is an OrderedCollection with inlined replies' do
|
|
let(:payload) do
|
|
{
|
|
'@context': 'https://www.w3.org/ns/activitystreams',
|
|
type: 'OrderedCollection',
|
|
id: collection_uri,
|
|
orderedItems: items,
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
context 'when passing the collection itself' do
|
|
it 'spawns workers for up to 5 replies on the same server' do
|
|
allow(FetchReplyWorker).to receive(:push_bulk)
|
|
subject.call(status, payload)
|
|
expect(FetchReplyWorker).to have_received(:push_bulk).with(['http://example.com/self-reply-1', 'http://example.com/self-reply-2', 'http://example.com/self-reply-3', 'http://example.com/self-reply-4', 'http://example.com/self-reply-5'])
|
|
end
|
|
end
|
|
|
|
context 'when passing the URL to the collection' do
|
|
before do
|
|
stub_request(:get, collection_uri).to_return(status: 200, body: Oj.dump(payload))
|
|
end
|
|
|
|
it 'spawns workers for up to 5 replies on the same server' do
|
|
allow(FetchReplyWorker).to receive(:push_bulk)
|
|
subject.call(status, collection_uri)
|
|
expect(FetchReplyWorker).to have_received(:push_bulk).with(['http://example.com/self-reply-1', 'http://example.com/self-reply-2', 'http://example.com/self-reply-3', 'http://example.com/self-reply-4', 'http://example.com/self-reply-5'])
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the payload is a paginated Collection with inlined replies' do
|
|
let(:payload) do
|
|
{
|
|
'@context': 'https://www.w3.org/ns/activitystreams',
|
|
type: 'Collection',
|
|
id: collection_uri,
|
|
first: {
|
|
type: 'CollectionPage',
|
|
partOf: collection_uri,
|
|
items: items,
|
|
}
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
context 'when passing the collection itself' do
|
|
it 'spawns workers for up to 5 replies on the same server' do
|
|
allow(FetchReplyWorker).to receive(:push_bulk)
|
|
subject.call(status, payload)
|
|
expect(FetchReplyWorker).to have_received(:push_bulk).with(['http://example.com/self-reply-1', 'http://example.com/self-reply-2', 'http://example.com/self-reply-3', 'http://example.com/self-reply-4', 'http://example.com/self-reply-5'])
|
|
end
|
|
end
|
|
|
|
context 'when passing the URL to the collection' do
|
|
before do
|
|
stub_request(:get, collection_uri).to_return(status: 200, body: Oj.dump(payload))
|
|
end
|
|
|
|
it 'spawns workers for up to 5 replies on the same server' do
|
|
allow(FetchReplyWorker).to receive(:push_bulk)
|
|
subject.call(status, collection_uri)
|
|
expect(FetchReplyWorker).to have_received(:push_bulk).with(['http://example.com/self-reply-1', 'http://example.com/self-reply-2', 'http://example.com/self-reply-3', 'http://example.com/self-reply-4', 'http://example.com/self-reply-5'])
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|