mirror of
https://github.com/mastodon/mastodon.git
synced 2024-12-25 18:26:34 +00:00
ae871c4d46
* Make Array-creation behavior of Paginable more predictable Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it returns an Array if min_id option is present. The behavior caused problems fixed with the following commits: -552e886b64-b63ede5005-64ef37b89dTo prevent from recurring similar problems, this commit introduces two changes: - The scope now always returns an Array whether min_id option is present or not. - The scope is renamed to to_a_paginated_by_id to clarify it returns an Array. * Transform Paginable.to_a_paginated_by_id from a scope to a class method https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope > The method is intended to return an ActiveRecord::Relation object, which > is composable with other scopes. Paginable.to_a_paginated_by_id returns an Array and is not appropriate as a scope.
70 lines
1.7 KiB
Ruby
70 lines
1.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Api::V1::ConversationsController < Api::BaseController
|
|
LIMIT = 20
|
|
|
|
before_action -> { doorkeeper_authorize! :read, :'read:statuses' }, only: :index
|
|
before_action -> { doorkeeper_authorize! :write, :'write:conversations' }, except: :index
|
|
before_action :require_user!
|
|
before_action :set_conversation, except: :index
|
|
after_action :insert_pagination_headers, only: :index
|
|
|
|
def index
|
|
@conversations = paginated_conversations
|
|
render json: @conversations, each_serializer: REST::ConversationSerializer
|
|
end
|
|
|
|
def read
|
|
@conversation.update!(unread: false)
|
|
render json: @conversation, serializer: REST::ConversationSerializer
|
|
end
|
|
|
|
def destroy
|
|
@conversation.destroy!
|
|
render_empty
|
|
end
|
|
|
|
private
|
|
|
|
def set_conversation
|
|
@conversation = AccountConversation.where(account: current_account).find(params[:id])
|
|
end
|
|
|
|
def paginated_conversations
|
|
AccountConversation.where(account: current_account)
|
|
.to_a_paginated_by_id(limit_param(LIMIT), params_slice(:max_id, :since_id, :min_id))
|
|
end
|
|
|
|
def insert_pagination_headers
|
|
set_pagination_headers(next_path, prev_path)
|
|
end
|
|
|
|
def next_path
|
|
if records_continue?
|
|
api_v1_conversations_url pagination_params(max_id: pagination_max_id)
|
|
end
|
|
end
|
|
|
|
def prev_path
|
|
unless @conversations.empty?
|
|
api_v1_conversations_url pagination_params(min_id: pagination_since_id)
|
|
end
|
|
end
|
|
|
|
def pagination_max_id
|
|
@conversations.last.last_status_id
|
|
end
|
|
|
|
def pagination_since_id
|
|
@conversations.first.last_status_id
|
|
end
|
|
|
|
def records_continue?
|
|
@conversations.size == limit_param(LIMIT)
|
|
end
|
|
|
|
def pagination_params(core_params)
|
|
params.slice(:limit).permit(:limit).merge(core_params)
|
|
end
|
|
end
|