1670 commits

Author	SHA1	Message	Date
Nick Schonning	1fe04f740a	Enable Rubocop Rails/FilePath (#23854)	2023-05-04 05:50:40 +02:00
Matt Jankowski	c97b611b6b	Fix RSpec/InferredSpecType cop (#24736)	2023-05-04 05:49:53 +02:00
Matt Jankowski	710745e16b	Fix RSpec/ContextWording cop (#24739)	2023-05-04 05:49:08 +02:00
Matt Jankowski	cf18cc2891	Fix RSpec/MultipleSubjects cop (#24738)	2023-05-04 05:48:35 +02:00
Matt Jankowski	bdcd8a9e88	Misc spec cleanup (#24822)	2023-05-04 05:47:52 +02:00
Matt Jankowski	08fb9d300a	Spec coverage for settings/preferences/* controllers (#24825)	2023-05-04 05:44:27 +02:00
Claire	a2a22bad23	Fix various edge cases with local moves (#24812)	2023-05-03 19:19:25 +02:00
Claire	1e75eb690d	Fix own posts not getting delivered to own lists (#24810)	2023-05-03 19:17:40 +02:00
Claire	c98b012583	Change Move handler to also move list memberships (#24808)	2023-05-03 14:03:38 +02:00
Matt Jankowski	3df665fd23	Fix Lint/ConstantDefinitionInBlock cop (#24763)	2023-05-03 10:32:30 +02:00
Claire	8b636a29c6	Improve automatic post cleanup worker performances (#24785)	2023-05-03 10:31:40 +02:00
Matt Jankowski	a0c9f2447e	Fix Performance/MethodObjectAsBlock cop (#24798)	2023-05-03 10:30:54 +02:00
Matt Jankowski	97385f27bd	Fix Performance/RedundantEqualityComparisonBlock cop (#24799)	2023-05-03 10:30:10 +02:00
Matt Jankowski	05e3abe9d9	Fix Lint/EmptyClass cop (#24795)	2023-05-02 21:06:51 +02:00
Matt Jankowski	a7df578f97	ApplicationHelper spec coverage, unused removal, tiny refactor (#24762)	2023-05-02 18:10:39 +02:00
Matt Jankowski	570079f8ce	Fix Performance/TimesMap cop (#24789)	2023-05-02 18:07:16 +02:00
Claire	9189e90ff2	Add fallback redirection when getting a webfinger query LOCAL_DOMAIN@LOCAL_DOMAIN (#23600) ... Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>	2023-05-02 17:42:42 +02:00
Claire	b233da5996	Optimize archive export service and export zip files instead of gzipped tar files (#23360)	2023-05-02 15:09:43 +02:00
Claire	6693a4fe7c	Change lists to be able to include accounts with pending follow requests (#19727)	2023-05-02 14:40:36 +02:00
Claire	1eb51bd749	Add request specs for caching behavior (#24592)	2023-05-02 13:58:29 +02:00
Claire	32a030dd74	Rewrite import feature (#21054)	2023-05-02 12:08:48 +02:00
Matt Jankowski	d00e45a7d3	Fix Rails/I18nLocaleAssignment cop (#24693)	2023-04-30 14:07:03 +02:00
Mark Roszko	c23d285b16	Remove the u in Favorite for non-gb english (#24667) ... Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	2023-04-30 16:33:37 +09:00
João Pedro Marques	8f6e290c7a	Adds new follower/following routes (#24601)	2023-04-30 09:01:42 +02:00
Matt Jankowski	bdc74086e6	Fix Rails/ContentTag cop (#24691)	2023-04-30 06:47:15 +02:00
Matt Jankowski	8dcfb6e0ea	Fix Rails/HttpPositionalArguments cop (#24699)	2023-04-30 06:43:28 +02:00
Matt Jankowski	274d561430	Enable local account key generation spec (#24728)	2023-04-30 02:28:52 +02:00
Matt Jankowski	4cfe52635c	Add pending spec for User.those_who_can (#24724)	2023-04-29 22:03:36 +02:00
Nick Schonning	5841f1af8c	Autofix Rubocop RSpec/MatchArray (#24675)	2023-04-26 21:29:36 +02:00
Nick Schonning	a3393d0d07	Autofix Rubocop RSpec/MatchArray (#24050)	2023-04-26 20:21:54 +02:00
Matt Jankowski	91a8cd21d8	React component helper specs (#24072)	2023-04-26 18:21:32 +02:00
Nick Schonning	90beba57d8	Autofix Rubocop Rails/ResponseParsedBody (#24051)	2023-04-26 17:25:07 +02:00
Claire	276c39361b	Fix anonymous visitors getting a session cookie on first visit (#24584)	2023-04-25 16:51:38 +02:00
Claire	f45961aa98	Add feature test for OAuth access grant (#24624)	2023-04-24 19:06:58 +02:00
Matt Jankowski	0a5f0a8b20	Remove instance variables from helper usage (#24203)	2023-04-23 22:35:54 +02:00
Claire	58a1b2e330	Fix caching logic with regards to Accept-Language, Cookie, and Signature (#24604)	2023-04-23 22:27:24 +02:00
Claire	5dc3173ef8	Fix AccountsStatusesCleanupScheduler not spreading deletes across accounts correctly (#24607)	2023-04-23 22:25:40 +02:00
Eugen Rochko	e98c86050a	Refactor Cache-Control and Vary definitions (#24347)	2023-04-19 16:07:29 +02:00
Robert R George	4db8230194	Add trend management to admin API (#24257)	2023-04-18 11:33:30 +02:00
Heitor de Melo Cardozo	bc75e62ca6	Change moderation search an account using the username with @ (#24242)	2023-04-17 14:16:36 +02:00
Heitor de Melo Cardozo	4601e0dcbb	Add user handle to notification mail recipient address (#24240) ... Co-authored-by: luccamps <luccamps@users.noreply.github.com> Co-authored-by: Leonardo Negreiros de Oliveira <negreirosleo12@gmail.com> Co-authored-by: Marcio Flavio <mflaviof1995@gmail.com> Co-authored-by: Gabriel Quaresma <j.quaresmasantos_98@hotmail.com>	2023-04-17 11:06:06 +02:00
Matt Jankowski	10f0de4212	Refactor race condition reblog service spec (#24526)	2023-04-14 14:42:10 +02:00
Claire	f53d009778	Refactor Status._insert_record slightly and tighten the test around reblogs of discarded statuses (#24516)	2023-04-12 12:47:05 +02:00
Matt Jankowski	36eeb70d53	Spec coverage on Settings/ controllers specs (#24221)	2023-04-11 11:35:39 +02:00
Matt Jankowski	a2a66300d9	Clean up the post deployment migration generator (#24233)	2023-04-11 11:25:29 +02:00
Matt Jankowski	9d39b111f1	Expand coverage for "system checks" (#24216)	2023-04-07 14:39:34 +02:00
Christian Schmidt	b4f38edf74	Wrong type for user setting when default is defined by lambda (#24321)	2023-03-31 07:33:17 +02:00
Eugen Rochko	a9b5598c97	Change user settings to be stored in a more optimal way (#23630) ... Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2023-03-30 14:44:00 +02:00
Christian Schmidt	eb38e9df31	Requeue expiration notification (#24311)	2023-03-29 10:52:40 +02:00
Eugen Rochko	9bda933740	Change media upload limits and remove client-side resizing (#23726)	2023-03-25 10:00:03 +01:00
Matt Jankowski	b179ff84c7	Add specs for Chewy importers (#24204)	2023-03-22 14:06:26 +01:00
Christian Schmidt	bd047acc35	Replace Status#translatable? with language matrix in separate endpoint (#24037)	2023-03-16 11:07:24 +01:00
Nick Schonning	a38f67c1c3	Autofix Rubocop Style/PreferredHashMethods (#23851)	2023-03-16 01:36:37 +01:00
Claire	a232a1feb8	Fix misleading error code when receiving invalid WebAuthn credentials (#23568)	2023-03-15 04:15:20 +01:00
Matt Jankowski	a471e1c48f	Add spec for the CLI version task (#23978)	2023-03-15 03:56:09 +01:00
Matt Jankowski	1ed12d5e2f	Add basic search specs for chewy indexes (#24065)	2023-03-10 19:31:10 +01:00
Matt Jankowski	688287c59d	Coverage improvement round-out following up previous work (#23987)	2023-03-10 13:33:30 +01:00
Matt Jankowski	56bddfbfa3	Serializers spec coverage (#24017)	2023-03-10 12:12:51 +01:00
Matt Jankowski	2f7a663b0b	Explicitly set github repo in instance presenter spec (#24036)	2023-03-09 14:27:48 +01:00
Christian Schmidt	684a970b3c	Unescape HTML entities (#24019)	2023-03-08 19:56:41 +01:00
Matt Jankowski	c599e289d8	Fix spec for api/v1/statuses/translations (#23956)	2023-03-04 23:17:46 +01:00
Matt Jankowski	2d1ccb3d8b	Restore missing fabricators (#23951)	2023-03-04 18:31:13 +01:00
Matt Jankowski	506b16cf59	Pending example models minimal coverage (#23912)	2023-03-04 17:16:45 +01:00
Matt Jankowski	7f4412eeeb	User mailer spec coverage improvements (#23905)	2023-03-04 17:16:11 +01:00
Matt Jankowski	42ddc45133	Admin controllers specs (#23917)	2023-03-04 17:13:28 +01:00
Matt Jankowski	ad585fb195	Specs api v1 controllers (#23930)	2023-03-04 17:12:54 +01:00
Matt Jankowski	cd99fa8ceb	Fabricator specs (#23925)	2023-03-04 17:12:09 +01:00
Matt Jankowski	c40d5e5a8f	Misc coverage improvements for validators (#23928)	2023-03-04 17:00:00 +01:00
Matt Jankowski	2f606ba122	Helpers specs coverage improvement (#23937)	2023-03-04 16:58:11 +01:00
Matt Jankowski	00eb2269b6	Policies specs (#23924)	2023-03-04 16:57:22 +01:00
Matt Jankowski	6a57c42316	Settings controllers specs (#23915)	2023-03-04 16:56:43 +01:00
Matt Jankowski	39e7525c96	Add basic coverage for some worker jobs (#23943)	2023-03-04 16:56:09 +01:00
Matt Jankowski	f9c2213ae5	Models specs coverage (#23940)	2023-03-04 16:43:47 +01:00
Christian Schmidt	5a8c651e8f	Only offer translation for supported languages (#23879)	2023-03-03 21:06:31 +01:00
Claire	3f52e717fa	Add tests for moderation actions without custom text (#23184)	2023-03-03 20:50:46 +01:00
Claire	c2a046ded1	Fix “Remove all followers from the selected domains” being more destructive than it claims (#23805)	2023-03-03 20:25:15 +01:00
Claire	3a6451c867	Add support for incoming rich text (#23913)	2023-03-03 20:19:29 +01:00
Matt Jankowski	af578e8ce0	Fix deprecation warning about merging conditions (#23618)	2023-03-02 16:21:04 +01:00
Matt Jankowski	9da52ac044	Update rspec-rails to version 6.0.1 (#23908)	2023-03-02 15:55:37 +01:00
Matt Jankowski	35dff48edf	Add spec coverage for Admin::Trends::StatusesHelper (#23898)	2023-03-02 15:30:40 +01:00
Stanislav Dobrovolschii	d9271126ce	Add rspecs for FollowRecommendationsScheduler (#23890)	2023-03-02 10:05:05 +01:00
Matt Jankowski	b6602f68eb	Spec coverage for HomeHelper (#23907)	2023-03-02 10:04:14 +01:00
Matt Jankowski	6185efbc3c	Admin mailer spec coverage improvement (#23863)	2023-02-28 22:33:34 +09:00
Matt Jankowski	9ee83a9f3b	Add policies and serializers groups to simplecov output (#23897)	2023-02-27 16:35:47 +01:00
Matt Jankowski	4bb39ac3c3	Fix single-record invalid condition on PollVote (#23810)	2023-02-27 09:31:15 +01:00
Nick Schonning	19614ba247	Rename ActivityPub Serializer Specs (#23844)	2023-02-23 23:17:48 +01:00
Claire	20b80c62ff	Change auto-deletion throttling constants to better scale with server size (#23320)	2023-02-23 16:52:40 +01:00
Nick Schonning	6bd7003799	Fix mispelled spec filenames (#23834)	2023-02-23 11:28:56 +01:00
Claire	3ed1b9ebb6	Fix rack:attack flaky tests and test end of throttle period (#23799)	2023-02-22 10:28:52 +01:00
Nick Schonning	8fd3fc404d	Autofix Rubocop Rails/RootPathnameMethods (#23760)	2023-02-22 09:57:15 +09:00
Nick Schonning	84cc805cae	Enable Style/FrozenStringLiteralComment for specs (#23790)	2023-02-22 09:55:31 +09:00
Nick Schonning	0cfdd1a401	Enable Rubocop Style/StringConcatenation defaults (#23792)	2023-02-22 09:54:36 +09:00
Nick Schonning	35d032500b	Autofix Rubocop Security/IoMethods (#23757)	2023-02-21 03:21:19 +09:00
Nick Schonning	2c3c734bcc	Autofix Rubocop Style/SymbolProc (#23742)	2023-02-20 07:58:46 +01:00
Nick Schonning	717683d1c3	Autofix Rubocop remaining Layout rules (#23679)	2023-02-20 06:58:28 +01:00
Nick Schonning	5116347eb7	Autofix Rubocop RSpec/BeEq (#23740)	2023-02-20 06:14:50 +01:00
Nick Schonning	bf785df9fe	Audofix Rubocop Style/WordArray (#23739)	2023-02-20 06:14:10 +01:00
Nick Schonning	4552685f6b	Autofix Rubocop RSpec/LeadingSubject (#23670)	2023-02-20 13:24:14 +09:00
Nick Schonning	4ea1e0fceb	Enable Rubocop RSpec/ExpectActual (#23720)	2023-02-20 05:00:59 +01:00
Nick Schonning	38a1d8bb85	Autofix Rubocop RSpec/ImplicitSubject (#23721)	2023-02-20 05:00:48 +01:00
Nick Schonning	5179c47087	Autofix Rubocops RSpec/ScatteredLet (#23725)	2023-02-20 11:17:41 +09:00
Nick Schonning	aef0051fd0	Enable Rubocop HTTP status rules (#23717)	2023-02-20 11:16:40 +09:00
Nick Schonning	bd1d57c230	Autofix Rubocop RSpec/EmptyLineAfterSubject (#23719)	2023-02-20 02:46:00 +01:00
Nick Schonning	dbc6d7b276	Autofix Rubocop Lint/UnusedBlockArgument (#23712)	2023-02-20 02:45:50 +01:00
Nick Schonning	65ba0d92ef	Enable Rubocop RSpec/NotToNot (#23723)	2023-02-20 02:33:27 +01:00
Nick Schonning	a2fdb388eb	Autofix Rubocop RSpec/ReturnFromStub (#23724)	2023-02-20 02:32:10 +01:00
Nick Schonning	21bf326356	Autofix Rubocop Rails/Pluck (#23730)	2023-02-20 02:28:40 +01:00
Nick Schonning	e0e63b73ee	Autofix Rubocop RSpec/EmptyLineAfterHook (#23718)	2023-02-19 14:54:34 +09:00
Nick Schonning	81ad6c2e39	Autofix Rubocop Style/StringLiterals (#23695)	2023-02-19 07:38:14 +09:00
Nick Schonning	ac3561098e	Autofix Rubocop RSpec/LetBeforeExamples (#23671)	2023-02-19 07:17:59 +09:00
Nick Schonning	1a02101100	Autofix Rubocop Style/EmptyLambdaParameter (#23705)	2023-02-19 07:12:06 +09:00
Nick Schonning	3680e032b4	Autofix Rubocop RSpec/EmptyLineAfterFinalLet (#23707)	2023-02-19 07:10:19 +09:00
Nick Schonning	167709f6b0	Autofix Rubocop Style/BlockDelimiters (#23706)	2023-02-19 07:00:17 +09:00
Nick Schonning	c0d7c855b3	Autofix Rubocop RSpec/Capybara/FeatureMethods (#23708)	2023-02-19 06:59:00 +09:00
Nick Schonning	08289a38fa	Autofix Rubocop Style/TrailingCommaInArrayLiteral (#23692)	2023-02-19 06:54:30 +09:00
Nick Schonning	5069769cbe	Autofix Rubocop Style/TrailingCommaInHashLiteral (#23693)	2023-02-18 23:33:41 +09:00
Nick Schonning	b4cbfff3eb	Autofix Rubocop RSpec/ExcessiveDocstringSpacing (#23666)	2023-02-18 12:47:37 +01:00
Nick Schonning	c38bd17657	Autofix Rubocop Style/TrailingCommaInArguments (#23694)	2023-02-18 12:39:58 +01:00
Nick Schonning	e2a3ebb271	Autofix Rubocop Style/IfUnlessModifier (#23697)	2023-02-18 12:37:47 +01:00
Nick Schonning	d65b2c1924	Apply Rubocop Style/RedundantConstantBase (#23463)	2023-02-18 04:30:03 +01:00
Nick Schonning	a7db0b41cd	Autofix Rubocop Lint/ParenthesesAsGroupedExpression (#23682)	2023-02-18 04:00:05 +01:00
Nick Schonning	e5cf23cf3a	Enable Rubocop RSpec/HooksBeforeExamples (#23668)	2023-02-18 03:59:57 +01:00
Nick Schonning	efd424506a	Autofix Rubocop Style/RedundantPercentQ (#23651)	2023-02-18 03:32:57 +01:00
Nick Schonning	c0a645f647	Autofix Rubocop RSpec/ExampleWording (#23667)	2023-02-18 03:26:20 +01:00
Nick Schonning	7a3d4c3d4b	Enable Rubocop RSpec/MultipleDescribes (#23672)	2023-02-18 03:25:47 +01:00
Nick Schonning	54318dcd6d	Autofix Rubocop RSpec/ClassCheck (#23685)	2023-02-18 03:24:16 +01:00
Nick Schonning	634368c491	Autofix Rubocop Lint/SymbolConversion (#23683)	2023-02-18 03:23:49 +01:00
Nick Schonning	6d42820e5d	Autofix Rubocop Lint/AmbiguousOperator (#23680)	2023-02-18 03:22:01 +01:00
Nick Schonning	ac59d6f19f	Enable Rubocop Style/NumericLiterals (#23647)	2023-02-18 11:05:57 +09:00
Nick Schonning	669f6d2c0a	Run rubocop formatting except line length (#23632)	2023-02-18 06:56:20 +09:00
Nick Schonning	6ed6c41724	Autofix Rubocop RSpec/EmptyLineAfterExample (#23661)	2023-02-17 21:46:00 +09:00
Nick Schonning	68b1071f86	Autofix Rubocop RSpec/BeNil (#23653)	2023-02-17 21:45:27 +09:00
Nick Schonning	936204b9ea	Autofix Rubocop Style/NestedParenthesizedCalls (#23646)	2023-02-17 21:43:10 +09:00
Nick Schonning	37914c8757	Autofix Rubocop Style/MethodCallWithoutArgsParentheses (#23645)	2023-02-17 21:36:14 +09:00
Claire	66f715550e	Add memorial attribute to REST API (#23591)	2023-02-14 13:50:55 +01:00
Claire	d6930b3847	Add API parameter to safeguard unexpect mentions in new posts (#18350)	2023-02-13 16:36:29 +01:00
Varun Sharma	45e2936c89	Add tests to indicate inclusion of self replies in statuses endpoint (#23266)	2023-02-13 16:04:26 +01:00
Claire	c55568c75a	Add tests for REST::AccountSerializer (#23319)	2023-02-13 13:23:59 +01:00
Claire	0c9eac80d8	Fix unbounded recursion in post discovery (#23506) ... * Add a limit to how many posts can get fetched as a result of a single request * Add tests * Always pass `request_id` when processing `Announce` activities --------- Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>	2023-02-10 22:16:37 +01:00
Nick Schonning	0592937264	Apply Rubocop Rails/WhereNot (#23448) ... * Apply Rubocop Rails/WhereNot * Update spec for where.not	2023-02-08 10:39:57 +01:00
Nick Schonning	1487fcde93	Apply Rubocop Style/ExpandPathArguments (#23450)	2023-02-08 07:06:20 +01:00
Nick Schonning	ed570050c6	Autofix Rails/EagerEvaluationLogMessage (#23429) ... * Autofix Rails/EagerEvaluationLogMessage * Update spec for debug block syntax	2023-02-07 03:44:36 +01:00
Claire	9edefc779f	Fix UserCleanupScheduler crash when an unconfirmed account has a moderation note (#23318) ... * Fix `UserCleanupScheduler` crash when an unconfirmed account has a moderation note * Add tests	2023-02-07 01:14:44 +01:00
Claire	20a479ff7c	Change POST /settings/applications/:id to regenerate token on scopes change (#23359) ... Fixes #23096	2023-02-02 12:03:49 +01:00
Claire	13a2abacc8	Add roles attribute to Account entities in REST API (#23255)	2023-01-25 19:55:40 +01:00
Claire	a5a00d7f7a	Fix email with empty domain name labels passing validation (#23246) ... * Fix email with empty domain name labels passing validation `EmailMxValidator` would allow empty labels because `Resolv::DNS` is particularly lenient about them, but the email would be invalid and unusable. * Add tests	2023-01-24 20:18:41 +01:00
Claire	6883fddb19	Fix account activation being triggered before email confirmation (#23245) ... * Add tests * Fix account activation being triggered before email confirmation Fixes #23098	2023-01-24 19:40:21 +01:00
Markus Unterwaditzer	f2a6e71bb6	Suppress AddressFamilyError in link verification (#23204) ... * Suppress AddressFamilyError * clarify comment	2023-01-23 13:05:54 +01:00
Claire	448be26b34	Add missing policy attribute to WebPushSubscriptionSerializer (#23210) ... * Add missing `policy` attribute to `WebPushSubscriptionSerializer` Fixes #23145 * Add tests	2023-01-23 13:05:30 +01:00
Claire	68dcbcb7bf	Add more specific error messages to HTTP signature verification (#21617) ... * Return specific error on failure to parse Date header * Add error message when preferredUsername is not set * Change error report to be JSON and include more details * Change error report to differentiate unknown account and failed refresh * Add tests	2023-01-18 16:47:56 +01:00