1
0
Fork 1
mirror of https://github.com/mastodon/mastodon.git synced 2024-12-30 12:20:35 +00:00
Commit graph

2219 commits

Author SHA1 Message Date
Matt Jankowski 64f9939e39
Use capture_emails helper to improve email assertions in specs () 2024-02-19 15:57:47 +00:00
Wolfgang Fournès 86627ea2e4
Add a missing thread example to the statuses spec () 2024-02-19 13:35:58 +00:00
Matt Jankowski 245064bb98
Move "everyone" role and "instance actor" account magic number IDs to constants () 2024-02-19 11:09:43 +00:00
Claire 96ddf1d482
Fix flaky end-to-end OCR test () 2024-02-16 16:57:23 +00:00
Matt Jankowski 1946e171e6
Reduce round trips in admin/disputes/appeals spec () 2024-02-16 13:46:28 +00:00
Matt Jankowski 3454fcbd71
Reduce round trips in auth/sessions spec () 2024-02-16 13:38:49 +00:00
Matt Jankowski a316c0e38d
Reduce round trips in disputes/appeals spec () 2024-02-16 13:01:15 +00:00
Matt Jankowski 117b507df5
Extract subject from User#mark_email_as_confirmed! spec () 2024-02-16 13:01:04 +00:00
Matt Jankowski 1690fb39e6
Reduce RSpec/MultipleExpectations in instance_actors_controller spec () 2024-02-16 13:00:11 +00:00
Matt Jankowski bba488c189
Reduce RSpec/MultipleExpectations in media_attachment spec () 2024-02-16 13:00:09 +00:00
Claire 9fee5e8526
Merge pull request from GHSA-jhrq-qvrm-qr36
* Fix insufficient Content-Type checking of fetched ActivityStreams objects

* Allow JSON-LD documents with multiple profiles
2024-02-16 11:56:12 +01:00
Matt Jankowski a9f9b0097b
Reduce RSpec/MultipleExpectations in captcha feature spec () 2024-02-16 07:52:57 +00:00
Matt Jankowski 4b7f04e3ea
Reduce RSpec/MultipleExpectations in post_status_service spec () 2024-02-16 07:52:29 +00:00
Matt Jankowski ed4939296a
Reduce RSpec/MultipleExpectations in ap/activity/create spec () 2024-02-16 07:43:00 +00:00
Matt Jankowski 1df2ffc3ee
Use subject in blacklist email validator spec () 2024-02-16 07:42:03 +00:00
Matt Jankowski fc4f823464
Avoid local block var assignment in ap/process_status_update_service spec () 2024-02-16 07:41:25 +00:00
Claire d4d0565b0f
Fix user creation failure handling in OAuth paths () 2024-02-14 21:49:45 +00:00
Claire bbbbf00084
Fix OmniAuth tests () 2024-02-14 14:57:49 +00:00
Claire b31af34c97
Merge pull request from GHSA-vm39-j3vx-pch3
* Prevent different identities from a same SSO provider from accessing a same account

* Lock auth provider changes behind `ALLOW_UNSAFE_AUTH_PROVIDER_REATTACH=true`

* Rename methods to avoid confusion between OAuth and OmniAuth
2024-02-14 15:16:07 +01:00
Emelia Smith 68eaa804c9
Merge pull request from GHSA-7w3c-p9j8-mq3x
* Ensure destruction of OAuth Applications notifies streaming

Due to doorkeeper using a dependent: delete_all relationship, the destroy of an OAuth Application bypassed the existing AccessTokenExtension callbacks for announcing destructing of access tokens.

* Ensure password resets revoke access to Streaming API

* Improve performance of deleting OAuth tokens

---------

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-02-14 15:15:34 +01:00
Emelia Smith 46142cdbdd
Disable administrative doorkeeper routes () 2024-02-13 18:11:47 +00:00
Claire ca8fbda5d0
Add end-to-end test for OCR in media uploads () 2024-02-08 19:13:44 +00:00
Matt Jankowski a9e91eb955
Add common stub setup for resolv dns in email mx validator spec () 2024-02-08 14:26:45 +00:00
Matt Jankowski 15437e4ad9
Add context and before to lengthy tag manager spec examples () 2024-02-08 10:03:04 +00:00
Matt Jankowski 5271131658
Extract helper method for repeated form fill in admin/domain_blocks feature spec () 2024-02-08 10:02:53 +00:00
Claire eff447a455
Rewrite signature verification using regexps and StringScanner () 2024-02-07 17:24:42 +00:00
Matt Jankowski 95da28d201
Add common ThreadingHelper module for specs () 2024-02-07 14:53:29 +00:00
Claire 7efc33b909
Move HTTP Signature parsing code to its own class () 2024-02-07 13:35:37 +00:00
Matt Jankowski da50217b88
Combine repeated requests in admin/accounts controller spec () 2024-02-07 10:59:32 +00:00
Claire 7ee93b7431
Change source attribute of Suggestion entity in /api/v2/suggestions back to a string () 2024-02-06 17:10:17 +00:00
Matt Jankowski 0df86d77fd
Reduce RSpec/ExampleLength in PostStatusService spec example () 2024-02-06 14:36:04 +00:00
Matt Jankowski 2d6ab44556
Reduce request/response round-trips in ap/collections controller spec () 2024-02-06 13:10:00 +00:00
Matt Jankowski 978fdc71ca
Reduce expectation count in example from ProcessAccountService spec () 2024-02-06 13:04:02 +00:00
Matt Jankowski 577520b637
Replace deprecated Sidekiq::Testing block style () 2024-02-06 12:49:48 +00:00
Matt Jankowski df7acdcee5
Update markers API spec for error case () 2024-02-06 12:47:04 +00:00
Emelia Smith 4fb7f611de
Return domain block digests from admin domain blocks API () 2024-02-06 12:38:14 +00:00
Matt Jankowski 4cf07ed78c
Add missing action logging to api/v1/admin/reports#update () 2024-02-06 11:34:11 +00:00
Claire 66dda7c762
Fix already-invalid reports failing to resolve () 2024-02-06 09:35:27 +00:00
Claire 1726085db5
Merge pull request from GHSA-3fjr-858r-92rw
* Fix insufficient origin validation

* Bump version to 4.3.0-alpha.1
2024-02-01 15:56:46 +01:00
Matt Jankowski 8b7b0ee598
Configure selenium to use Chrome version 120 () 2024-02-01 09:46:31 +00:00
Matt Jankowski 86fbde7b46
Fix Style/NumericLiterals cop in ProfileStories support module () 2024-01-30 15:38:33 +00:00
Matt Jankowski f91acba70a
Combine repeated requests in account controller concern spec () 2024-01-30 15:32:20 +00:00
Matt Jankowski ff8937aa2c
Move api/v1/statuses/* to request spec () 2024-01-26 17:45:54 +00:00
Matt Jankowski 44f6d285af
Combine repeated subject in ap fetch remote actor service spec () 2024-01-26 17:44:12 +00:00
Matt Jankowski 239244e2ed
Combine repeated subject in ap fetch remote account service spec () 2024-01-26 17:43:08 +00:00
Matt Jankowski 5119fbc9b7
Move api/v1/admin/trends/links/preview_card_providers to request spec () 2024-01-26 17:41:39 +00:00
Matt Jankowski b6baab447d
Move api/v2/admin/accounts to request spec () 2024-01-26 17:41:13 +00:00
Matt Jankowski 7adcc0aae3
Move api/v1/trends/* to request specs () 2024-01-26 17:40:39 +00:00
Matt Jankowski 0b0ca6f3b8
Move api/v1/timelines/list to request spec () 2024-01-26 17:40:15 +00:00
Matt Jankowski e519f113e8
Combine repeated subject in cacheable response shared example () 2024-01-26 16:37:05 +00:00
Matt Jankowski d791bca11b
Combine double subject in well_known/webfinger shared example () 2024-01-26 16:36:21 +00:00
Matt Jankowski 09a3493fca
Combine double subject in api/v1/media shared example () 2024-01-26 16:35:49 +00:00
Matt Jankowski 5fbdb2055b
Combine repeated subject in cli/accounts spec shared example () 2024-01-26 16:35:19 +00:00
Matt Jankowski 1a30a517d6
Combine repeated subjects in link details extractor spec () 2024-01-26 16:31:07 +00:00
Matt Jankowski 685eaa04d4
Combine double subject in admin/statuses controller shared example () 2024-01-26 16:30:30 +00:00
Matt Jankowski beb74fd71c
Combine double subjects in instance actors controller shared example () 2024-01-26 16:28:50 +00:00
Matt Jankowski beaef4b672
Combine double subjects in application controller shared example () 2024-01-26 16:23:12 +00:00
Matt Jankowski 6d35a77c92
Combine repeated subjects in models/user spec () 2024-01-26 16:22:44 +00:00
Matt Jankowski 2f8656334d
Combine double subjects in admin/accounts controller spec () 2024-01-26 16:21:31 +00:00
Matt Jankowski 9cc1817bb4
Fix intmermittent failure in api/v1/accounts/statuses controller spec () 2024-01-26 14:10:26 +00:00
Matt Jankowski 0e0a94f483
Handle CLI failure exit status at the top-level script () 2024-01-26 08:53:44 +00:00
Eugen Rochko 6936e5aa69
Change design of compose form in web UI ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-25 15:41:31 +00:00
Matt Jankowski 42ab855b23
Add specs for Instance model scopes and add with_domain_follows scope () 2024-01-25 15:28:27 +00:00
Matt Jankowski 2866106ec1
Reduce factory creation in spec/models/account_statuses_cleanup_policy () 2024-01-25 13:37:25 +00:00
Matt Jankowski 6b6586f5d0
Add CustomFilterKeyword#to_regex method () 2024-01-25 13:00:34 +00:00
Matt Jankowski 7c9c6c7f80
Fix remaining Rails/WhereExists cop violations, regenerate todo () 2024-01-25 12:37:07 +00:00
Claire 087415d0fe
Add tests for processing statuses using bearcap URIs () 2024-01-25 11:13:36 +00:00
Claire 0471a78055
Add tests for redirect confirmations () 2024-01-25 11:13:33 +00:00
Matt Jankowski a11a2fb052
Add error classes to api/base errors coverage () 2024-01-24 10:31:31 +00:00
Matt Jankowski b0207d7757
Add coverage for Tag.recently_used scope () 2024-01-23 09:10:11 +00:00
Claire e2d9635074
Add notification email on invalid second authenticator () 2024-01-22 13:55:43 +00:00
Matt Jankowski 18004bf227
Add Account.matches_uri_prefix scope and use in activitypub/followers_synchronizations controller () 2024-01-22 13:55:37 +00:00
Matt Jankowski 7ecf7f5403
Move controller->request specs for api/v1/statuses/* () 2024-01-22 11:58:54 +00:00
Claire cf2a2ed71c
Fix processing of compacted single-item JSON-LD collections () 2024-01-19 12:43:10 +00:00
Claire 3593ee2e36
Add rate-limit of TOTP authentication attempts at controller level () 2024-01-19 12:19:49 +00:00
Matt Jankowski 329911b0a3
Migrate controller->request spec for api/v1/follow* () 2024-01-19 09:32:41 +00:00
Matt Jankowski 1480573c83
Add Account.auditable scope, fix N+1 in admin/action_logs#index () 2024-01-19 01:39:30 +00:00
Matt Jankowski d0b3bc23d7
Remove unused matches_domain scopes on Account, DomainAllow, DomainBlock () 2024-01-18 16:11:04 +00:00
Matt Jankowski 0b853678a4
Add coverage for api/v1/peers/search endpoint and extract controller query to Instance scope () 2024-01-18 15:57:10 +00:00
Matt Jankowski 3d82040b26
Reduced repeated setup in UnallowDomainService spec () 2024-01-18 10:11:10 +00:00
Matt Jankowski 6c5a2d51bc
Reduced repeated setup in PurgeDomainService spec () 2024-01-18 10:07:49 +00:00
Matt Jankowski 07e10e3747
Combine assertions about same setup in Account#suspend! spec () 2024-01-18 09:36:59 +00:00
Matt Jankowski 9a475ea8b3
Finish up the CLI spec area pattern adoption for CLI::Accounts#refresh specs () 2024-01-17 13:38:37 +00:00
Matt Jankowski 1b0cb3b54d
Announcement reactions query spec improvement and refactor () 2024-01-17 09:18:13 +00:00
Matt Jankowski b4c332104a
Use top-level warn in JS errors check () 2024-01-15 21:26:11 +00:00
Claire 98b5f85f10
Rename and refactor User#confirm! to User#mark_email_as_confirmed! () 2024-01-15 18:04:58 +00:00
Claire e621c1c44c
Fix registrations not checking MX records for email domain blocks requiring approval () 2024-01-15 17:10:57 +00:00
Matt Jankowski a2f02a0775
Disable Rails/SkipsModelValidations cop () 2024-01-15 13:46:47 +00:00
Matt Jankowski e72676e83a
Improve api/v1/markers#create performance against simultaneous requests () 2024-01-15 09:47:25 +00:00
MitarashiDango 2c05b8a60d
Fix Undo Announce activity is not sent, when not followed by the reblogged post author ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-12 15:58:28 +00:00
Matt Jankowski a90696011e
Add coverage/bugfix for invalid appeal submission () 2024-01-12 09:21:00 +00:00
Matt Jankowski 7801db7ba4
Spec coverage for custom css endpoint () 2024-01-12 09:19:25 +00:00
Matt Jankowski df9e220364
Add JS console errors check () 2024-01-12 09:12:31 +00:00
Matt Jankowski cd37048439
Move followable_by coverage to suggestions () 2024-01-12 09:11:34 +00:00
Matt Jankowski 32eeca9c7b
Refresh instance counts in spec (fixes intermittent failure) () 2024-01-12 09:10:37 +00:00
Matt Jankowski 8b26614fa7
Combine results include check in spec/models/account () 2024-01-11 16:17:45 +00:00
Matt Jankowski 185c806d69
Extract spec helper for verifing to/from public AP collection namespace () 2024-01-11 16:17:21 +00:00
Matt Jankowski 2954279e9c
Remove double subject call in api/v1/admin/trends/links/links spec () 2024-01-11 15:13:11 +00:00
Matt Jankowski 95bd46d32a
Remove double subject call in api/v1/admin/ip_blocks spec () 2024-01-11 15:11:57 +00:00
Matt Jankowski 4e08a4892f
Move streaming around config into manager class () 2024-01-11 10:54:42 +00:00
Matt Jankowski 87097a227c
Clean up settings/featured_tags/index view () 2024-01-11 10:45:26 +00:00
Matt Jankowski 55802242ce
Refactor login activity partial (remove inline ruby) () 2024-01-11 10:36:27 +00:00
Matt Jankowski 0a7cff53c2
Add coverage for Account.followable_by scope () 2024-01-11 09:30:29 +00:00
Claire d7e13e2483
Fix potential redirection loop of streaming endpoint () 2024-01-10 15:05:46 +00:00
Matt Jankowski 8422b8ded0
Extract capybara config and improve headless_chrome driver config () 2024-01-10 14:54:11 +00:00
Matt Jankowski 543d7890fd
Use normalizes to prepare User values ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-10 13:36:06 +00:00
Matt Jankowski 00341c70ff
Use Sidekiq fake! instead of inline! in specs () 2024-01-10 11:06:58 +00:00
Matt Jankowski 742d8d30e2
Add coverage for --days option to CLI media refresh command () 2024-01-10 09:36:12 +00:00
Renaud Chaput 63d0b52cf3
Add a system spec for the /share endpoint () 2024-01-09 21:58:19 +00:00
Claire 10203bd57a
Clean up Setting model and remove dead code () 2024-01-09 14:01:53 +00:00
Jean Boussier 1781849884
Inline what remains of the rails-settings-cached gem ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-09 11:50:21 +00:00
Matt Jankowski 5dc634796a
Misc coverage improvements re: sidekiq/inline () 2024-01-09 09:40:08 +00:00
Matt Jankowski e677eb164c
Remove unused Announcement#time_range? () 2024-01-08 15:26:30 +00:00
Matt Jankowski 3e43cd095c
Remove unused scope Announcement.without_muted () 2024-01-08 15:26:14 +00:00
Claire 157fc69954
Make request_pool_spec tests more robust () 2024-01-08 12:29:05 +00:00
Matt Jankowski aa6d07dbd9
Use normalizes to prepare CustomEmoji domain value () 2024-01-08 11:20:59 +00:00
Matt Jankowski 832b92ac3e
Add attachment check to spec/service/suspend_account_service spec () 2024-01-08 11:05:10 +00:00
Matt Jankowski 12bed81187
Add validation specs to CustomFilter model () 2024-01-05 15:13:59 +00:00
Claire 6ad0fb5a77
Fix NULL MX handling and tighten DNS resolving specs () 2024-01-05 11:07:57 +00:00
Claire 5f4643b895
Add PAPERCLIP_ROOT_URL to Content-Security-Policy when used () 2024-01-05 10:45:36 +00:00
Matt Jankowski 964a0ecf37
Add sleep statement to nudge thread scheduler in request pool spec () 2024-01-04 16:55:00 +00:00
Matt Jankowski f06c1f1552
Fix Capybara/ClickLinkOrButtonStyle cop in spec/features () 2024-01-04 09:20:32 +00:00
Claire dfdadb92e8
Add ability to require approval when users sign up using specific email domains () 2024-01-04 09:07:05 +00:00
Matt Jankowski f92d8c654d
Standardize on Thor methods in CLI classes () 2024-01-03 15:08:08 +00:00
Matt Jankowski 5c769de096
Add spec coverage for CLI::Media#remove_orphans command () 2024-01-03 14:12:56 +00:00
Matt Jankowski 74a0d81e90
Add coverage for CLI self-destruct command ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-01-03 13:06:38 +00:00
Claire 092bb8a27a
Fix Mastodon not correctly processing HTTP Signatures with query strings () 2024-01-03 11:29:26 +00:00
Claire bd415af9a1
Change streaming API host to not be overridden to localhost in development mode () 2024-01-03 10:23:58 +00:00
Claire a2624ff739
Convert signature verification specs to request specs () 2023-12-22 18:56:22 +00:00
Matt Jankowski bb8077e784
Fix RSpec/LetSetup cop in models/account_status_cleanup_policy () 2023-12-22 15:29:50 +00:00
Claire 2bf84b93d4
Fix media attachment order of remote posts () 2023-12-22 15:10:39 +00:00
Matt Jankowski a4d49c236d
Fix RSpec/LetSetup cop in ap/fetch_featured_collection_service () 2023-12-22 12:57:29 +00:00
Matt Jankowski e6e217fedd
Clean up tagged_with_* Status specs, fix RSpec/LetSetup cop () 2023-12-22 08:32:27 +00:00
Matt Jankowski 513d35969e
Fix RSpec/LetSetup cop in auth controller specs () 2023-12-22 08:03:59 +00:00
Matt Jankowski 9251779d75
Fix RSpec/LetSetup cop in spec/services () 2023-12-21 14:23:53 +00:00
Matt Jankowski efd16f3c2c
Clean up of RSpec/LetSetup within spec/services/activitypub () 2023-12-21 11:20:12 +00:00
Matt Jankowski c99f88e1a8
Clean up of RSpec/LetSetup within spec/lib () 2023-12-21 11:19:56 +00:00
Matt Jankowski cd64a5b2ec
Clean up of RSpec/LetSetup within api/ () 2023-12-21 10:10:18 +00:00
Matt Jankowski f32d672d2f
Clean up of RSpec/LetSetup within spec/controllers () 2023-12-21 09:28:41 +00:00
Matt Jankowski c753b1ad35
Clean up of RSpec/LetSetup within spec/models () 2023-12-21 09:18:38 +00:00
Matt Jankowski 2463b53363
More duplicates in cli maintenance spec, misc bug fixes () 2023-12-21 08:51:03 +00:00
Matt Jankowski 961d65aba6
Add coverage to CLI Maintenance for duplicate users on confirmation_token and reset_password_token values () 2023-12-20 08:54:04 +00:00
Claire 6fed0fcbaa
Remove unneeded settings cleanup from specs () 2023-12-19 15:17:22 +00:00
Matt Jankowski c7c727994a
Add spec for CLI::Maintenance#fix_duplicates () 2023-12-19 13:10:33 +00:00
Eugen Rochko b5ac61b2c5
Change algorithm of follow recommendations ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-12-19 10:59:43 +00:00
Matt Jankowski c28976d89e
Handle negative offset param in api/v2/search () 2023-12-19 10:55:39 +00:00
Matt Jankowski 476d1237d4
Typo fix in json ld helper spec () 2023-12-18 16:47:22 +00:00
Claire 7d9b209fe8
Fix call to inefficient delete_matched cache method in domain blocks () 2023-12-18 16:14:43 +00:00
Matt Jankowski af366f65ee
Add spec coverage for models/form/custom_emoji_batch class () 2023-12-18 12:41:37 +00:00
Matt Jankowski 1820bad646
Fix Performance/StringIdentifierArgument cop () 2023-12-18 10:26:09 +00:00