Simplify model validation specs for User

This commit is contained in:
Matt Jankowski 2024-09-05 13:46:12 -04:00
parent a1ac2a73ff
commit f930788b6c

View file

@ -33,14 +33,12 @@ RSpec.describe User do
end end
end end
describe 'validations' do describe 'Associations' do
it { is_expected.to belong_to(:account).required } it { is_expected.to belong_to(:account).required }
end
it 'is invalid without a valid email' do describe 'Validations' do
user = Fabricate.build(:user, email: 'john@') it { is_expected.to_not allow_value('john@').for(:email) }
user.valid?
expect(user).to model_have_error_on_field(:email)
end
it 'is valid with an invalid e-mail that has already been saved' do it 'is valid with an invalid e-mail that has already been saved' do
user = Fabricate.build(:user, email: 'invalid-email') user = Fabricate.build(:user, email: 'invalid-email')
@ -48,11 +46,7 @@ RSpec.describe User do
expect(user.valid?).to be true expect(user.valid?).to be true
end end
it 'is valid with a localhost e-mail address' do it { is_expected.to allow_value('admin@localhost').for(:email) }
user = Fabricate.build(:user, email: 'admin@localhost')
user.valid?
expect(user.valid?).to be true
end
end end
describe 'Normalizations' do describe 'Normalizations' do