diff --git a/.env.production.sample b/.env.production.sample
index ca2e29a07e..54d62d672f 100644
--- a/.env.production.sample
+++ b/.env.production.sample
@@ -9,6 +9,10 @@ DB_USER=postgres
DB_NAME=postgres
DB_PASS=
DB_PORT=5432
+# Optional ElasticSearch configuration
+# ES_ENABLED=true
+# ES_HOST=localhost
+# ES_PORT=9200
# Federation
# Note: Changing LOCAL_DOMAIN at a later time will cause unwanted side effects, including breaking all existing federation.
diff --git a/Gemfile b/Gemfile
index d2cd3b42db..65608b51ef 100644
--- a/Gemfile
+++ b/Gemfile
@@ -28,6 +28,7 @@ gem 'bootsnap'
gem 'browser'
gem 'charlock_holmes', '~> 0.7.5'
gem 'iso-639'
+gem 'chewy', '~> 0.10', git: 'https://github.com/toptal/chewy.git'
gem 'cld3', '~> 3.2.0'
gem 'devise', '~> 4.4'
gem 'devise-two-factor', '~> 3.0'
diff --git a/Gemfile.lock b/Gemfile.lock
index 3400b1a0fd..509b65ab64 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,3 +1,12 @@
+GIT
+ remote: https://github.com/toptal/chewy.git
+ revision: a7d21eb4b0bd7415533ef134bb6d31b2df309701
+ specs:
+ chewy (0.10.1)
+ activesupport (>= 4.0)
+ elasticsearch (>= 2.0.0)
+ elasticsearch-dsl
+
GEM
remote: https://rubygems.org/
specs:
@@ -154,6 +163,15 @@ GEM
json
thread
thread_safe
+ elasticsearch (6.0.1)
+ elasticsearch-api (= 6.0.1)
+ elasticsearch-transport (= 6.0.1)
+ elasticsearch-api (6.0.1)
+ multi_json
+ elasticsearch-dsl (0.1.5)
+ elasticsearch-transport (6.0.1)
+ faraday
+ multi_json
encryptor (3.0.0)
erubi (1.7.0)
et-orbi (1.0.8)
@@ -163,6 +181,8 @@ GEM
fabrication (2.18.0)
faker (1.8.4)
i18n (~> 0.5)
+ faraday (0.14.0)
+ multipart-post (>= 1.2, < 3)
fast_blank (1.0.0)
ffi (1.9.18)
fog-core (1.45.0)
@@ -293,6 +313,7 @@ GEM
minitest (5.11.3)
msgpack (1.1.0)
multi_json (1.12.2)
+ multipart-post (2.0.0)
net-scp (1.2.1)
net-ssh (>= 2.6.5)
net-ssh (4.2.0)
@@ -586,6 +607,7 @@ DEPENDENCIES
capistrano-yarn (~> 2.0)
capybara (~> 2.15)
charlock_holmes (~> 0.7.5)
+ chewy (~> 0.10)!
cld3 (~> 3.2.0)
climate_control (~> 0.2)
devise (~> 4.4)
diff --git a/app/chewy/statuses_index.rb b/app/chewy/statuses_index.rb
new file mode 100644
index 0000000000..8bf5b4af7c
--- /dev/null
+++ b/app/chewy/statuses_index.rb
@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+class StatusesIndex < Chewy::Index
+ settings index: { refresh_interval: '15m' }, analysis: {
+ filter: {
+ english_stop: {
+ type: 'stop',
+ stopwords: '_english_',
+ },
+ english_stemmer: {
+ type: 'stemmer',
+ language: 'english',
+ },
+ english_possessive_stemmer: {
+ type: 'stemmer',
+ language: 'possessive_english',
+ },
+ },
+ analyzer: {
+ content: {
+ tokenizer: 'uax_url_email',
+ filter: %w(
+ english_possessive_stemmer
+ lowercase
+ asciifolding
+ cjk_width
+ english_stop
+ english_stemmer
+ ),
+ },
+ },
+ }
+
+ define_type ::Status.without_reblogs do
+ crutch :mentions do |collection|
+ data = ::Mention.where(status_id: collection.map(&:id)).pluck(:status_id, :account_id)
+ data.each.with_object({}) { |(id, name), result| (result[id] ||= []).push(name) }
+ end
+
+ crutch :favourites do |collection|
+ data = ::Favourite.where(status_id: collection.map(&:id)).pluck(:status_id, :account_id)
+ data.each.with_object({}) { |(id, name), result| (result[id] ||= []).push(name) }
+ end
+
+ crutch :reblogs do |collection|
+ data = ::Status.where(reblog_of_id: collection.map(&:id)).pluck(:reblog_of_id, :account_id)
+ data.each.with_object({}) { |(id, name), result| (result[id] ||= []).push(name) }
+ end
+
+ root date_detection: false do
+ field :account_id, type: 'long'
+
+ field :text, type: 'text', value: ->(status) { [status.spoiler_text, Formatter.instance.plaintext(status)].join("\n\n") } do
+ field :stemmed, type: 'text', analyzer: 'content'
+ end
+
+ field :searchable_by, type: 'long', value: ->(status, crutches) { status.searchable_by(crutches) }
+ field :created_at, type: 'date'
+ end
+ end
+end
diff --git a/app/javascript/mastodon/features/compose/components/search_results.js b/app/javascript/mastodon/features/compose/components/search_results.js
index d16f7fce76..84455563c4 100644
--- a/app/javascript/mastodon/features/compose/components/search_results.js
+++ b/app/javascript/mastodon/features/compose/components/search_results.js
@@ -22,6 +22,8 @@ export default class SearchResults extends ImmutablePureComponent {
count += results.get('accounts').size;
accounts = (
+
+
{results.get('accounts').map(accountId =>
)}
);
@@ -31,6 +33,8 @@ export default class SearchResults extends ImmutablePureComponent {
count += results.get('statuses').size;
statuses = (
+
+
{results.get('statuses').map(statusId => )}
);
@@ -40,6 +44,8 @@ export default class SearchResults extends ImmutablePureComponent {
count += results.get('hashtags').size;
hashtags = (
+
+
{results.get('hashtags').map(hashtag => (
#{hashtag}
diff --git a/app/javascript/styles/mastodon/components.scss b/app/javascript/styles/mastodon/components.scss
index 91f9739d7a..b6244e3f96 100644
--- a/app/javascript/styles/mastodon/components.scss
+++ b/app/javascript/styles/mastodon/components.scss
@@ -1786,7 +1786,7 @@
flex: 1;
min-height: 47px;
- > img {
+ > img {
display: block;
object-fit: contain;
object-position: bottom left;
@@ -3229,6 +3229,43 @@
font-weight: 500;
}
+.search-results__section {
+ margin-bottom: 20px;
+
+ h5 {
+ position: relative;
+
+ &::before {
+ content: "";
+ display: block;
+ position: absolute;
+ left: 0;
+ right: 0;
+ top: 50%;
+ width: 100%;
+ height: 0;
+ border-top: 1px solid lighten($ui-base-color, 8%);
+ }
+
+ span {
+ display: inline-block;
+ background: $ui-base-color;
+ color: $ui-primary-color;
+ font-size: 14px;
+ font-weight: 500;
+ padding: 10px;
+ position: relative;
+ z-index: 1;
+ cursor: default;
+ }
+ }
+
+ .account:last-child,
+ & > div:last-child .status {
+ border-bottom: 0;
+ }
+}
+
.search-results__hashtag {
display: block;
padding: 10px;
diff --git a/app/lib/status_filter.rb b/app/lib/status_filter.rb
index a6a050ce1d..41d4381e56 100644
--- a/app/lib/status_filter.rb
+++ b/app/lib/status_filter.rb
@@ -9,6 +9,7 @@ class StatusFilter
end
def filtered?
+ return false if !account.nil? && account.id == status.account_id
blocked_by_policy? || (account_present? && filtered_status?) || silenced_account?
end
diff --git a/app/models/favourite.rb b/app/models/favourite.rb
index 2b1271f31d..fa1884b866 100644
--- a/app/models/favourite.rb
+++ b/app/models/favourite.rb
@@ -13,6 +13,8 @@
class Favourite < ApplicationRecord
include Paginable
+ update_index('statuses#status', :status) if Chewy.enabled?
+
belongs_to :account, inverse_of: :favourites
belongs_to :status, inverse_of: :favourites, counter_cache: true
diff --git a/app/models/status.rb b/app/models/status.rb
index e927fb9ddc..6fb9b15dde 100644
--- a/app/models/status.rb
+++ b/app/models/status.rb
@@ -32,6 +32,8 @@ class Status < ApplicationRecord
include Cacheable
include StatusThreadingConcern
+ update_index('statuses#status', :proper) if Chewy.enabled?
+
enum visibility: [:public, :unlisted, :private, :direct], _suffix: :visibility
belongs_to :application, class_name: 'Doorkeeper::Application', optional: true
@@ -81,6 +83,22 @@ class Status < ApplicationRecord
delegate :domain, to: :account, prefix: true
+ def searchable_by(preloaded = nil)
+ ids = [account_id]
+
+ if preloaded.nil?
+ ids += mentions.pluck(:account_id)
+ ids += favourites.pluck(:account_id)
+ ids += reblogs.pluck(:account_id)
+ else
+ ids += preloaded.mentions[id] || []
+ ids += preloaded.favourites[id] || []
+ ids += preloaded.reblogs[id] || []
+ end
+
+ ids.uniq
+ end
+
def reply?
!in_reply_to_id.nil? || attributes['reply']
end
diff --git a/app/services/search_service.rb b/app/services/search_service.rb
index 5f763b8f77..fe98566866 100644
--- a/app/services/search_service.rb
+++ b/app/services/search_service.rb
@@ -1,21 +1,43 @@
# frozen_string_literal: true
class SearchService < BaseService
- attr_accessor :query
+ attr_accessor :query, :account, :limit, :resolve
def call(query, limit, resolve = false, account = nil)
- @query = query
+ @query = query
+ @account = account
+ @limit = limit
+ @resolve = resolve
default_results.tap do |results|
if url_query?
results.merge!(url_resource_results) unless url_resource.nil?
elsif query.present?
- results[:accounts] = AccountSearchService.new.call(query, limit, account, resolve: resolve)
- results[:hashtags] = Tag.search_for(query.gsub(/\A#/, ''), limit) unless query.start_with?('@')
+ results[:accounts] = perform_accounts_search! if account_searchable?
+ results[:statuses] = perform_statuses_search! if full_text_searchable?
+ results[:hashtags] = perform_hashtags_search! if hashtag_searchable?
end
end
end
+ private
+
+ def perform_accounts_search!
+ AccountSearchService.new.call(query, limit, account, resolve: resolve)
+ end
+
+ def perform_statuses_search!
+ statuses = StatusesIndex.filter(term: { searchable_by: account.id })
+ .query(multi_match: { type: 'most_fields', query: query, operator: 'and', fields: %w(text text.stemmed) })
+ .limit(limit).objects
+
+ statuses.reject { |status| StatusFilter.new(status, account).filtered? }
+ end
+
+ def perform_hashtags_search!
+ Tag.search_for(query.gsub(/\A#/, ''), limit)
+ end
+
def default_results
{ accounts: [], hashtags: [], statuses: [] }
end
@@ -35,4 +57,17 @@ class SearchService < BaseService
def url_resource_symbol
url_resource.class.name.downcase.pluralize.to_sym
end
+
+ def full_text_searchable?
+ return false unless Chewy.enabled?
+ !account.nil? && !((query.start_with?('#') || query.include?('@')) && !query.include?(' '))
+ end
+
+ def account_searchable?
+ !(query.include?('@') && query.include?(' '))
+ end
+
+ def hashtag_searchable?
+ !query.include?('@')
+ end
end
diff --git a/app/views/auth/passwords/edit.html.haml b/app/views/auth/passwords/edit.html.haml
index d8fed9e776..703c821c07 100644
--- a/app/views/auth/passwords/edit.html.haml
+++ b/app/views/auth/passwords/edit.html.haml
@@ -1,18 +1,18 @@
- content_for :page_title do
= t('auth.set_new_password')
- = simple_form_for(resource, as: resource_name, url: password_path(resource_name), html: { method: :put }) do |f|
- = render 'shared/error_messages', object: resource
+= simple_form_for(resource, as: resource_name, url: password_path(resource_name), html: { method: :put }) do |f|
+ = render 'shared/error_messages', object: resource
- - if use_pam? || current_user.encrypted_password.present?
- = f.input :reset_password_token, as: :hidden
+ - if !use_pam? || resource.encrypted_password.present?
+ = f.input :reset_password_token, as: :hidden
- = f.input :password, autofocus: true, placeholder: t('simple_form.labels.defaults.new_password'), input_html: { 'aria-label' => t('simple_form.labels.defaults.new_password'), :autocomplete => 'off' }
- = f.input :password_confirmation, placeholder: t('simple_form.labels.defaults.confirm_new_password'), input_html: { 'aria-label' => t('simple_form.labels.defaults.confirm_new_password'), :autocomplete => 'off' }
+ = f.input :password, autofocus: true, placeholder: t('simple_form.labels.defaults.new_password'), input_html: { 'aria-label' => t('simple_form.labels.defaults.new_password'), :autocomplete => 'off' }
+ = f.input :password_confirmation, placeholder: t('simple_form.labels.defaults.confirm_new_password'), input_html: { 'aria-label' => t('simple_form.labels.defaults.confirm_new_password'), :autocomplete => 'off' }
- .actions
- = f.button :button, t('auth.set_new_password'), type: :submit
- - else
- = t('simple_form.labels.defaults.pam_account')
+ .actions
+ = f.button :button, t('auth.set_new_password'), type: :submit
+ - else
+ = t('simple_form.labels.defaults.pam_account')
.form-footer= render 'auth/shared/links'
diff --git a/app/views/auth/registrations/edit.html.haml b/app/views/auth/registrations/edit.html.haml
index 102199f819..ca18caa563 100644
--- a/app/views/auth/registrations/edit.html.haml
+++ b/app/views/auth/registrations/edit.html.haml
@@ -4,7 +4,7 @@
= simple_form_for(resource, as: resource_name, url: registration_path(resource_name), html: { method: :put, class: 'auth_edit' }) do |f|
= render 'shared/error_messages', object: resource
- - if !use_pam? || current_user.encrypted_password.present?
+ - if !use_pam? || resource.encrypted_password.present?
= f.input :email, placeholder: t('simple_form.labels.defaults.email'), input_html: { 'aria-label' => t('simple_form.labels.defaults.email') }
= f.input :password, placeholder: t('simple_form.labels.defaults.new_password'), input_html: { 'aria-label' => t('simple_form.labels.defaults.new_password'), :autocomplete => 'off' }
= f.input :password_confirmation, placeholder: t('simple_form.labels.defaults.confirm_new_password'), input_html: { 'aria-label' => t('simple_form.labels.defaults.confirm_new_password'), :autocomplete => 'off' }
diff --git a/config/initializers/chewy.rb b/config/initializers/chewy.rb
new file mode 100644
index 0000000000..bef2746ec7
--- /dev/null
+++ b/config/initializers/chewy.rb
@@ -0,0 +1,22 @@
+enabled = ENV['ES_ENABLED'] == 'true'
+host = ENV.fetch('ES_HOST') { 'localhost' }
+port = ENV.fetch('ES_PORT') { 9200 }
+fallback_prefix = ENV.fetch('REDIS_NAMESPACE') { nil }
+prefix = ENV.fetch('ES_PREFIX') { fallback_prefix }
+
+Chewy.settings = {
+ host: "#{host}:#{port}",
+ prefix: prefix,
+ enabled: enabled,
+ journal: false,
+}
+
+Chewy.root_strategy = enabled ? :sidekiq : :bypass
+
+module Chewy
+ class << self
+ def enabled?
+ settings[:enabled]
+ end
+ end
+end
diff --git a/docker-compose.yml b/docker-compose.yml
index aaa3a44782..55b419e984 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -19,6 +19,17 @@ services:
# volumes:
# - ./redis:/data
+# es:
+# restart: always
+# image: docker.elastic.co/elasticsearch/elasticsearch-oss:6.1.3
+# environment:
+# - "ES_JAVA_OPTS=-Xms512m -Xmx512m"
+# networks:
+# - internal_network
+#### Uncomment to enable ES persistance
+## volumes:
+## - ./elasticsearch:/usr/share/elasticsearch/data
+
web:
build: .
image: gargron/mastodon
@@ -33,6 +44,7 @@ services:
depends_on:
- db
- redis
+# - es
volumes:
- ./public/assets:/mastodon/public/assets
- ./public/packs:/mastodon/public/packs
diff --git a/spec/fixtures/requests/webfinger-hacker3.txt b/spec/fixtures/requests/webfinger-hacker3.txt
new file mode 100644
index 0000000000..c59f518bd0
--- /dev/null
+++ b/spec/fixtures/requests/webfinger-hacker3.txt
@@ -0,0 +1,11 @@
+HTTP/1.1 200 OK
+Server: nginx/1.6.2
+Date: Sun, 20 Mar 2016 11:13:16 GMT
+Content-Type: application/jrd+json
+Transfer-Encoding: chunked
+Connection: keep-alive
+Access-Control-Allow-Origin: *
+Vary: Accept-Encoding,Cookie
+Strict-Transport-Security: max-age=31536000; includeSubdomains;
+
+{"subject":"acct:localhost@kickass.zone","aliases":["https:\/\/kickass.zone\/user\/7477","https:\/\/kickass.zone\/gargron","https:\/\/kickass.zone\/index.php\/user\/7477","https:\/\/kickass.zone\/index.php\/gargron"],"links":[{"rel":"http:\/\/webfinger.net\/rel\/profile-page","type":"text\/html","href":"https:\/\/kickass.zone\/gargron"},{"rel":"http:\/\/gmpg.org\/xfn\/11","type":"text\/html","href":"https:\/\/kickass.zone\/gargron"},{"rel":"describedby","type":"application\/rdf+xml","href":"https:\/\/kickass.zone\/gargron\/foaf"},{"rel":"http:\/\/apinamespace.org\/atom","type":"application\/atomsvc+xml","href":"https:\/\/kickass.zone\/api\/statusnet\/app\/service\/gargron.xml"},{"rel":"http:\/\/apinamespace.org\/twitter","href":"https:\/\/kickass.zone\/api\/"},{"rel":"http:\/\/specs.openid.net\/auth\/2.0\/provider","href":"https:\/\/kickass.zone\/gargron"},{"rel":"http:\/\/schemas.google.com\/g\/2010#updates-from","type":"application\/atom+xml","href":"https:\/\/kickass.zone\/api\/statuses\/user_timeline\/7477.atom"},{"rel":"magic-public-key","href":"data:application\/magic-public-key,RSA.1ZBkHTavLvxH3FzlKv4O6WtlILKRFfNami3_Rcu8EuogtXSYiS-bB6hElZfUCSHbC4uLemOA34PEhz__CDMozax1iI_t8dzjDnh1x0iFSup7pSfW9iXk_WU3Dm74yWWW2jildY41vWgrEstuQ1dJ8vVFfSJ9T_tO4c-T9y8vDI8=.AQAB"},{"rel":"salmon","href":"https:\/\/kickass.zone\/main\/salmon\/user\/7477"},{"rel":"http:\/\/salmon-protocol.org\/ns\/salmon-replies","href":"https:\/\/kickass.zone\/main\/salmon\/user\/7477"},{"rel":"http:\/\/salmon-protocol.org\/ns\/salmon-mention","href":"https:\/\/kickass.zone\/main\/salmon\/user\/7477"},{"rel":"http:\/\/ostatus.org\/schema\/1.0\/subscribe","template":"https:\/\/kickass.zone\/main\/ostatussub?profile={uri}"}]}
diff --git a/spec/services/fetch_atom_service_spec.rb b/spec/services/fetch_atom_service_spec.rb
index d7f162b852..2bd127e921 100644
--- a/spec/services/fetch_atom_service_spec.rb
+++ b/spec/services/fetch_atom_service_spec.rb
@@ -1,62 +1,88 @@
require 'rails_helper'
RSpec.describe FetchAtomService do
- describe '#link_header' do
- context 'Link is Array' do
- target = FetchAtomService.new
- target.instance_variable_set('@response', 'Link' => [
- '; rel="up"; meta="bar"',
- '; rel="self"',
- ])
-
- it 'set first link as link_header' do
- expect(target.send(:link_header).links[0].href).to eq 'http://example.com/'
- end
- end
-
- context 'Link is not Array' do
- target = FetchAtomService.new
- target.instance_variable_set('@response', 'Link' => '; rel="self", ; rel = "up"')
-
- it { expect(target.send(:link_header).links[0].href).to eq 'http://example.com/foo' }
- end
- end
-
- describe '#perform_request' do
+ describe '#call' do
let(:url) { 'http://example.com' }
- context 'Check method result' do
+ subject { FetchAtomService.new.call(url) }
+
+ context 'url is blank' do
+ let(:url) { '' }
+ it { is_expected.to be_nil }
+ end
+
+ context 'request failed' do
before do
- WebMock.stub_request(:get, url).to_return(status: 200, body: '', headers: {})
- @target = FetchAtomService.new
- @target.instance_variable_set('@url', url)
+ WebMock.stub_request(:get, url).to_return(status: 500, body: '', headers: {})
end
- it 'HTTP::Response instance is returned and set to @response' do
- expect(@target.send(:perform_request).status.to_s).to eq '200 OK'
- expect(@target.instance_variable_get('@response')).to be_instance_of HTTP::Response
+ it { is_expected.to be_nil }
+ end
+
+ context 'raise OpenSSL::SSL::SSLError' do
+ before do
+ allow(Request).to receive_message_chain(:new, :add_headers, :perform).and_raise(OpenSSL::SSL::SSLError)
+ end
+
+ it 'output log and return nil' do
+ expect_any_instance_of(ActiveSupport::Logger).to receive(:debug).with('SSL error: OpenSSL::SSL::SSLError')
+ is_expected.to be_nil
end
end
- context 'check passed parameters to Request' do
+ context 'raise HTTP::ConnectionError' do
before do
- @target = FetchAtomService.new
- @target.instance_variable_set('@url', url)
- @target.instance_variable_set('@unsupported_activity', unsupported_activity)
- allow(Request).to receive(:new).with(:get, url)
- expect(Request).to receive_message_chain(:new, :add_headers).with('Accept' => accept)
- allow(Request).to receive_message_chain(:new, :add_headers, :perform).with(no_args)
+ allow(Request).to receive_message_chain(:new, :add_headers, :perform).and_raise(HTTP::ConnectionError)
end
- context '@unsupported_activity is true' do
- let(:unsupported_activity) { true }
- let(:accept) { 'text/html' }
- it { @target.send(:perform_request) }
+ it 'output log and return nil' do
+ expect_any_instance_of(ActiveSupport::Logger).to receive(:debug).with('HTTP ConnectionError: HTTP::ConnectionError')
+ is_expected.to be_nil
+ end
+ end
+
+ context 'response success' do
+ let(:body) { '' }
+ let(:headers) { { 'Content-Type' => content_type } }
+ let(:json) {
+ { id: 1,
+ '@context': ActivityPub::TagManager::CONTEXT,
+ type: 'Note',
+ }.to_json
+ }
+
+ before do
+ WebMock.stub_request(:get, url).to_return(status: 200, body: body, headers: headers)
end
- context '@unsupported_activity is false' do
- let(:unsupported_activity) { false }
- let(:accept) { 'application/activity+json, application/ld+json, application/atom+xml, text/html' }
- it { @target.send(:perform_request) }
+ context 'content type is application/atom+xml' do
+ let(:content_type) { 'application/atom+xml' }
+
+ it { is_expected.to eq [url, {:prefetched_body=>""}, :ostatus] }
+ end
+
+ context 'content_type is json' do
+ let(:content_type) { 'application/activity+json' }
+ let(:body) { json }
+
+ it { is_expected.to eq [1, { prefetched_body: body, id: true }, :activitypub] }
+ end
+
+ before do
+ WebMock.stub_request(:get, url).to_return(status: 200, body: body, headers: headers)
+ WebMock.stub_request(:get, 'http://example.com/foo').to_return(status: 200, body: json, headers: { 'Content-Type' => 'application/activity+json' })
+ end
+
+ context 'has link header' do
+ let(:headers) { { 'Link' => '; rel="alternate"; type="application/activity+json"', } }
+
+ it { is_expected.to eq [1, { prefetched_body: json, id: true }, :activitypub] }
+ end
+
+ context 'content type is text/html' do
+ let(:content_type) { 'text/html' }
+ let(:body) { '' }
+
+ it { is_expected.to eq [1, { prefetched_body: json, id: true }, :activitypub] }
end
end
end
diff --git a/spec/services/fetch_remote_account_service_spec.rb b/spec/services/fetch_remote_account_service_spec.rb
index bb1877c7a2..4388d4cf4e 100644
--- a/spec/services/fetch_remote_account_service_spec.rb
+++ b/spec/services/fetch_remote_account_service_spec.rb
@@ -1,4 +1,71 @@
require 'rails_helper'
RSpec.describe FetchRemoteAccountService do
+ let(:url) { 'https://example.com' }
+ let(:prefetched_body) { nil }
+ let(:protocol) { :ostatus }
+ subject { FetchRemoteAccountService.new.call(url, prefetched_body, protocol) }
+
+ let(:actor) do
+ {
+ '@context': 'https://www.w3.org/ns/activitystreams',
+ id: 'https://example.com/alice',
+ type: 'Person',
+ preferredUsername: 'alice',
+ name: 'Alice',
+ summary: 'Foo bar',
+ inbox: 'http://example.com/alice/inbox',
+ }
+ end
+
+ let(:webfinger) { { subject: 'acct:alice@example.com', links: [{ rel: 'self', href: 'https://example.com/alice' }] } }
+ let(:xml) { File.read(File.join(Rails.root, 'spec', 'fixtures', 'xml', 'mastodon.atom')) }
+
+ shared_examples 'return Account' do
+ it { is_expected.to be_an Account }
+ end
+
+ context 'protocol is :activitypub' do
+ let(:prefetched_body) { Oj.dump(actor) }
+ let(:protocol) { :activitypub }
+
+ before do
+ stub_request(:get, 'https://example.com/.well-known/webfinger?resource=acct:alice@example.com').to_return(body: Oj.dump(webfinger), headers: { 'Content-Type': 'application/jrd+json' })
+ end
+
+ include_examples 'return Account'
+ end
+
+ context 'protocol is :ostatus' do
+ let(:prefetched_body) { xml }
+ let(:protocol) { :ostatus }
+
+ before do
+ stub_request(:get, "https://kickass.zone/.well-known/webfinger?resource=acct:localhost@kickass.zone").to_return(request_fixture('webfinger-hacker3.txt'))
+ stub_request(:get, "https://kickass.zone/api/statuses/user_timeline/7477.atom").to_return(request_fixture('feed.txt'))
+ end
+
+ include_examples 'return Account'
+ end
+
+ context 'when prefetched_body is nil' do
+ context 'protocol is :activitypub' do
+ before do
+ stub_request(:get, url).to_return(status: 200, body: Oj.dump(actor), headers: { 'Content-Type' => 'application/activity+json' })
+ stub_request(:get, 'https://example.com/.well-known/webfinger?resource=acct:alice@example.com').to_return(body: Oj.dump(webfinger), headers: { 'Content-Type': 'application/jrd+json' })
+ end
+
+ include_examples 'return Account'
+ end
+
+ context 'protocol is :ostatus' do
+ before do
+ stub_request(:get, url).to_return(status: 200, body: xml, headers: { 'Content-Type' => 'application/atom+xml' })
+ stub_request(:get, "https://kickass.zone/.well-known/webfinger?resource=acct:localhost@kickass.zone").to_return(request_fixture('webfinger-hacker3.txt'))
+ stub_request(:get, "https://kickass.zone/api/statuses/user_timeline/7477.atom").to_return(request_fixture('feed.txt'))
+ end
+
+ include_examples 'return Account'
+ end
+ end
end
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index eecaec4acf..a0466dd4bf 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -25,6 +25,10 @@ RSpec.configure do |config|
end
end
+ config.before :suite do
+ Chewy.strategy(:bypass)
+ end
+
config.after :suite do
gc_counter = 0
FileUtils.rm_rf(Dir["#{Rails.root}/spec/test_files/"])