fedi/mastodon
1
0
Fork 1
mirror of https://github.com/mastodon/mastodon.git synced 2024-11-22 06:06:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ignore undefined as canonical url (#31882)

Browse source
This commit is contained in:
David Roetzel 2024-09-12 13:14:42 +02:00 committed by GitHub
parent 3d46f47817
commit ab763c493f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/lib/link_details_extractor.rb
View file

@ -225,7 +225,7 @@ class LinkDetailsExtractor
end end
def valid_url_or_nil(str, same_origin_only: false) def valid_url_or_nil(str, same_origin_only: false)
return if str.blank? || str == 'null' return if str.blank? || str == 'null' || str == 'undefined'
url = @original_url + Addressable::URI.parse(str) url = @original_url + Addressable::URI.parse(str)

8
spec/lib/link_details_extractor_spec.rb
View file

@ -33,6 +33,14 @@ RSpec.describe LinkDetailsExtractor do
expect(subject.canonical_url).to eq original_url expect(subject.canonical_url).to eq original_url
end end
end end
context 'when canonical URL is set to "undefined"' do
let(:url) { 'undefined' }
it 'ignores the canonical URLs' do
expect(subject.canonical_url).to eq original_url
end
end
end end
context 'when only basic metadata is present' do context 'when only basic metadata is present' do