fedi/mastodon
1
0
Fork 1
mirror of https://github.com/mastodon/mastodon.git synced 2024-12-18 15:48:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Rails/WhereExists cop in app/models (#28863)

Browse source
This commit is contained in:
Matt Jankowski 2024-01-24 04:57:49 -05:00 committed by GitHub
parent 599bc69503
commit 9d413cbaf8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.rubocop_todo.yml
View file

@ -81,9 +81,6 @@ Rails/WhereExists:
- 'app/lib/delivery_failure_tracker.rb' - 'app/lib/delivery_failure_tracker.rb'
- 'app/lib/feed_manager.rb' - 'app/lib/feed_manager.rb'
- 'app/lib/suspicious_sign_in_detector.rb' - 'app/lib/suspicious_sign_in_detector.rb'
- 'app/models/poll.rb'
- 'app/models/session_activation.rb'
- 'app/models/status.rb'
- 'app/policies/status_policy.rb' - 'app/policies/status_policy.rb'
- 'app/serializers/rest/announcement_serializer.rb' - 'app/serializers/rest/announcement_serializer.rb'
- 'app/workers/move_worker.rb' - 'app/workers/move_worker.rb'

2
app/models/poll.rb
View file

@ -57,7 +57,7 @@ class Poll < ApplicationRecord
end end
def voted?(account) def voted?(account)
account.id == account_id || votes.where(account: account).exists? account.id == account_id || votes.exists?(account: account)
end end
def own_votes(account) def own_votes(account)

2
app/models/session_activation.rb
View file

@ -41,7 +41,7 @@ class SessionActivation < ApplicationRecord
class << self class << self
def active?(id) def active?(id)
id && where(session_id: id).exists? id && exists?(session_id: id)
end end
def activate(**options) def activate(**options)

2
app/models/status.rb
View file

@ -263,7 +263,7 @@ class Status < ApplicationRecord
end end
def reported? def reported?
@reported ||= Report.where(target_account: account).unresolved.where('? = ANY(status_ids)', id).exists? @reported ||= Report.where(target_account: account).unresolved.exists?(['? = ANY(status_ids)', id])
end end
def emojis def emojis