Ensure unique values in fabricators (#29515)

spec/fabrication/fabricators_spec.rb

@@ -6,9 +6,9 @@ Fabrication.manager.load_definitions if Fabrication.manager.empty?
 
 Fabrication.manager.schematics.map(&:first).each do |factory_name|
   describe "The #{factory_name} factory" do
-    it 'is valid' do
+    it 'is able to create valid records' do
-      factory = Fabricate(factory_name)
+      records = Fabricate.times(2, factory_name) # Create multiple of each to uncover uniqueness issues
-      expect(factory).to be_valid
+      expect(records).to all(be_valid)
     end
   end
 end

spec/fabricators/identity_fabricator.rb

@@ -3,5 +3,5 @@
 Fabricator(:identity) do
   user { Fabricate.build(:user) }
   provider 'MyString'
-  uid      'MyString'
+  uid { sequence(:uid) { |i| "uid_string_#{i}" } }
 end

spec/fabricators/relay_fabricator.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 Fabricator(:relay) do
-  inbox_url 'https://example.com/inbox'
+  inbox_url { sequence(:inbox_url) { |i| "https://example.com/inboxes/#{i}" } }
   state :idle
 end

spec/fabricators/site_upload_fabricator.rb

@@ -2,5 +2,5 @@
 
 Fabricator(:site_upload) do
   file { Rails.root.join('spec', 'fabricators', 'assets', 'utah_teapot.png').open }
-  var 'thumbnail'
+  var { sequence(:var) { |i| "thumbnail_#{i}" } }
 end