Fix list creation limit check (#32869)

This commit is contained in:
Claire 2024-11-13 11:22:11 +01:00 committed by GitHub
parent 95d7120ce6
commit 8f5cbf5370
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions

View file

@ -34,7 +34,7 @@ class List < ApplicationRecord
private private
def validate_account_lists_limit def validate_account_lists_limit
errors.add(:base, I18n.t('lists.errors.limit')) if account.lists.count >= PER_ACCOUNT_LIMIT errors.add(:base, I18n.t('lists.errors.limit')) if account.owned_lists.count >= PER_ACCOUNT_LIMIT
end end
def clean_feed_manager def clean_feed_manager

View file

@ -11,7 +11,11 @@ RSpec.describe List do
context 'when account has hit max list limit' do context 'when account has hit max list limit' do
let(:account) { Fabricate :account } let(:account) { Fabricate :account }
before { stub_const 'List::PER_ACCOUNT_LIMIT', 0 } before do
stub_const 'List::PER_ACCOUNT_LIMIT', 1
Fabricate(:list, account: account)
end
context 'when creating a new list' do context 'when creating a new list' do
it { is_expected.to_not allow_value(account).for(:account).against(:base).with_message(I18n.t('lists.errors.limit')) } it { is_expected.to_not allow_value(account).for(:account).against(:base).with_message(I18n.t('lists.errors.limit')) }