fedi/mastodon
1
0
Fork 1
mirror of https://github.com/mastodon/mastodon.git synced 2024-11-24 06:46:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix alt+enter changing visibility setting without sending toot when toot is empty

Browse source
This commit is contained in:
Thibaut Girka 2020-02-14 20:19:35 +01:00 committed by ThibG
parent 0cbd6d696b
commit 40798cba41
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/javascript/flavours/glitch/features/compose/components/compose_form.js
View file

@ -93,7 +93,7 @@ class ComposeForm extends ImmutablePureComponent {
} }
} }
handleSubmit = () => { handleSubmit = (overriddenVisibility = null) => {
const { textarea: { value }, uploadForm } = this; const { textarea: { value }, uploadForm } = this;
const { const {
onChange, onChange,
@ -106,6 +106,7 @@ class ComposeForm extends ImmutablePureComponent {
text, text,
mediaDescriptionConfirmation, mediaDescriptionConfirmation,
onMediaDescriptionConfirm, onMediaDescriptionConfirm,
onChangeVisibility,
} = this.props; } = this.props;
// If something changes inside the textarea, then we update the // If something changes inside the textarea, then we update the
@ -124,6 +125,9 @@ class ComposeForm extends ImmutablePureComponent {
const firstWithoutDescription = media.find(item => !item.get('description')); const firstWithoutDescription = media.find(item => !item.get('description'));
onMediaDescriptionConfirm(this.context.router ? this.context.router.history : null, firstWithoutDescription.get('id')); onMediaDescriptionConfirm(this.context.router ? this.context.router.history : null, firstWithoutDescription.get('id'));
} else if (onSubmit) { } else if (onSubmit) {
if (onChangeVisibility && overriddenVisibility) {
onChangeVisibility(overriddenVisibility);
}
onSubmit(this.context.router ? this.context.router.history : null); onSubmit(this.context.router ? this.context.router.history : null);
} }
} }
@ -152,13 +156,9 @@ class ComposeForm extends ImmutablePureComponent {
// Handles the secondary submit button. // Handles the secondary submit button.
handleSecondarySubmit = () => { handleSecondarySubmit = () => {
const { const {
onChangeVisibility,
sideArm, sideArm,
} = this.props; } = this.props;
if (sideArm !== 'none' && onChangeVisibility) { this.handleSubmit(sideArm === 'none' ? null : sideArm);
onChangeVisibility(sideArm);
}
this.handleSubmit();
} }
// Selects a suggestion from the autofill. // Selects a suggestion from the autofill.