diff --git a/app/controllers/api/web/push_subscriptions_controller.rb b/app/controllers/api/web/push_subscriptions_controller.rb
index 52e250d02d..68ccbd5e20 100644
--- a/app/controllers/api/web/push_subscriptions_controller.rb
+++ b/app/controllers/api/web/push_subscriptions_controller.rb
@@ -4,6 +4,7 @@ class Api::Web::PushSubscriptionsController < Api::BaseController
respond_to :json
before_action :require_user!
+ protect_from_forgery with: :exception
def create
params.require(:subscription).require(:endpoint)
diff --git a/app/javascript/mastodon/features/ui/components/columns_area.js b/app/javascript/mastodon/features/ui/components/columns_area.js
index f00b74dfdc..a01e5a390e 100644
--- a/app/javascript/mastodon/features/ui/components/columns_area.js
+++ b/app/javascript/mastodon/features/ui/components/columns_area.js
@@ -37,6 +37,7 @@ export default class ColumnsArea extends ImmutablePureComponent {
static propTypes = {
intl: PropTypes.object.isRequired,
columns: ImmutablePropTypes.list.isRequired,
+ isModalOpen: PropTypes.bool.isRequired,
singleColumn: PropTypes.bool,
children: PropTypes.node,
};
@@ -144,7 +145,7 @@ export default class ColumnsArea extends ImmutablePureComponent {
}
render () {
- const { columns, children, singleColumn } = this.props;
+ const { columns, children, singleColumn, isModalOpen } = this.props;
const { shouldAnimate } = this.state;
const columnIndex = getIndex(this.context.router.history.location.pathname);
@@ -159,7 +160,7 @@ export default class ColumnsArea extends ImmutablePureComponent {
}
return (
-
+
{columns.map(column => {
const params = column.get('params', null) === null ? null : column.get('params').toJS();
diff --git a/app/javascript/mastodon/features/ui/containers/columns_area_container.js b/app/javascript/mastodon/features/ui/containers/columns_area_container.js
index 95f95618b2..f3e82a8ac2 100644
--- a/app/javascript/mastodon/features/ui/containers/columns_area_container.js
+++ b/app/javascript/mastodon/features/ui/containers/columns_area_container.js
@@ -3,6 +3,7 @@ import ColumnsArea from '../components/columns_area';
const mapStateToProps = state => ({
columns: state.getIn(['settings', 'columns']),
+ isModalOpen: !!state.get('modal').modalType,
});
export default connect(mapStateToProps, null, null, { withRef: true })(ColumnsArea);
diff --git a/app/javascript/styles/mastodon/components.scss b/app/javascript/styles/mastodon/components.scss
index a2e908683f..71bffdaa68 100644
--- a/app/javascript/styles/mastodon/components.scss
+++ b/app/javascript/styles/mastodon/components.scss
@@ -1613,6 +1613,10 @@
justify-content: flex-start;
overflow-x: auto;
position: relative;
+
+ &.unscrollable {
+ overflow-x: hidden;
+ }
}
@media screen and (min-width: 360px) {
diff --git a/app/models/user.rb b/app/models/user.rb
index 855ae908d2..65ecb33cd3 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -170,6 +170,10 @@ class User < ApplicationRecord
settings.default_privacy || (account.locked? ? 'private' : 'public')
end
+ def allows_digest_emails?
+ settings.notification_emails['digest']
+ end
+
def token_for_app(a)
return nil if a.nil? || a.owner != self
Doorkeeper::AccessToken
diff --git a/app/services/activitypub/fetch_remote_status_service.rb b/app/services/activitypub/fetch_remote_status_service.rb
index 7649bceca9..503c175d8a 100644
--- a/app/services/activitypub/fetch_remote_status_service.rb
+++ b/app/services/activitypub/fetch_remote_status_service.rb
@@ -30,7 +30,7 @@ class ActivityPub::FetchRemoteStatusService < BaseService
end
def actor_id
- first_of_value(@json['attributedTo'])
+ value_or_id(first_of_value(@json['attributedTo']))
end
def trustworthy_attribution?(uri, attributed_to)
diff --git a/app/workers/digest_mailer_worker.rb b/app/workers/digest_mailer_worker.rb
index 028db89a9a..21f1c357a0 100644
--- a/app/workers/digest_mailer_worker.rb
+++ b/app/workers/digest_mailer_worker.rb
@@ -9,7 +9,7 @@ class DigestMailerWorker
def perform(user_id)
@user = User.find(user_id)
- deliver_digest if user_receives_digest?
+ deliver_digest if @user.allows_digest_emails?
end
private
@@ -18,8 +18,4 @@ class DigestMailerWorker
NotificationMailer.digest(user.account).deliver_now!
user.touch(:last_emailed_at)
end
-
- def user_receives_digest?
- user.settings.notification_emails['digest']
- end
end
diff --git a/app/workers/scheduler/email_scheduler.rb b/app/workers/scheduler/email_scheduler.rb
new file mode 100644
index 0000000000..24d0c0ebef
--- /dev/null
+++ b/app/workers/scheduler/email_scheduler.rb
@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+require 'sidekiq-scheduler'
+
+class Scheduler::EmailScheduler
+ include Sidekiq::Worker
+
+ def perform
+ eligible_users.find_each do |user|
+ next unless user.allows_digest_emails?
+ DigestMailerWorker.perform_async(user.id)
+ end
+ end
+
+ private
+
+ def eligible_users
+ User.confirmed
+ .joins(:account)
+ .where(accounts: { silenced: false, suspended: false })
+ .where(disabled: false)
+ .where('current_sign_in_at < ?', 20.days.ago)
+ .where('last_emailed_at IS NULL OR last_emailed_at < ?', 20.days.ago)
+ end
+end
diff --git a/config/initializers/suppress_csrf_warnings.rb b/config/initializers/suppress_csrf_warnings.rb
new file mode 100644
index 0000000000..410ab585b4
--- /dev/null
+++ b/config/initializers/suppress_csrf_warnings.rb
@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+ActionController::Base.log_warning_on_csrf_failure = false
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 2691b9ed99..4fc3924347 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -561,12 +561,14 @@ en:
blackberry: Blackberry
chrome: Chrome
edge: Microsoft Edge
+ electron: Electron
firefox: Firefox
generic: Unknown browser
ie: Internet Explorer
micro_messenger: MicroMessenger
nokia: Nokia S40 Ovi Browser
opera: Opera
+ otter: Otter
phantom_js: PhantomJS
qq: QQ Browser
safari: Safari
diff --git a/config/locales/simple_form.en.yml b/config/locales/simple_form.en.yml
index aa6940e916..ceb015282b 100644
--- a/config/locales/simple_form.en.yml
+++ b/config/locales/simple_form.en.yml
@@ -4,7 +4,7 @@ en:
hints:
defaults:
avatar: PNG, GIF or JPG. At most 2MB. Will be downscaled to 120x120px
- digest: Sent after a long period of inactivity with a summary of mentions you've received in your absence
+ digest: Only sent after a long period of inactivity and only if you have received any personal messages in your absence
display_name:
one: 1 character left
other: %{count} characters left
diff --git a/config/sidekiq.yml b/config/sidekiq.yml
index 4c35dcd43a..bfe29b8f81 100644
--- a/config/sidekiq.yml
+++ b/config/sidekiq.yml
@@ -27,3 +27,6 @@
ip_cleanup_scheduler:
cron: '<%= Random.rand(0..59) %> <%= Random.rand(3..5) %> * * *'
class: Scheduler::IpCleanupScheduler
+ email_scheduler:
+ cron: '0 10 * * 2'
+ class: Scheduler::EmailScheduler
diff --git a/lib/tasks/mastodon.rake b/lib/tasks/mastodon.rake
index 33969d470c..38dbed982a 100644
--- a/lib/tasks/mastodon.rake
+++ b/lib/tasks/mastodon.rake
@@ -171,11 +171,10 @@ namespace :mastodon do
end
namespace :emails do
- desc 'Send out digest e-mails'
+ desc 'Send out digest e-mails (deprecated)'
task digest: :environment do
- User.confirmed.joins(:account).where(accounts: { silenced: false, suspended: false }).where('current_sign_in_at < ?', 20.days.ago).find_each do |user|
- DigestMailerWorker.perform_async(user.id)
- end
+ # No-op
+ # This task is now executed via sidekiq-scheduler
end
end