Convert instance_actor controller spec to request spec (#31621)

This commit is contained in:
Matt Jankowski 2024-08-28 03:56:07 -04:00 committed by GitHub
parent 04f0468016
commit 00586d27cb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 71 additions and 54 deletions

View file

@ -1,54 +0,0 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe InstanceActorsController do
describe 'GET #show' do
context 'with JSON' do
let(:format) { 'json' }
shared_examples 'shared behavior' do
before do
get :show, params: { format: format }
end
it 'returns http success with correct media type and body' do
expect(response)
.to have_http_status(200)
.and have_attributes(
media_type: eq('application/activity+json')
)
expect(body_as_json)
.to include(:id, :type, :preferredUsername, :inbox, :publicKey, :inbox, :outbox, :url)
end
it_behaves_like 'cacheable response'
end
before do
allow(controller).to receive(:authorized_fetch_mode?).and_return(authorized_fetch_mode)
end
context 'without authorized fetch mode' do
let(:authorized_fetch_mode) { false }
it_behaves_like 'shared behavior'
end
context 'with authorized fetch mode' do
let(:authorized_fetch_mode) { true }
it_behaves_like 'shared behavior'
end
context 'with a suspended instance actor' do
let(:authorized_fetch_mode) { false }
before { Account.representative.update(suspended_at: 10.days.ago) }
it_behaves_like 'shared behavior'
end
end
end
end

View file

@ -0,0 +1,71 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe 'Instance actor endpoint' do
describe 'GET /actor' do
before do
integration_session.https! # TODO: Move to global rails_helper for all request specs?
host! Rails.configuration.x.local_domain # TODO: Move to global rails_helper for all request specs?
end
let!(:original_federation_mode) { Rails.configuration.x.limited_federation_mode }
shared_examples 'instance actor endpoint' do
before { get instance_actor_path(format: :json) }
it 'returns http success with correct media type and body' do
expect(response)
.to have_http_status(200)
expect(response.content_type)
.to start_with('application/activity+json')
expect(body_as_json)
.to include(
id: instance_actor_url,
type: 'Application',
preferredUsername: 'mastodon.internal',
inbox: instance_actor_inbox_url,
outbox: instance_actor_outbox_url,
publicKey: include(
id: instance_actor_url(anchor: 'main-key')
),
url: about_more_url(instance_actor: true)
)
end
it_behaves_like 'cacheable response'
end
context 'with limited federation mode disabled' do
before { Rails.configuration.x.limited_federation_mode = false }
after { Rails.configuration.x.limited_federation_mode = original_federation_mode }
it_behaves_like 'instance actor endpoint'
context 'with a disabled instance actor' do
before { disable_instance_actor }
it_behaves_like 'instance actor endpoint'
end
end
context 'with limited federation mode enabled' do
before { Rails.configuration.x.limited_federation_mode = true }
after { Rails.configuration.x.limited_federation_mode = original_federation_mode }
it_behaves_like 'instance actor endpoint'
context 'with a disabled instance actor' do
before { disable_instance_actor }
it_behaves_like 'instance actor endpoint'
end
end
def disable_instance_actor
Account
.representative
.update(suspended_at: 10.days.ago)
end
end
end