2023-02-22 00:55:31 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-09-05 15:46:36 +00:00
|
|
|
require 'rails_helper'
|
|
|
|
|
2024-07-08 16:01:08 +00:00
|
|
|
RSpec.describe MediaAttachment, :attachment_processing do
|
2017-11-08 06:29:07 +00:00
|
|
|
describe 'local?' do
|
|
|
|
subject { media_attachment.local? }
|
|
|
|
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media_attachment) { described_class.new(remote_url: remote_url) }
|
2023-02-20 04:24:14 +00:00
|
|
|
|
2023-05-04 03:49:08 +00:00
|
|
|
context 'when remote_url is blank' do
|
2017-11-08 06:29:07 +00:00
|
|
|
let(:remote_url) { '' }
|
|
|
|
|
|
|
|
it 'returns true' do
|
2023-02-20 04:00:48 +00:00
|
|
|
expect(subject).to be true
|
2017-11-08 06:29:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 03:49:08 +00:00
|
|
|
context 'when remote_url is present' do
|
2017-11-08 06:29:07 +00:00
|
|
|
let(:remote_url) { 'remote_url' }
|
|
|
|
|
|
|
|
it 'returns false' do
|
2023-02-20 04:00:48 +00:00
|
|
|
expect(subject).to be false
|
2017-11-08 06:29:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'needs_redownload?' do
|
|
|
|
subject { media_attachment.needs_redownload? }
|
|
|
|
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media_attachment) { described_class.new(remote_url: remote_url, file: file) }
|
2023-02-20 04:24:14 +00:00
|
|
|
|
2023-05-04 03:49:08 +00:00
|
|
|
context 'when file is blank' do
|
2017-11-08 06:29:07 +00:00
|
|
|
let(:file) { nil }
|
|
|
|
|
2023-05-04 03:49:08 +00:00
|
|
|
context 'when remote_url is present' do
|
2017-11-08 06:29:07 +00:00
|
|
|
let(:remote_url) { 'remote_url' }
|
|
|
|
|
|
|
|
it 'returns true' do
|
2023-02-20 04:00:48 +00:00
|
|
|
expect(subject).to be true
|
2017-11-08 06:29:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 03:49:08 +00:00
|
|
|
context 'when file is present' do
|
2017-11-08 06:29:07 +00:00
|
|
|
let(:file) { attachment_fixture('avatar.gif') }
|
|
|
|
|
2023-05-04 03:49:08 +00:00
|
|
|
context 'when remote_url is blank' do
|
2017-11-08 06:29:07 +00:00
|
|
|
let(:remote_url) { '' }
|
|
|
|
|
|
|
|
it 'returns false' do
|
2023-02-20 04:00:48 +00:00
|
|
|
expect(subject).to be false
|
2017-11-08 06:29:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 03:49:08 +00:00
|
|
|
context 'when remote_url is present' do
|
2017-11-08 06:29:07 +00:00
|
|
|
let(:remote_url) { 'remote_url' }
|
|
|
|
|
|
|
|
it 'returns true' do
|
2023-02-20 04:00:48 +00:00
|
|
|
expect(subject).to be false
|
2017-11-08 06:29:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#to_param' do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media_attachment) { Fabricate.build(:media_attachment, shortcode: shortcode, id: id) }
|
2017-11-08 06:29:07 +00:00
|
|
|
|
2021-10-13 13:27:19 +00:00
|
|
|
context 'when media attachment has a shortcode' do
|
|
|
|
let(:shortcode) { 'foo' }
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:id) { 123 }
|
2021-10-13 13:27:19 +00:00
|
|
|
|
|
|
|
it 'returns shortcode' do
|
|
|
|
expect(media_attachment.to_param).to eq shortcode
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when media attachment does not have a shortcode' do
|
|
|
|
let(:shortcode) { nil }
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:id) { 123 }
|
2021-10-13 13:27:19 +00:00
|
|
|
|
|
|
|
it 'returns string representation of id' do
|
2023-08-07 15:58:12 +00:00
|
|
|
expect(media_attachment.to_param).to eq id.to_s
|
2021-10-13 13:27:19 +00:00
|
|
|
end
|
2017-11-08 06:29:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-08-01 17:34:11 +00:00
|
|
|
shared_examples 'static 600x400 image' do |content_type, extension|
|
|
|
|
after do
|
|
|
|
media.destroy
|
|
|
|
end
|
|
|
|
|
2024-07-18 15:23:46 +00:00
|
|
|
it 'saves media attachment with correct file and size metadata' do
|
2024-02-16 13:00:09 +00:00
|
|
|
expect(media)
|
|
|
|
.to be_persisted
|
|
|
|
.and be_processing_complete
|
|
|
|
.and have_attributes(
|
|
|
|
file: be_present,
|
|
|
|
type: eq('image'),
|
|
|
|
file_content_type: eq(content_type),
|
|
|
|
file_file_name: end_with(extension)
|
|
|
|
)
|
2023-09-04 07:46:33 +00:00
|
|
|
|
|
|
|
# Rack::Mime (used by PublicFileServerMiddleware) recognizes file extension
|
|
|
|
expect(Rack::Mime.mime_type(extension, nil)).to eq content_type
|
2023-08-01 17:34:11 +00:00
|
|
|
|
2024-07-18 15:23:46 +00:00
|
|
|
# Strip original file name
|
2024-02-16 13:00:09 +00:00
|
|
|
expect(media.file_file_name)
|
|
|
|
.to_not start_with '600x400'
|
|
|
|
|
2024-07-18 15:23:46 +00:00
|
|
|
# Set meta for original and thumbnail
|
2024-02-16 13:00:09 +00:00
|
|
|
expect(media.file.meta.deep_symbolize_keys)
|
|
|
|
.to include(
|
|
|
|
original: include(
|
|
|
|
width: eq(600),
|
|
|
|
height: eq(400),
|
|
|
|
aspect: eq(1.5)
|
|
|
|
),
|
|
|
|
small: include(
|
|
|
|
width: eq(588),
|
|
|
|
height: eq(392),
|
|
|
|
aspect: eq(1.5)
|
|
|
|
)
|
|
|
|
)
|
2023-08-01 17:34:11 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'jpeg' do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture('600x400.jpeg')) }
|
2023-08-01 17:34:11 +00:00
|
|
|
|
|
|
|
it_behaves_like 'static 600x400 image', 'image/jpeg', '.jpeg'
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'png' do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture('600x400.png')) }
|
2023-08-01 17:34:11 +00:00
|
|
|
|
|
|
|
it_behaves_like 'static 600x400 image', 'image/png', '.png'
|
|
|
|
end
|
|
|
|
|
2024-06-05 19:15:39 +00:00
|
|
|
describe 'monochrome jpg' do
|
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture('monochrome.png')) }
|
|
|
|
|
|
|
|
it_behaves_like 'static 600x400 image', 'image/png', '.png'
|
|
|
|
end
|
|
|
|
|
2023-08-01 17:34:11 +00:00
|
|
|
describe 'webp' do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture('600x400.webp')) }
|
2023-08-01 17:34:11 +00:00
|
|
|
|
|
|
|
it_behaves_like 'static 600x400 image', 'image/webp', '.webp'
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'avif' do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture('600x400.avif')) }
|
2023-08-01 17:34:11 +00:00
|
|
|
|
|
|
|
it_behaves_like 'static 600x400 image', 'image/jpeg', '.jpeg'
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'heic' do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture('600x400.heic')) }
|
2023-08-01 17:34:11 +00:00
|
|
|
|
|
|
|
it_behaves_like 'static 600x400 image', 'image/jpeg', '.jpeg'
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'base64-encoded image' do
|
|
|
|
let(:base64_attachment) { "data:image/jpeg;base64,#{Base64.encode64(attachment_fixture('600x400.jpeg').read)}" }
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: base64_attachment) }
|
2023-08-01 17:34:11 +00:00
|
|
|
|
|
|
|
it_behaves_like 'static 600x400 image', 'image/jpeg', '.jpeg'
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'animated gif' do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture('avatar.gif')) }
|
2016-09-09 18:04:34 +00:00
|
|
|
|
2023-08-07 15:58:12 +00:00
|
|
|
it 'sets correct file metadata' do
|
2024-07-18 15:23:46 +00:00
|
|
|
expect(media)
|
|
|
|
.to have_attributes(
|
|
|
|
type: eq('gifv'),
|
|
|
|
file_content_type: eq('video/mp4')
|
|
|
|
)
|
|
|
|
expect(media_metadata)
|
|
|
|
.to include(
|
|
|
|
original: include(
|
|
|
|
width: eq(128),
|
|
|
|
height: eq(128)
|
|
|
|
)
|
|
|
|
)
|
2017-04-26 01:48:12 +00:00
|
|
|
end
|
2017-04-19 21:21:00 +00:00
|
|
|
end
|
|
|
|
|
2023-08-01 17:34:11 +00:00
|
|
|
describe 'static gif' do
|
2017-10-26 13:48:35 +00:00
|
|
|
fixtures = [
|
|
|
|
{ filename: 'attachment.gif', width: 600, height: 400, aspect: 1.5 },
|
|
|
|
{ filename: 'mini-static.gif', width: 32, height: 32, aspect: 1.0 },
|
|
|
|
]
|
2017-04-19 21:21:00 +00:00
|
|
|
|
2017-10-26 13:48:35 +00:00
|
|
|
fixtures.each do |fixture|
|
|
|
|
context fixture[:filename] do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture(fixture[:filename])) }
|
2017-04-19 21:21:00 +00:00
|
|
|
|
2023-08-07 15:58:12 +00:00
|
|
|
it 'sets correct file metadata' do
|
2024-07-18 15:23:46 +00:00
|
|
|
expect(media)
|
|
|
|
.to have_attributes(
|
|
|
|
type: eq('image'),
|
|
|
|
file_content_type: eq('image/gif')
|
|
|
|
)
|
|
|
|
expect(media_metadata)
|
|
|
|
.to include(
|
|
|
|
original: include(
|
|
|
|
width: eq(fixture[:width]),
|
|
|
|
height: eq(fixture[:height]),
|
|
|
|
aspect: eq(fixture[:aspect])
|
|
|
|
)
|
|
|
|
)
|
2017-10-26 13:48:35 +00:00
|
|
|
end
|
|
|
|
end
|
2017-04-26 01:48:12 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-09-29 21:52:36 +00:00
|
|
|
describe 'ogg with cover art' do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture('boop.ogg')) }
|
2024-07-18 15:23:46 +00:00
|
|
|
let(:expected_media_duration) { 0.235102 }
|
2021-09-29 21:52:36 +00:00
|
|
|
|
2024-07-18 15:23:46 +00:00
|
|
|
# The libvips and ImageMagick implementations produce different results
|
|
|
|
let(:expected_background_color) { Rails.configuration.x.use_vips ? '#268cd9' : '#3088d4' }
|
2024-06-05 19:15:39 +00:00
|
|
|
|
2024-07-18 15:23:46 +00:00
|
|
|
it 'sets correct file metadata' do
|
|
|
|
expect(media)
|
|
|
|
.to have_attributes(
|
|
|
|
type: eq('audio'),
|
|
|
|
thumbnail: be_present,
|
|
|
|
file_file_name: not_eq('boop.ogg')
|
|
|
|
)
|
2024-06-27 16:03:26 +00:00
|
|
|
|
2024-07-18 15:23:46 +00:00
|
|
|
expect(media_metadata)
|
|
|
|
.to include(
|
|
|
|
original: include(duration: be_within(0.05).of(expected_media_duration)),
|
|
|
|
colors: include(background: eq(expected_background_color))
|
|
|
|
)
|
2024-06-27 16:03:26 +00:00
|
|
|
end
|
2021-09-29 21:52:36 +00:00
|
|
|
end
|
|
|
|
|
2023-07-06 13:05:05 +00:00
|
|
|
describe 'mp3 with large cover art' do
|
2023-08-07 15:58:12 +00:00
|
|
|
let(:media) { Fabricate(:media_attachment, file: attachment_fixture('boop.mp3')) }
|
2024-07-18 15:23:46 +00:00
|
|
|
let(:expected_media_duration) { 0.235102 }
|
2023-07-06 13:05:05 +00:00
|
|
|
|
2024-07-18 15:23:46 +00:00
|
|
|
it 'detects file type and sets correct metadata' do
|
|
|
|
expect(media)
|
|
|
|
.to have_attributes(
|
|
|
|
type: eq('audio'),
|
|
|
|
thumbnail: be_present,
|
|
|
|
file_file_name: not_eq('boop.mp3')
|
|
|
|
)
|
|
|
|
expect(media_metadata)
|
|
|
|
.to include(
|
|
|
|
original: include(duration: be_within(0.05).of(expected_media_duration))
|
|
|
|
)
|
2023-07-06 13:05:05 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2024-09-05 15:36:05 +00:00
|
|
|
it { is_expected.to validate_presence_of(:file) }
|
2020-01-23 20:40:03 +00:00
|
|
|
|
2021-10-06 13:49:32 +00:00
|
|
|
describe 'size limit validation' do
|
|
|
|
it 'rejects video files that are too large' do
|
|
|
|
stub_const 'MediaAttachment::IMAGE_LIMIT', 100.megabytes
|
|
|
|
stub_const 'MediaAttachment::VIDEO_LIMIT', 1.kilobyte
|
2023-08-07 15:58:12 +00:00
|
|
|
expect { Fabricate(:media_attachment, file: attachment_fixture('attachment.webm')) }.to raise_error(ActiveRecord::RecordInvalid)
|
2021-10-06 13:49:32 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'accepts video files that are small enough' do
|
|
|
|
stub_const 'MediaAttachment::IMAGE_LIMIT', 1.kilobyte
|
|
|
|
stub_const 'MediaAttachment::VIDEO_LIMIT', 100.megabytes
|
2023-08-07 15:58:12 +00:00
|
|
|
media = Fabricate(:media_attachment, file: attachment_fixture('attachment.webm'))
|
2021-10-06 13:49:32 +00:00
|
|
|
expect(media.valid?).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'rejects image files that are too large' do
|
|
|
|
stub_const 'MediaAttachment::IMAGE_LIMIT', 1.kilobyte
|
|
|
|
stub_const 'MediaAttachment::VIDEO_LIMIT', 100.megabytes
|
2023-08-07 15:58:12 +00:00
|
|
|
expect { Fabricate(:media_attachment, file: attachment_fixture('attachment.jpg')) }.to raise_error(ActiveRecord::RecordInvalid)
|
2021-10-06 13:49:32 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'accepts image files that are small enough' do
|
|
|
|
stub_const 'MediaAttachment::IMAGE_LIMIT', 100.megabytes
|
|
|
|
stub_const 'MediaAttachment::VIDEO_LIMIT', 1.kilobyte
|
2023-08-07 15:58:12 +00:00
|
|
|
media = Fabricate(:media_attachment, file: attachment_fixture('attachment.jpg'))
|
2021-10-06 13:49:32 +00:00
|
|
|
expect(media.valid?).to be true
|
|
|
|
end
|
|
|
|
end
|
2024-07-18 15:23:46 +00:00
|
|
|
|
2024-08-09 12:48:34 +00:00
|
|
|
describe 'cache deletion hooks' do
|
|
|
|
let(:media) { Fabricate(:media_attachment) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(Rails.configuration.x).to receive(:cache_buster_enabled).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'queues CacheBusterWorker jobs' do
|
|
|
|
original_path = media.file.path(:original)
|
|
|
|
small_path = media.file.path(:small)
|
|
|
|
|
|
|
|
expect { media.destroy }
|
|
|
|
.to enqueue_sidekiq_job(CacheBusterWorker).with(original_path)
|
|
|
|
.and enqueue_sidekiq_job(CacheBusterWorker).with(small_path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2024-07-18 15:23:46 +00:00
|
|
|
private
|
|
|
|
|
|
|
|
def media_metadata
|
|
|
|
media.file.meta.deep_symbolize_keys
|
|
|
|
end
|
2016-09-05 15:46:36 +00:00
|
|
|
end
|