2023-02-22 00:55:31 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-03-07 11:42:33 +00:00
|
|
|
require 'rails_helper'
|
|
|
|
|
2023-05-04 03:49:53 +00:00
|
|
|
RSpec.describe Api::V1::StatusesController do
|
2016-09-04 23:26:08 +00:00
|
|
|
render_views
|
|
|
|
|
2022-01-27 23:46:42 +00:00
|
|
|
let(:user) { Fabricate(:user) }
|
2017-01-15 13:01:33 +00:00
|
|
|
let(:app) { Fabricate(:application, name: 'Test app', website: 'http://testapp.com') }
|
2018-07-05 16:31:35 +00:00
|
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, application: app, scopes: scopes) }
|
2016-03-20 12:03:06 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
context 'with an oauth token' do
|
|
|
|
before do
|
|
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
|
|
end
|
2016-03-20 12:03:06 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
describe 'GET #show' do
|
2018-07-05 16:31:35 +00:00
|
|
|
let(:scopes) { 'read:statuses' }
|
2017-04-18 19:58:57 +00:00
|
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
2016-03-20 12:03:06 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
it 'returns http success' do
|
|
|
|
get :show, params: { id: status.id }
|
2018-04-21 19:35:07 +00:00
|
|
|
expect(response).to have_http_status(200)
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
Revamp post filtering system (#18058)
* Add model for custom filter keywords
* Use CustomFilterKeyword internally
Does not change the API
* Fix /filters/edit and /filters/new
* Add migration tests
* Remove whole_word column from custom_filters (covered by custom_filter_keywords)
* Redesign /filters
Instead of a list, present a card that displays more information and handles
multiple keywords per filter.
* Redesign /filters/new and /filters/edit to add and remove keywords
This adds a new gem dependency: cocoon, as well as a npm dependency:
cocoon-js-vanilla. Those are used to easily populate and remove form fields
from the user interface when manipulating multiple keyword filters at once.
* Add /api/v2/filters to edit filter with multiple keywords
Entities:
- `Filter`: `id`, `title`, `filter_action` (either `hide` or `warn`), `context`
`keywords`
- `FilterKeyword`: `id`, `keyword`, `whole_word`
API endpoits:
- `GET /api/v2/filters` to list filters (including keywords)
- `POST /api/v2/filters` to create a new filter
`keywords_attributes` can also be passed to create keywords in one request
- `GET /api/v2/filters/:id` to read a particular filter
- `PUT /api/v2/filters/:id` to update a new filter
`keywords_attributes` can also be passed to edit, delete or add keywords in
one request
- `DELETE /api/v2/filters/:id` to delete a particular filter
- `GET /api/v2/filters/:id/keywords` to list keywords for a filter
- `POST /api/v2/filters/:filter_id/keywords/:id` to add a new keyword to a
filter
- `GET /api/v2/filter_keywords/:id` to read a particular keyword
- `PUT /api/v2/filter_keywords/:id` to edit a particular keyword
- `DELETE /api/v2/filter_keywords/:id` to delete a particular keyword
* Change from `irreversible` boolean to `action` enum
* Remove irrelevent `irreversible_must_be_within_context` check
* Fix /filters/new and /filters/edit with update for filter_action
* Fix Rubocop/Codeclimate complaining about task names
* Refactor FeedManager#phrase_filtered?
This moves regexp building and filter caching to the `CustomFilter` class.
This does not change the functional behavior yet, but this changes how the
cache is built, doing per-custom_filter regexps so that filters can be matched
independently, while still offering caching.
* Perform server-side filtering and output result in REST API
* Fix numerous filters_changed events being sent when editing multiple keywords at once
* Add some tests
* Use the new API in the WebUI
- use client-side logic for filters we have fetched rules for.
This is so that filter changes can be retroactively applied without
reloading the UI.
- use server-side logic for filters we haven't fetched rules for yet
(e.g. network error, or initial timeline loading)
* Minor optimizations and refactoring
* Perform server-side filtering on the streaming server
* Change the wording of filter action labels
* Fix issues pointed out by linter
* Change design of “Show anyway” link in accordence to review comments
* Drop “irreversible” filtering behavior
* Move /api/v2/filter_keywords to /api/v1/filters/keywords
* Rename `filter_results` attribute to `filtered`
* Rename REST::LegacyFilterSerializer to REST::V1::FilterSerializer
* Fix systemChannelId value in streaming server
* Simplify code by removing client-side filtering code
The simplifcation comes at a cost though: filters aren't retroactively
applied anymore.
2022-06-28 07:42:13 +00:00
|
|
|
|
|
|
|
context 'when post includes filtered terms' do
|
|
|
|
let(:status) { Fabricate(:status, text: 'this toot is about that banned word') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
user.account.custom_filters.create!(phrase: 'filter1', context: %w(home), action: :hide, keywords_attributes: [{ keyword: 'banned' }, { keyword: 'irrelevant' }])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http success' do
|
|
|
|
get :show, params: { id: status.id }
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns filter information' do
|
|
|
|
get :show, params: { id: status.id }
|
|
|
|
json = body_as_json
|
|
|
|
expect(json[:filtered][0]).to include({
|
|
|
|
filter: a_hash_including({
|
|
|
|
id: user.account.custom_filters.first.id.to_s,
|
|
|
|
title: 'filter1',
|
|
|
|
filter_action: 'hide',
|
|
|
|
}),
|
|
|
|
keyword_matches: ['banned'],
|
|
|
|
})
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-08-25 02:27:47 +00:00
|
|
|
context 'when post is explicitly filtered' do
|
|
|
|
let(:status) { Fabricate(:status, text: 'hello world') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
filter = user.account.custom_filters.create!(phrase: 'filter1', context: %w(home), action: :hide)
|
|
|
|
filter.statuses.create!(status_id: status.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http success' do
|
|
|
|
get :show, params: { id: status.id }
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns filter information' do
|
|
|
|
get :show, params: { id: status.id }
|
|
|
|
json = body_as_json
|
|
|
|
expect(json[:filtered][0]).to include({
|
|
|
|
filter: a_hash_including({
|
|
|
|
id: user.account.custom_filters.first.id.to_s,
|
|
|
|
title: 'filter1',
|
|
|
|
filter_action: 'hide',
|
|
|
|
}),
|
|
|
|
status_matches: [status.id.to_s],
|
|
|
|
})
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
Revamp post filtering system (#18058)
* Add model for custom filter keywords
* Use CustomFilterKeyword internally
Does not change the API
* Fix /filters/edit and /filters/new
* Add migration tests
* Remove whole_word column from custom_filters (covered by custom_filter_keywords)
* Redesign /filters
Instead of a list, present a card that displays more information and handles
multiple keywords per filter.
* Redesign /filters/new and /filters/edit to add and remove keywords
This adds a new gem dependency: cocoon, as well as a npm dependency:
cocoon-js-vanilla. Those are used to easily populate and remove form fields
from the user interface when manipulating multiple keyword filters at once.
* Add /api/v2/filters to edit filter with multiple keywords
Entities:
- `Filter`: `id`, `title`, `filter_action` (either `hide` or `warn`), `context`
`keywords`
- `FilterKeyword`: `id`, `keyword`, `whole_word`
API endpoits:
- `GET /api/v2/filters` to list filters (including keywords)
- `POST /api/v2/filters` to create a new filter
`keywords_attributes` can also be passed to create keywords in one request
- `GET /api/v2/filters/:id` to read a particular filter
- `PUT /api/v2/filters/:id` to update a new filter
`keywords_attributes` can also be passed to edit, delete or add keywords in
one request
- `DELETE /api/v2/filters/:id` to delete a particular filter
- `GET /api/v2/filters/:id/keywords` to list keywords for a filter
- `POST /api/v2/filters/:filter_id/keywords/:id` to add a new keyword to a
filter
- `GET /api/v2/filter_keywords/:id` to read a particular keyword
- `PUT /api/v2/filter_keywords/:id` to edit a particular keyword
- `DELETE /api/v2/filter_keywords/:id` to delete a particular keyword
* Change from `irreversible` boolean to `action` enum
* Remove irrelevent `irreversible_must_be_within_context` check
* Fix /filters/new and /filters/edit with update for filter_action
* Fix Rubocop/Codeclimate complaining about task names
* Refactor FeedManager#phrase_filtered?
This moves regexp building and filter caching to the `CustomFilter` class.
This does not change the functional behavior yet, but this changes how the
cache is built, doing per-custom_filter regexps so that filters can be matched
independently, while still offering caching.
* Perform server-side filtering and output result in REST API
* Fix numerous filters_changed events being sent when editing multiple keywords at once
* Add some tests
* Use the new API in the WebUI
- use client-side logic for filters we have fetched rules for.
This is so that filter changes can be retroactively applied without
reloading the UI.
- use server-side logic for filters we haven't fetched rules for yet
(e.g. network error, or initial timeline loading)
* Minor optimizations and refactoring
* Perform server-side filtering on the streaming server
* Change the wording of filter action labels
* Fix issues pointed out by linter
* Change design of “Show anyway” link in accordence to review comments
* Drop “irreversible” filtering behavior
* Move /api/v2/filter_keywords to /api/v1/filters/keywords
* Rename `filter_results` attribute to `filtered`
* Rename REST::LegacyFilterSerializer to REST::V1::FilterSerializer
* Fix systemChannelId value in streaming server
* Simplify code by removing client-side filtering code
The simplifcation comes at a cost though: filters aren't retroactively
applied anymore.
2022-06-28 07:42:13 +00:00
|
|
|
context 'when reblog includes filtered terms' do
|
|
|
|
let(:status) { Fabricate(:status, reblog: Fabricate(:status, text: 'this toot is about that banned word')) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
user.account.custom_filters.create!(phrase: 'filter1', context: %w(home), action: :hide, keywords_attributes: [{ keyword: 'banned' }, { keyword: 'irrelevant' }])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http success' do
|
|
|
|
get :show, params: { id: status.id }
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns filter information' do
|
|
|
|
get :show, params: { id: status.id }
|
|
|
|
json = body_as_json
|
|
|
|
expect(json[:reblog][:filtered][0]).to include({
|
|
|
|
filter: a_hash_including({
|
|
|
|
id: user.account.custom_filters.first.id.to_s,
|
|
|
|
title: 'filter1',
|
|
|
|
filter_action: 'hide',
|
|
|
|
}),
|
|
|
|
keyword_matches: ['banned'],
|
|
|
|
})
|
|
|
|
end
|
|
|
|
end
|
2016-03-20 12:03:06 +00:00
|
|
|
end
|
2016-03-07 11:42:33 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
describe 'GET #context' do
|
2018-07-05 16:31:35 +00:00
|
|
|
let(:scopes) { 'read:statuses' }
|
2017-04-18 19:58:57 +00:00
|
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
2016-09-15 22:27:09 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
before do
|
|
|
|
Fabricate(:status, account: user.account, thread: status)
|
|
|
|
end
|
2016-09-15 22:27:09 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
it 'returns http success' do
|
|
|
|
get :context, params: { id: status.id }
|
2018-04-21 19:35:07 +00:00
|
|
|
expect(response).to have_http_status(200)
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
2016-09-15 22:27:09 +00:00
|
|
|
end
|
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
describe 'POST #create' do
|
2018-07-05 16:31:35 +00:00
|
|
|
let(:scopes) { 'write:statuses' }
|
|
|
|
|
2023-06-06 13:51:42 +00:00
|
|
|
context 'with a basic status body' do
|
2020-03-08 14:17:39 +00:00
|
|
|
before do
|
|
|
|
post :create, params: { status: 'Hello world' }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http success' do
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns rate limit headers' do
|
|
|
|
expect(response.headers['X-RateLimit-Limit']).to eq RateLimiter::FAMILIES[:statuses][:limit].to_s
|
|
|
|
expect(response.headers['X-RateLimit-Remaining']).to eq (RateLimiter::FAMILIES[:statuses][:limit] - 1).to_s
|
|
|
|
end
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
2016-09-04 23:26:08 +00:00
|
|
|
|
2023-02-13 15:36:29 +00:00
|
|
|
context 'with a safeguard' do
|
|
|
|
let!(:alice) { Fabricate(:account, username: 'alice') }
|
|
|
|
let!(:bob) { Fabricate(:account, username: 'bob') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
post :create, params: { status: '@alice hm, @bob is really annoying lately', allowed_mentions: [alice.id] }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http unprocessable entity' do
|
|
|
|
expect(response).to have_http_status(422)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns serialized extra accounts in body' do
|
|
|
|
expect(body_as_json[:unexpected_accounts].map { |a| a.slice(:id, :acct) }).to eq [{ id: bob.id.to_s, acct: bob.acct }]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-03-08 14:17:39 +00:00
|
|
|
context 'with missing parameters' do
|
|
|
|
before do
|
|
|
|
post :create, params: {}
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http unprocessable entity' do
|
|
|
|
expect(response).to have_http_status(422)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns rate limit headers' do
|
|
|
|
expect(response.headers['X-RateLimit-Limit']).to eq RateLimiter::FAMILIES[:statuses][:limit].to_s
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when exceeding rate limit' do
|
|
|
|
before do
|
|
|
|
rate_limiter = RateLimiter.new(user.account, family: :statuses)
|
|
|
|
300.times { rate_limiter.record! }
|
|
|
|
post :create, params: { status: 'Hello world' }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http too many requests' do
|
|
|
|
expect(response).to have_http_status(429)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns rate limit headers' do
|
|
|
|
expect(response.headers['X-RateLimit-Limit']).to eq RateLimiter::FAMILIES[:statuses][:limit].to_s
|
|
|
|
expect(response.headers['X-RateLimit-Remaining']).to eq '0'
|
|
|
|
end
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
2024-07-03 07:15:47 +00:00
|
|
|
|
|
|
|
context 'with missing thread' do
|
|
|
|
subject { post :create, params: params }
|
|
|
|
|
|
|
|
let(:params) { { status: 'Hello world', in_reply_to_id: 0 } }
|
|
|
|
|
|
|
|
it 'returns http not found' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_http_status(404)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when scheduling a status' do
|
|
|
|
subject { post :create, params: params }
|
|
|
|
|
|
|
|
let(:params) { { status: 'Hello world', scheduled_at: 10.minutes.from_now } }
|
|
|
|
let(:account) { user.account }
|
|
|
|
|
|
|
|
it 'returns HTTP 200' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates a scheduled status' do
|
|
|
|
expect { subject }.to change { account.scheduled_statuses.count }.from(0).to(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the scheduling time is less than 5 minutes' do
|
|
|
|
let(:params) { { status: 'Hello world', scheduled_at: 4.minutes.from_now } }
|
|
|
|
|
|
|
|
it 'does not create a scheduled status', :aggregate_failures do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_http_status(422)
|
|
|
|
expect(account.scheduled_statuses).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-09-04 23:26:08 +00:00
|
|
|
end
|
2016-03-19 11:13:47 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
describe 'DELETE #destroy' do
|
2018-07-05 16:31:35 +00:00
|
|
|
let(:scopes) { 'write:statuses' }
|
2017-04-18 19:58:57 +00:00
|
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
2016-09-26 21:55:21 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
before do
|
|
|
|
post :destroy, params: { id: status.id }
|
|
|
|
end
|
2016-09-26 21:55:21 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
it 'returns http success' do
|
2018-04-21 19:35:07 +00:00
|
|
|
expect(response).to have_http_status(200)
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
2016-09-26 21:55:21 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
it 'removes the status' do
|
2023-02-17 12:45:27 +00:00
|
|
|
expect(Status.find_by(id: status.id)).to be_nil
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
2016-09-26 21:55:21 +00:00
|
|
|
end
|
2022-02-09 23:15:30 +00:00
|
|
|
|
|
|
|
describe 'PUT #update' do
|
|
|
|
let(:scopes) { 'write:statuses' }
|
|
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
put :update, params: { id: status.id, status: 'I am updated' }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http success' do
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates the status' do
|
|
|
|
expect(status.reload.text).to eq 'I am updated'
|
|
|
|
end
|
|
|
|
end
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
2016-09-26 21:55:21 +00:00
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
context 'without an oauth token' do
|
|
|
|
before do
|
2023-02-20 01:32:10 +00:00
|
|
|
allow(controller).to receive(:doorkeeper_token).and_return(nil)
|
2016-09-26 21:55:21 +00:00
|
|
|
end
|
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
context 'with a private status' do
|
|
|
|
let(:status) { Fabricate(:status, account: user.account, visibility: :private) }
|
|
|
|
|
|
|
|
describe 'GET #show' do
|
2022-03-06 21:51:40 +00:00
|
|
|
it 'returns http unauthorized' do
|
2017-04-18 19:58:57 +00:00
|
|
|
get :show, params: { id: status.id }
|
2018-04-21 19:35:07 +00:00
|
|
|
expect(response).to have_http_status(404)
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #context' do
|
|
|
|
before do
|
|
|
|
Fabricate(:status, account: user.account, thread: status)
|
|
|
|
end
|
|
|
|
|
2022-03-06 21:51:40 +00:00
|
|
|
it 'returns http unauthorized' do
|
2017-04-18 19:58:57 +00:00
|
|
|
get :context, params: { id: status.id }
|
2018-04-21 19:35:07 +00:00
|
|
|
expect(response).to have_http_status(404)
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
|
|
|
end
|
2016-09-26 21:55:21 +00:00
|
|
|
end
|
|
|
|
|
2017-04-18 19:58:57 +00:00
|
|
|
context 'with a public status' do
|
|
|
|
let(:status) { Fabricate(:status, account: user.account, visibility: :public) }
|
|
|
|
|
|
|
|
describe 'GET #show' do
|
|
|
|
it 'returns http success' do
|
|
|
|
get :show, params: { id: status.id }
|
2018-04-21 19:35:07 +00:00
|
|
|
expect(response).to have_http_status(200)
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #context' do
|
|
|
|
before do
|
|
|
|
Fabricate(:status, account: user.account, thread: status)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http success' do
|
|
|
|
get :context, params: { id: status.id }
|
2018-04-21 19:35:07 +00:00
|
|
|
expect(response).to have_http_status(200)
|
2017-04-18 19:58:57 +00:00
|
|
|
end
|
|
|
|
end
|
2016-09-26 21:55:21 +00:00
|
|
|
end
|
|
|
|
end
|
2016-03-07 11:42:33 +00:00
|
|
|
end
|