mirror of
https://github.com/LemmyNet/lemmy.git
synced 2024-12-14 14:29:56 +00:00
ad90cd77f9
* add private visibility * filter private communities in post_view.rs * also filter in comment_view * community follower state * remove unused method * sql fmt * add CommunityFollower.approved_by * implement api endpoints * api changes * only admins can create private community for now * add local api tests * fix api tests * follow remote private community * use authorized fetch for content in private community * federate community visibility * dont mark content in private community as public * expose ApprovalRequired in api * also check content fetchable for outbox/featured * address private community content to followers * implement reject activity * fix tests * add files * remove local api tests * dont use delay * is_new_instance * single query for is_new_instance * return subscribed type for pending follow * working * need to catch errors in waitUntil * clippy * fix query * lint for unused async * diesel.toml comment * add comment * avoid db reads * rename approved_by to approver_id * add helper * form init * list pending follows should return items for all communities * clippy * ci * fix down migration * fix api tests * references * rename * run git diff * ci * fix schema check * fix joins * ci * ci * skip_serializing_none * fix test --------- Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
215 lines
6.8 KiB
TypeScript
215 lines
6.8 KiB
TypeScript
jest.setTimeout(120000);
|
|
|
|
import { FollowCommunity } from "lemmy-js-client";
|
|
import {
|
|
alpha,
|
|
setupLogins,
|
|
createCommunity,
|
|
unfollows,
|
|
registerUser,
|
|
listCommunityPendingFollows,
|
|
getCommunity,
|
|
getCommunityPendingFollowsCount,
|
|
approveCommunityPendingFollow,
|
|
randomString,
|
|
createPost,
|
|
createComment,
|
|
beta,
|
|
resolveCommunity,
|
|
betaUrl,
|
|
resolvePost,
|
|
resolveComment,
|
|
likeComment,
|
|
waitUntil,
|
|
} from "./shared";
|
|
|
|
beforeAll(setupLogins);
|
|
afterAll(unfollows);
|
|
|
|
test("Follow a private community", async () => {
|
|
// create private community
|
|
const community = await createCommunity(alpha, randomString(10), "Private");
|
|
expect(community.community_view.community.visibility).toBe("Private");
|
|
const alphaCommunityId = community.community_view.community.id;
|
|
|
|
// No pending follows yet
|
|
const pendingFollows0 = await listCommunityPendingFollows(alpha);
|
|
expect(pendingFollows0.items.length).toBe(0);
|
|
const pendingFollowsCount0 = await getCommunityPendingFollowsCount(
|
|
alpha,
|
|
alphaCommunityId,
|
|
);
|
|
expect(pendingFollowsCount0.count).toBe(0);
|
|
|
|
// follow as new user
|
|
const user = await registerUser(beta, betaUrl);
|
|
const betaCommunity = (
|
|
await resolveCommunity(user, community.community_view.community.actor_id)
|
|
).community;
|
|
expect(betaCommunity).toBeDefined();
|
|
const betaCommunityId = betaCommunity!.community.id;
|
|
const follow_form: FollowCommunity = {
|
|
community_id: betaCommunityId,
|
|
follow: true,
|
|
};
|
|
await user.followCommunity(follow_form);
|
|
|
|
// Follow listed as pending
|
|
const follow1 = await getCommunity(user, betaCommunityId);
|
|
expect(follow1.community_view.subscribed).toBe("ApprovalRequired");
|
|
|
|
// Wait for follow to federate, shown as pending
|
|
let pendingFollows1 = await waitUntil(
|
|
() => listCommunityPendingFollows(alpha),
|
|
f => f.items.length == 1,
|
|
);
|
|
expect(pendingFollows1.items[0].is_new_instance).toBe(true);
|
|
const pendingFollowsCount1 = await getCommunityPendingFollowsCount(
|
|
alpha,
|
|
alphaCommunityId,
|
|
);
|
|
expect(pendingFollowsCount1.count).toBe(1);
|
|
|
|
// user still sees approval required at this point
|
|
const betaCommunity2 = await getCommunity(user, betaCommunityId);
|
|
expect(betaCommunity2.community_view.subscribed).toBe("ApprovalRequired");
|
|
|
|
// Approve the follow
|
|
const approve = await approveCommunityPendingFollow(
|
|
alpha,
|
|
alphaCommunityId,
|
|
pendingFollows1.items[0].person.id,
|
|
);
|
|
expect(approve.success).toBe(true);
|
|
|
|
// Follow is confirmed
|
|
await waitUntil(
|
|
() => getCommunity(user, betaCommunityId),
|
|
c => c.community_view.subscribed == "Subscribed",
|
|
);
|
|
const pendingFollows2 = await listCommunityPendingFollows(alpha);
|
|
expect(pendingFollows2.items.length).toBe(0);
|
|
const pendingFollowsCount2 = await getCommunityPendingFollowsCount(
|
|
alpha,
|
|
alphaCommunityId,
|
|
);
|
|
expect(pendingFollowsCount2.count).toBe(0);
|
|
|
|
// follow with another user from that instance, is_new_instance should be false now
|
|
const user2 = await registerUser(beta, betaUrl);
|
|
await user2.followCommunity(follow_form);
|
|
let pendingFollows3 = await waitUntil(
|
|
() => listCommunityPendingFollows(alpha),
|
|
f => f.items.length == 1,
|
|
);
|
|
expect(pendingFollows3.items[0].is_new_instance).toBe(false);
|
|
|
|
// cleanup pending follow
|
|
const approve2 = await approveCommunityPendingFollow(
|
|
alpha,
|
|
alphaCommunityId,
|
|
pendingFollows3.items[0].person.id,
|
|
);
|
|
expect(approve2.success).toBe(true);
|
|
});
|
|
|
|
test("Only followers can view and interact with private community content", async () => {
|
|
// create private community
|
|
const community = await createCommunity(alpha, randomString(10), "Private");
|
|
expect(community.community_view.community.visibility).toBe("Private");
|
|
const alphaCommunityId = community.community_view.community.id;
|
|
|
|
// create post and comment
|
|
const post0 = await createPost(alpha, alphaCommunityId);
|
|
const post_id = post0.post_view.post.id;
|
|
expect(post_id).toBeDefined();
|
|
const comment = await createComment(alpha, post_id);
|
|
const comment_id = comment.comment_view.comment.id;
|
|
expect(comment_id).toBeDefined();
|
|
|
|
// user is not following the community and cannot view nor create posts
|
|
const user = await registerUser(beta, betaUrl);
|
|
const betaCommunity = (
|
|
await resolveCommunity(user, community.community_view.community.actor_id)
|
|
).community!.community;
|
|
await expect(resolvePost(user, post0.post_view.post)).rejects.toStrictEqual(
|
|
Error("not_found"),
|
|
);
|
|
await expect(
|
|
resolveComment(user, comment.comment_view.comment),
|
|
).rejects.toStrictEqual(Error("not_found"));
|
|
await expect(createPost(user, betaCommunity.id)).rejects.toStrictEqual(
|
|
Error("not_found"),
|
|
);
|
|
|
|
// follow the community and approve
|
|
const follow_form: FollowCommunity = {
|
|
community_id: betaCommunity.id,
|
|
follow: true,
|
|
};
|
|
await user.followCommunity(follow_form);
|
|
const pendingFollows1 = await waitUntil(
|
|
() => listCommunityPendingFollows(alpha),
|
|
f => f.items.length == 1,
|
|
);
|
|
const approve = await approveCommunityPendingFollow(
|
|
alpha,
|
|
alphaCommunityId,
|
|
pendingFollows1.items[0].person.id,
|
|
);
|
|
expect(approve.success).toBe(true);
|
|
|
|
// now user can fetch posts and comments in community (using signed fetch), and create posts
|
|
await waitUntil(
|
|
() => resolvePost(user, post0.post_view.post),
|
|
p => p?.post?.post.id != undefined,
|
|
);
|
|
const resolvedComment = (
|
|
await resolveComment(user, comment.comment_view.comment)
|
|
).comment;
|
|
expect(resolvedComment?.comment.id).toBeDefined();
|
|
|
|
const post1 = await createPost(user, betaCommunity.id);
|
|
expect(post1.post_view).toBeDefined();
|
|
const like = await likeComment(user, 1, resolvedComment!.comment);
|
|
expect(like.comment_view.my_vote).toBe(1);
|
|
});
|
|
|
|
test("Reject follower", async () => {
|
|
// create private community
|
|
const community = await createCommunity(alpha, randomString(10), "Private");
|
|
expect(community.community_view.community.visibility).toBe("Private");
|
|
const alphaCommunityId = community.community_view.community.id;
|
|
|
|
// user is not following the community and cannot view nor create posts
|
|
const user = await registerUser(beta, betaUrl);
|
|
const betaCommunity1 = (
|
|
await resolveCommunity(user, community.community_view.community.actor_id)
|
|
).community!.community;
|
|
|
|
// follow the community and reject
|
|
const follow_form: FollowCommunity = {
|
|
community_id: betaCommunity1.id,
|
|
follow: true,
|
|
};
|
|
const follow = await user.followCommunity(follow_form);
|
|
expect(follow.community_view.subscribed).toBe("ApprovalRequired");
|
|
|
|
const pendingFollows1 = await waitUntil(
|
|
() => listCommunityPendingFollows(alpha),
|
|
f => f.items.length == 1,
|
|
);
|
|
const approve = await approveCommunityPendingFollow(
|
|
alpha,
|
|
alphaCommunityId,
|
|
pendingFollows1.items[0].person.id,
|
|
false,
|
|
);
|
|
expect(approve.success).toBe(true);
|
|
|
|
await waitUntil(
|
|
() => getCommunity(user, betaCommunity1.id),
|
|
c => c.community_view.subscribed == "NotSubscribed",
|
|
);
|
|
});
|