From 105dfc93f1fa63f7ea1bdfff1fad9eb799aba064 Mon Sep 17 00:00:00 2001
From: Felix Ableitner <me@nutomic.com>
Date: Fri, 5 Feb 2021 14:23:57 +0100
Subject: [PATCH] Make apub extension fields optional (ref #1220)

---
 crates/apub/src/extensions/group_extensions.rs |  8 ++++----
 crates/apub/src/extensions/page_extension.rs   |  6 +++---
 crates/apub/src/objects/community.rs           | 10 ++++++++--
 crates/apub/src/objects/post.rs                | 12 ++++++------
 4 files changed, 21 insertions(+), 15 deletions(-)

diff --git a/crates/apub/src/extensions/group_extensions.rs b/crates/apub/src/extensions/group_extensions.rs
index b9790b231..891cb26c7 100644
--- a/crates/apub/src/extensions/group_extensions.rs
+++ b/crates/apub/src/extensions/group_extensions.rs
@@ -11,8 +11,8 @@ use serde::{Deserialize, Serialize};
 #[derive(Clone, Debug, Default, Deserialize, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct GroupExtension {
-  pub category: GroupCategory,
-  pub sensitive: bool,
+  pub category: Option<GroupCategory>,
+  pub sensitive: Option<bool>,
 }
 
 #[derive(Clone, Debug, Default, Deserialize, Serialize)]
@@ -35,8 +35,8 @@ impl GroupExtension {
       name: category.name,
     };
     Ok(GroupExtension {
-      category: group_category,
-      sensitive,
+      category: Some(group_category),
+      sensitive: Some(sensitive),
     })
   }
 }
diff --git a/crates/apub/src/extensions/page_extension.rs b/crates/apub/src/extensions/page_extension.rs
index 8ed12a0c7..752fa2b4b 100644
--- a/crates/apub/src/extensions/page_extension.rs
+++ b/crates/apub/src/extensions/page_extension.rs
@@ -8,9 +8,9 @@ use serde::{Deserialize, Serialize};
 #[derive(Clone, Debug, Default, Deserialize, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct PageExtension {
-  pub comments_enabled: bool,
-  pub sensitive: bool,
-  pub stickied: bool,
+  pub comments_enabled: Option<bool>,
+  pub sensitive: Option<bool>,
+  pub stickied: Option<bool>,
 }
 
 impl<U> UnparsedExtension<U> for PageExtension
diff --git a/crates/apub/src/objects/community.rs b/crates/apub/src/objects/community.rs
index af947e047..c6189f9c7 100644
--- a/crates/apub/src/objects/community.rs
+++ b/crates/apub/src/objects/community.rs
@@ -207,13 +207,19 @@ impl FromApubToForm<GroupExt> for CommunityForm {
       name,
       title,
       description,
-      category_id: group.ext_one.category.identifier.parse::<i32>()?,
+      category_id: group
+        .ext_one
+        .category
+        .clone()
+        .map(|c| c.identifier.parse::<i32>().ok())
+        .flatten()
+        .unwrap_or(1),
       creator_id: creator.id,
       removed: None,
       published: group.inner.published().map(|u| u.to_owned().naive_local()),
       updated: group.inner.updated().map(|u| u.to_owned().naive_local()),
       deleted: None,
-      nsfw: group.ext_one.sensitive,
+      nsfw: group.ext_one.sensitive.unwrap_or(false),
       actor_id: Some(check_object_domain(group, expected_domain)?),
       local: false,
       private_key: None,
diff --git a/crates/apub/src/objects/post.rs b/crates/apub/src/objects/post.rs
index 31f848a4d..1420e145d 100644
--- a/crates/apub/src/objects/post.rs
+++ b/crates/apub/src/objects/post.rs
@@ -85,9 +85,9 @@ impl ToApub for Post {
     }
 
     let ext = PageExtension {
-      comments_enabled: !self.locked,
-      sensitive: self.nsfw,
-      stickied: self.stickied,
+      comments_enabled: Some(!self.locked),
+      sensitive: Some(self.nsfw),
+      stickied: Some(self.stickied),
     };
     Ok(Ext1::new(page, ext))
   }
@@ -198,7 +198,7 @@ impl FromApubToForm<PageExt> for PostForm {
       creator_id: creator.id,
       community_id: community.id,
       removed: None,
-      locked: Some(!ext.comments_enabled),
+      locked: ext.comments_enabled.map(|e| !e),
       published: page
         .inner
         .published()
@@ -210,8 +210,8 @@ impl FromApubToForm<PageExt> for PostForm {
         .as_ref()
         .map(|u| u.to_owned().naive_local()),
       deleted: None,
-      nsfw: ext.sensitive,
-      stickied: Some(ext.stickied),
+      nsfw: ext.sensitive.unwrap_or(false),
+      stickied: ext.stickied.or(Some(false)),
       embed_title: iframely_title,
       embed_description: iframely_description,
       embed_html: iframely_html,