From c93bde9799773a79ce9e1b817acc6ffa59ac49f4 Mon Sep 17 00:00:00 2001
From: Lukas Trombach <TrombachL@gmail.com>
Date: Wed, 30 Aug 2023 11:08:44 +1200
Subject: [PATCH] replace `expect` with `ErrorUnauthorized` (#3915)

Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
---
 crates/routes/src/images.rs | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/crates/routes/src/images.rs b/crates/routes/src/images.rs
index b79a38ffd..c81a56602 100644
--- a/crates/routes/src/images.rs
+++ b/crates/routes/src/images.rs
@@ -92,9 +92,9 @@ async fn upload(
   context: web::Data<LemmyContext>,
 ) -> Result<HttpResponse, Error> {
   // TODO: check rate limit here
-  let jwt = req
-    .cookie("jwt")
-    .expect("No auth header for picture upload");
+  let jwt = req.cookie("jwt").ok_or(error::ErrorUnauthorized(
+    "No auth header for picture upload",
+  ))?;
 
   if Claims::decode(jwt.value(), &context.secret().jwt_secret).is_err() {
     return Ok(HttpResponse::Unauthorized().finish());
@@ -133,9 +133,9 @@ async fn full_res(
     .await
     .map_err(error::ErrorBadRequest)?;
   if local_site.private_instance {
-    let jwt = req
-      .cookie("jwt")
-      .expect("No auth header for picture access");
+    let jwt = req.cookie("jwt").ok_or(error::ErrorUnauthorized(
+      "No auth header for picture access",
+    ))?;
     if local_user_view_from_jwt(jwt.value(), &context)
       .await
       .is_err()