fedi/lemmy
1
0
Fork 0
mirror of https://github.com/LemmyNet/lemmy.git synced 2024-11-25 07:36:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure comments are sorted by hot_rank, then score. (#3667)

Browse source
This commit is contained in:
Dessalines 2023-07-21 05:44:47 -04:00 committed by GitHub
parent ccc122100e
commit 623d81139e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/db_views/src/comment_view.rs
View file

@ -362,12 +362,10 @@ impl<'a> CommentQuery<'a> {
query = match self.sort.unwrap_or(CommentSortType::Hot) {
CommentSortType::Hot => query
.then_order_by(comment_aggregates::hot_rank.desc())
.then_order_by(comment_aggregates::published.desc()),
CommentSortType::Top => query
.order_by(comment_aggregates::score.desc())
.then_order_by(comment_aggregates::published.desc()),
.then_order_by(comment_aggregates::score.desc()),
CommentSortType::New => query.then_order_by(comment::published.desc()),
CommentSortType::Old => query.then_order_by(comment::published.asc()),
CommentSortType::Top => query.order_by(comment_aggregates::score.desc()),
};
// Note: deleted and removed comments are done on the front side

4
migrations/2023-07-19-163511_comment_sort_hot_rank_then_score/down.sql Normal file
View file

@ -0,0 +1,4 @@
drop index idx_comment_aggregates_hot, idx_comment_aggregates_score;
create index idx_comment_aggregates_hot on comment_aggregates (hot_rank desc, published desc);
create index idx_comment_aggregates_score on comment_aggregates (score desc, published desc);

10
migrations/2023-07-19-163511_comment_sort_hot_rank_then_score/up.sql Normal file
View file

@ -0,0 +1,10 @@
-- Alter the comment_aggregates hot sort to sort by score after hot_rank.
-- Reason being, is that hot_ranks go to zero after a few days,
-- and then comments should be sorted by score, not published.
drop index idx_comment_aggregates_hot, idx_comment_aggregates_score;
create index idx_comment_aggregates_hot on comment_aggregates (hot_rank desc, score desc);
-- Remove published from this sort, its pointless
create index idx_comment_aggregates_score on comment_aggregates (score desc);