From fed9bddbb25216acd608a6231de4d28cb8be4a38 Mon Sep 17 00:00:00 2001
From: Dessalines <tyhou13@gmx.com>
Date: Wed, 5 May 2021 10:57:41 -0400
Subject: [PATCH] Fix non-local community and person links. Fixes #290

---
 src/shared/components/community-link.tsx | 21 +++++++++++--
 src/shared/components/person-listing.tsx | 39 ++++++++++++++++++------
 2 files changed, 48 insertions(+), 12 deletions(-)

diff --git a/src/shared/components/community-link.tsx b/src/shared/components/community-link.tsx
index 5a85a127..c12f570b 100644
--- a/src/shared/components/community-link.tsx
+++ b/src/shared/components/community-link.tsx
@@ -36,17 +36,34 @@ export class CommunityLink extends Component<CommunityLinkProps, any> {
 
     let apubName = `!${name_}`;
     let displayName = this.props.useApubName ? apubName : title;
-    return (
+    return !this.props.realLink ? (
       <Link
         title={apubName}
         className={`${this.props.muted ? "text-muted" : ""}`}
         to={link}
       >
+        {this.avatarAndName(displayName)}
+      </Link>
+    ) : (
+      <a
+        title={apubName}
+        className={`${this.props.muted ? "text-muted" : ""}`}
+        href={link}
+      >
+        {this.avatarAndName(displayName)}
+      </a>
+    );
+  }
+
+  avatarAndName(displayName: string) {
+    let community = this.props.community;
+    return (
+      <>
         {!this.props.hideAvatar && community.icon && showAvatars() && (
           <PictrsImage src={community.icon} icon />
         )}
         <span>{displayName}</span>
-      </Link>
+      </>
     );
   }
 }
diff --git a/src/shared/components/person-listing.tsx b/src/shared/components/person-listing.tsx
index fda388df..17265760 100644
--- a/src/shared/components/person-listing.tsx
+++ b/src/shared/components/person-listing.tsx
@@ -44,19 +44,38 @@ export class PersonListing extends Component<PersonListingProps, any> {
 
     return (
       <>
-        <Link
-          title={apubName}
-          className={this.props.muted ? "text-muted" : "text-info"}
-          to={link}
-        >
-          {!this.props.hideAvatar && person.avatar && showAvatars() && (
-            <PictrsImage src={person.avatar} icon />
-          )}
-          <span>{displayName}</span>
-        </Link>
+        {!this.props.realLink ? (
+          <Link
+            title={apubName}
+            className={this.props.muted ? "text-muted" : "text-info"}
+            to={link}
+          >
+            {this.avatarAndName(displayName)}
+          </Link>
+        ) : (
+          <a
+            title={apubName}
+            className={this.props.muted ? "text-muted" : "text-info"}
+            href={link}
+          >
+            {this.avatarAndName(displayName)}
+          </a>
+        )}
 
         {isCakeDay(person.published) && <CakeDay creatorName={apubName} />}
       </>
     );
   }
+
+  avatarAndName(displayName: string) {
+    let person = this.props.person;
+    return (
+      <>
+        {!this.props.hideAvatar && person.avatar && showAvatars() && (
+          <PictrsImage src={person.avatar} icon />
+        )}
+        <span>{displayName}</span>
+      </>
+    );
+  }
 }