fedi/lemmy-ui
1
0
Fork 0
mirror of https://github.com/LemmyNet/lemmy-ui.git synced 2024-11-21 14:17:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix parent comment linking when not showing context (#2417)

Browse source 
The same code is reused for the "show context" button as for the "link
to self" button. I'm not sure that's such a good idea in the long run.

There was a const `parentCommentId` that was always set even when not
having the `showContext` prop, causing the bug #2401.
This commit is contained in:
snan 2024-04-11 14:58:23 +02:00 committed by GitHub
parent ddd4a98fd7
commit b983071e79
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/shared/components/comment/comment-node.tsx
View file

@ -501,14 +501,14 @@ export class CommentNode extends Component<CommentNodeProps, CommentNodeState> {
? I18NextService.i18n.t("show_context") ? I18NextService.i18n.t("show_context")
: I18NextService.i18n.t("link"); : I18NextService.i18n.t("link");
// The context button should show the parent comment by default
const parentCommentId = getCommentParentId(cv.comment) ?? cv.comment.id;
return ( return (
<> <>
<Link <Link
className={classnames} className={classnames}
to={`/comment/${parentCommentId}`} to={`/comment/${
(this.props.showContext && getCommentParentId(cv.comment)) ||
cv.comment.id
}`}
title={title} title={title}
> >
<Icon icon="link" classes="icon-inline" /> <Icon icon="link" classes="icon-inline" />