Fix password autocomplete (#2033)

This commit is contained in:
SleeplessOne1917 2023-08-07 12:51:19 -04:00 committed by GitHub
parent 76a656bc5b
commit 61e0241d89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 12 additions and 3 deletions

View file

@ -14,6 +14,7 @@ interface PasswordInputProps {
showStrength?: boolean;
label?: string | null;
showForgotLink?: boolean;
isNew?: boolean;
}
interface PasswordInputState {
@ -73,6 +74,7 @@ class PasswordInput extends Component<PasswordInputProps, PasswordInputState> {
showStrength,
label,
showForgotLink,
isNew,
},
state: { show },
} = this;
@ -91,7 +93,7 @@ class PasswordInput extends Component<PasswordInputProps, PasswordInputState> {
type={show ? "text" : "password"}
className="form-control"
aria-describedby={id}
autoComplete="on"
autoComplete={isNew ? "new-password" : "current-password"}
onInput={onInput}
value={value}
required

View file

@ -128,6 +128,7 @@ export class Setup extends Component<any, State> {
value={this.state.form.password}
onInput={linkEvent(this, this.handleRegisterPasswordChange)}
label={I18NextService.i18n.t("password")}
isNew
/>
</div>
<div className="mb-3">
@ -136,6 +137,7 @@ export class Setup extends Component<any, State> {
value={this.state.form.password_verify}
onInput={linkEvent(this, this.handleRegisterPasswordVerifyChange)}
label={I18NextService.i18n.t("verify_password")}
isNew
/>
</div>
<div className="mb-3 row">

View file

@ -189,6 +189,7 @@ export class Signup extends Component<any, State> {
onInput={linkEvent(this, this.handleRegisterPasswordChange)}
showStrength
label={I18NextService.i18n.t("password")}
isNew
/>
</div>
@ -198,6 +199,7 @@ export class Signup extends Component<any, State> {
value={this.state.form.password_verify}
onInput={linkEvent(this, this.handleRegisterPasswordVerifyChange)}
label={I18NextService.i18n.t("verify_password")}
isNew
/>
</div>

View file

@ -68,6 +68,7 @@ export class PasswordChange extends Component<any, State> {
onInput={linkEvent(this, this.handlePasswordChange)}
showStrength
label={I18NextService.i18n.t("new_password")}
isNew
/>
</div>
<div className="mb-3">

View file

@ -264,7 +264,7 @@ export class Settings extends Component<any, SettingsState> {
);
}
userSettings(isSelected) {
userSettings(isSelected: boolean) {
return (
<div
className={classNames("tab-pane show", {
@ -289,7 +289,7 @@ export class Settings extends Component<any, SettingsState> {
);
}
blockCards(isSelected) {
blockCards(isSelected: boolean) {
return (
<div
className={classNames("tab-pane", {
@ -326,6 +326,7 @@ export class Settings extends Component<any, SettingsState> {
onInput={linkEvent(this, this.handleNewPasswordChange)}
showStrength
label={I18NextService.i18n.t("new_password")}
isNew
/>
</div>
<div className="mb-3">
@ -334,6 +335,7 @@ export class Settings extends Component<any, SettingsState> {
value={this.state.changePasswordForm.new_password_verify}
onInput={linkEvent(this, this.handleNewPasswordVerifyChange)}
label={I18NextService.i18n.t("verify_password")}
isNew
/>
</div>
<div className="mb-3">