Incorporate PR feedback

This commit is contained in:
SleeplessOne1917 2023-07-10 19:53:45 -04:00
parent 1d1c338f12
commit 41f68bd2fc
6 changed files with 12 additions and 12 deletions

View file

@ -12,7 +12,7 @@ interface PasswordInputProps {
onInput: FormEventHandler<HTMLInputElement>;
className?: string;
showStrength?: boolean;
label?: string;
label?: string | null;
showForgotLink?: boolean;
}
@ -96,7 +96,7 @@ class PasswordInput extends Component<PasswordInputProps, PasswordInputState> {
value={value}
required
maxLength={60}
minLength={showStrength ? 10 : 0}
minLength={10}
/>
<button
className="btn btn-outline-dark"

View file

@ -95,7 +95,7 @@ export class Login extends Component<any, State> {
id="login-password"
value={this.state.form.password}
onInput={linkEvent(this, this.handleLoginPasswordChange)}
label={I18NextService.i18n.t("password") ?? undefined}
label={I18NextService.i18n.t("password")}
showForgotLink
/>
</div>

View file

@ -127,7 +127,7 @@ export class Setup extends Component<any, State> {
id="password"
value={this.state.form.password}
onInput={linkEvent(this, this.handleRegisterPasswordChange)}
label={I18NextService.i18n.t("password") ?? undefined}
label={I18NextService.i18n.t("password")}
/>
</div>
<div className="mb-3">
@ -135,7 +135,7 @@ export class Setup extends Component<any, State> {
id="verify-password"
value={this.state.form.password_verify}
onInput={linkEvent(this, this.handleRegisterPasswordVerifyChange)}
label={I18NextService.i18n.t("verify_password") ?? undefined}
label={I18NextService.i18n.t("verify_password")}
/>
</div>
<div className="mb-3 row">

View file

@ -188,7 +188,7 @@ export class Signup extends Component<any, State> {
value={this.state.form.password}
onInput={linkEvent(this, this.handleRegisterPasswordChange)}
showStrength
label={I18NextService.i18n.t("password") ?? undefined}
label={I18NextService.i18n.t("password")}
/>
</div>
@ -197,7 +197,7 @@ export class Signup extends Component<any, State> {
id="register-verify-password"
value={this.state.form.password_verify}
onInput={linkEvent(this, this.handleRegisterPasswordVerifyChange)}
label={I18NextService.i18n.t("verify_password") ?? undefined}
label={I18NextService.i18n.t("verify_password")}
/>
</div>

View file

@ -67,7 +67,7 @@ export class PasswordChange extends Component<any, State> {
value={this.state.form.password}
onInput={linkEvent(this, this.handlePasswordChange)}
showStrength
label={I18NextService.i18n.t("new_password") ?? undefined}
label={I18NextService.i18n.t("new_password")}
/>
</div>
<div className="mb-3">
@ -75,7 +75,7 @@ export class PasswordChange extends Component<any, State> {
id="password"
value={this.state.form.password_verify}
onInput={linkEvent(this, this.handleVerifyPasswordChange)}
label={I18NextService.i18n.t("verify_password") ?? undefined}
label={I18NextService.i18n.t("verify_password")}
/>
</div>
<div className="mb-3 row">

View file

@ -325,7 +325,7 @@ export class Settings extends Component<any, SettingsState> {
value={this.state.changePasswordForm.new_password}
onInput={linkEvent(this, this.handleNewPasswordChange)}
showStrength
label={I18NextService.i18n.t("new_password") ?? undefined}
label={I18NextService.i18n.t("new_password")}
/>
</div>
<div className="mb-3">
@ -333,7 +333,7 @@ export class Settings extends Component<any, SettingsState> {
id="verify-new-password"
value={this.state.changePasswordForm.new_password_verify}
onInput={linkEvent(this, this.handleNewPasswordVerifyChange)}
label={I18NextService.i18n.t("verify_password") ?? undefined}
label={I18NextService.i18n.t("verify_password")}
/>
</div>
<div className="mb-3">
@ -341,7 +341,7 @@ export class Settings extends Component<any, SettingsState> {
id="user-old-password"
value={this.state.changePasswordForm.old_password}
onInput={linkEvent(this, this.handleOldPasswordChange)}
label={I18NextService.i18n.t("old_password") ?? undefined}
label={I18NextService.i18n.t("old_password")}
/>
</div>
<div className="input-group mb-3">