fedi/lemmy-ui
1
0
Fork 0
mirror of https://github.com/LemmyNet/lemmy-ui.git synced 2024-11-28 16:38:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix 502 error on initial settings page load. (#2498)

Browse source 
- Needed to wrap the fetchThemeList in an isBrowser check.
- Fixes #2497
This commit is contained in:
Dessalines 2024-06-03 18:31:54 -04:00 committed by GitHub
parent e3a11648c9
commit 18c3f3975f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/shared/components/person/settings.tsx
View file

@ -67,7 +67,12 @@ import { PersonListing } from "./person-listing";
import { InitialFetchRequest } from "../../interfaces"; import { InitialFetchRequest } from "../../interfaces";
import TotpModal from "../common/totp-modal"; import TotpModal from "../common/totp-modal";
import { LoadingEllipses } from "../common/loading-ellipses"; import { LoadingEllipses } from "../common/loading-ellipses";
import { refreshTheme, setThemeOverride, snapToTop } from "../../utils/browser"; import {
isBrowser,
refreshTheme,
setThemeOverride,
snapToTop,
} from "../../utils/browser";
import { getHttpBaseInternal } from "../../utils/env"; import { getHttpBaseInternal } from "../../utils/env";
import { IRoutePropsWithFetch } from "../../routes"; import { IRoutePropsWithFetch } from "../../routes";
import { RouteComponentProps } from "inferno-router/dist/Route"; import { RouteComponentProps } from "inferno-router/dist/Route";
@ -349,6 +354,7 @@ export class Settings extends Component<SettingsRouteProps, SettingsState> {
} }
async componentWillMount() { async componentWillMount() {
if (isBrowser()) {
this.setState({ themeList: await fetchThemeList() }); this.setState({ themeList: await fetchThemeList() });
if (!this.state.isIsomorphic) { if (!this.state.isIsomorphic) {
@ -361,6 +367,7 @@ export class Settings extends Component<SettingsRouteProps, SettingsState> {
}); });
} }
} }
}
componentWillUnmount(): void { componentWillUnmount(): void {
// In case `interface_language` change wasn't saved. // In case `interface_language` change wasn't saved.