fedi/lemmy-ui
1
0
Fork 0
mirror of https://github.com/LemmyNet/lemmy-ui.git synced 2025-01-01 13:08:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed unclickable button paddings

Browse source 
* Remove the wrapping <button> element that
  visually seems clickable but has no click
  handling (only its child link can be
  clicked)
* fixes #1193
This commit is contained in:
Florian Heft 2023-06-12 10:30:37 +02:00
parent d56addf7d6
commit 170949f34f
2 changed files with 25 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/shared/components/comment/comment-node.tsx
View file

@ -436,15 +436,13 @@ export class CommentNode extends Component<CommentNodeProps, CommentNodeState> {
<> <>
{!this.myComment && ( {!this.myComment && (
<> <>
<button className="btn btn-link btn-animate">
<Link <Link
className="text-muted" className="btn btn-link btn-animate text-muted"
to={`/create_private_message/${cv.creator.id}`} to={`/create_private_message/${cv.creator.id}`}
title={i18n.t("message").toLowerCase()} title={i18n.t("message").toLowerCase()}
> >
<Icon icon="mail" /> <Icon icon="mail" />
</Link> </Link>
</button>
<button <button
className="btn btn-link btn-animate text-muted" className="btn btn-link btn-animate text-muted"
onClick={linkEvent( onClick={linkEvent(

4
src/shared/components/post/post-listing.tsx
View file

@ -649,9 +649,8 @@ export class PostListing extends Component<PostListingProps, PostListingState> {
get commentsButton() { get commentsButton() {
const post_view = this.props.post_view; const post_view = this.props.post_view;
return ( return (
<button className="btn btn-link text-muted py-0 pl-0">
<Link <Link
className="text-muted" className="btn btn-link text-muted py-0 pl-0 text-muted"
title={i18n.t("number_of_comments", { title={i18n.t("number_of_comments", {
count: Number(post_view.counts.comments), count: Number(post_view.counts.comments),
formattedCount: Number(post_view.counts.comments), formattedCount: Number(post_view.counts.comments),
@ -671,7 +670,6 @@ export class PostListing extends Component<PostListingProps, PostListingState> {
</span> </span>
)} )}
</Link> </Link>
</button>
); );
} }