forgejo/routers/web/repo
Gergely Nagy 6f35a5ab90
Fix Issue watching / unwatching on the web ui
When subscribing or unsubscribing to/from an issue on the web ui, the
request was posted to a route handled by `repo.IssueWatch`. This
function used `ctx.Req.PostForm.Get()`, erroneously.

`request.PostForm` is *only* available if `request.ParseForm()` has been
called before it. The function in question did not do that. Under some
circumstances, something, somewhere did end up calling `ParseForm()`,
but not in every scenario.

Since we do not need to check for multiple values, the easiest fix here
is to use `ctx.Req.PostFormValue`, which will call `ParseForm()` if
necessary.

Fixes #3516.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-05-01 13:32:39 +02:00
..
actions Fix bugs in rerunning jobs (#29955) 2024-03-26 19:04:26 +01:00
badges Fix repo badges when the label or text contains dashes 2024-03-20 22:41:20 +01:00
flags Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
setting [PORT] gitea#30430: Fix rename branch 500 when the target branch is deleted but exist in database 2024-04-15 15:52:24 +00:00
activity.go Show repo activities even if only code unit active or git repo is empty but issue is active (#3455) 2024-04-28 13:50:45 +00:00
attachment.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
blame.go Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
branch.go Use repo object format name instead of detecting from git repository (#29702) 2024-03-20 08:46:28 +01:00
cherry_pick.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
code_frequency.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
commit.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-26 19:04:27 +01:00
compare.go [v7.0/forgejo] Fix "view file" button in diff compare view (#3077) 2024-04-06 13:24:55 +00:00
contributors.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
download.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
editor.go [BUG] Use correct template for commitmail error 2024-04-02 14:59:34 +00:00
editor_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
find.go Escape paths for find file correctly (#30026) 2024-03-26 19:04:27 +01:00
githttp.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
githttp_test.go Fix http protocol auth (#27875) 2023-11-02 22:14:33 +08:00
helper.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
helper_test.go Make web context initialize correctly for different cases (#26726) 2023-08-25 19:07:42 +08:00
issue.go Fix missed doer (#30231) (#30343) 2024-04-15 16:21:45 +02:00
issue_content_history.go Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
issue_dependency.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_label.go [GITEA] Apply changes to archived labels 2024-04-03 20:14:39 +00:00
issue_label_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_lock.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_pin.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_stopwatch.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_watch.go Fix Issue watching / unwatching on the web ui 2024-05-01 13:32:39 +02:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
middlewares.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
migrate.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
milestone.go remove util.OptionalBool and related functions (#29513) 2024-03-06 12:10:46 +08:00
packages.go remove util.OptionalBool and related functions (#29513) 2024-03-06 12:10:46 +08:00
patch.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
projects.go Fix network error when open/close organization/individual projects and redirect to project page (#30387) (#30465) 2024-04-15 16:44:14 +02:00
projects_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
pull.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-26 19:04:27 +01:00
pull_review.go Prevent re-review and dismiss review actions on closed and merged PRs (#30065) 2024-03-30 07:17:32 +01:00
pull_review_test.go [TESTS] pull review deleted from gitea#29888 2024-04-03 08:13:14 +00:00
recent_commits.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
release.go Fix release published actions not triggering for releases created from existing tags 2024-04-16 18:28:53 +00:00
release_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
render.go Refactor render (#30136) 2024-03-30 07:17:31 +01:00
repo.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-26 19:04:27 +01:00
search.go [v7.0/forgejo] [BUG] Fix code search in explore reporting as git grep even with indexer enabled (#3204) 2024-04-14 14:21:31 +00:00
topic.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
treelist.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
view.go s/Gitea/Forgejo in various log messages and comments 2024-04-22 14:41:17 +00:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
wiki_test.go Make "/user/login" page redirect if the current user has signed in (#29583) 2024-03-11 23:36:58 +07:00