mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-15 14:08:21 +00:00
858fbbaafd
- Don't show the 'View at this point in history' button for wikis as
wikis don't have this feature.
- Adds integration test
- Resolves https://codeberg.org/forgejo/forgejo/issues/2995
(cherry picked from commit 8df9100994
)
188 lines
6 KiB
Go
188 lines
6 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
||
// SPDX-License-Identifier: MIT
|
||
|
||
package integration
|
||
|
||
import (
|
||
"fmt"
|
||
"net/http"
|
||
"net/url"
|
||
"strings"
|
||
"testing"
|
||
|
||
unit_model "code.gitea.io/gitea/models/unit"
|
||
"code.gitea.io/gitea/models/unittest"
|
||
user_model "code.gitea.io/gitea/models/user"
|
||
"code.gitea.io/gitea/modules/setting"
|
||
"code.gitea.io/gitea/modules/test"
|
||
files_service "code.gitea.io/gitea/services/repository/files"
|
||
"code.gitea.io/gitea/tests"
|
||
|
||
"github.com/stretchr/testify/assert"
|
||
)
|
||
|
||
func TestRenderFileSVGIsInImgTag(t *testing.T) {
|
||
defer tests.PrepareTestEnv(t)()
|
||
|
||
session := loginUser(t, "user2")
|
||
|
||
req := NewRequest(t, "GET", "/user2/repo2/src/branch/master/line.svg")
|
||
resp := session.MakeRequest(t, req, http.StatusOK)
|
||
|
||
doc := NewHTMLParser(t, resp.Body)
|
||
src, exists := doc.doc.Find(".file-view img").Attr("src")
|
||
assert.True(t, exists, "The SVG image should be in an <img> tag so that scripts in the SVG are not run")
|
||
assert.Equal(t, "/user2/repo2/raw/branch/master/line.svg", src)
|
||
}
|
||
|
||
func TestAmbiguousCharacterDetection(t *testing.T) {
|
||
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
||
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
||
session := loginUser(t, user2.Name)
|
||
|
||
// Prepare the environments. File view, commit view (diff), wiki page.
|
||
repo, commitID, f := CreateDeclarativeRepo(t, user2, "",
|
||
[]unit_model.Type{unit_model.TypeCode, unit_model.TypeWiki}, nil,
|
||
[]*files_service.ChangeRepoFile{
|
||
{
|
||
Operation: "create",
|
||
TreePath: "test.sh",
|
||
ContentReader: strings.NewReader("Hello there!\nline western"),
|
||
},
|
||
},
|
||
)
|
||
defer f()
|
||
|
||
req := NewRequestWithValues(t, "POST", repo.Link()+"/wiki?action=new", map[string]string{
|
||
"_csrf": GetCSRF(t, session, repo.Link()+"/wiki?action=new"),
|
||
"title": "Normal",
|
||
"content": "Hello – Hello",
|
||
})
|
||
session.MakeRequest(t, req, http.StatusSeeOther)
|
||
|
||
assertCase := func(t *testing.T, fileContext, commitContext, wikiContext bool) {
|
||
t.Helper()
|
||
|
||
t.Run("File context", func(t *testing.T) {
|
||
defer tests.PrintCurrentTest(t)()
|
||
|
||
req := NewRequest(t, "GET", repo.Link()+"/src/branch/main/test.sh")
|
||
resp := session.MakeRequest(t, req, http.StatusOK)
|
||
|
||
htmlDoc := NewHTMLParser(t, resp.Body)
|
||
htmlDoc.AssertElement(t, ".unicode-escape-prompt", fileContext)
|
||
})
|
||
t.Run("Commit context", func(t *testing.T) {
|
||
defer tests.PrintCurrentTest(t)()
|
||
|
||
req := NewRequest(t, "GET", repo.Link()+"/commit/"+commitID)
|
||
resp := session.MakeRequest(t, req, http.StatusOK)
|
||
|
||
htmlDoc := NewHTMLParser(t, resp.Body)
|
||
htmlDoc.AssertElement(t, ".lines-escape .toggle-escape-button", commitContext)
|
||
})
|
||
t.Run("Wiki context", func(t *testing.T) {
|
||
defer tests.PrintCurrentTest(t)()
|
||
|
||
req := NewRequest(t, "GET", repo.Link()+"/wiki/Normal")
|
||
resp := session.MakeRequest(t, req, http.StatusOK)
|
||
|
||
htmlDoc := NewHTMLParser(t, resp.Body)
|
||
htmlDoc.AssertElement(t, ".unicode-escape-prompt", wikiContext)
|
||
})
|
||
}
|
||
|
||
t.Run("Enabled all context", func(t *testing.T) {
|
||
defer test.MockVariableValue(&setting.UI.SkipEscapeContexts, []string{})()
|
||
|
||
assertCase(t, true, true, true)
|
||
})
|
||
|
||
t.Run("Enabled file context", func(t *testing.T) {
|
||
defer test.MockVariableValue(&setting.UI.SkipEscapeContexts, []string{"diff", "wiki"})()
|
||
|
||
assertCase(t, true, false, false)
|
||
})
|
||
|
||
t.Run("Enabled commit context", func(t *testing.T) {
|
||
defer test.MockVariableValue(&setting.UI.SkipEscapeContexts, []string{"file-view", "wiki"})()
|
||
|
||
assertCase(t, false, true, false)
|
||
})
|
||
|
||
t.Run("Enabled wiki context", func(t *testing.T) {
|
||
defer test.MockVariableValue(&setting.UI.SkipEscapeContexts, []string{"file-view", "diff"})()
|
||
|
||
assertCase(t, false, false, true)
|
||
})
|
||
|
||
t.Run("No context", func(t *testing.T) {
|
||
defer test.MockVariableValue(&setting.UI.SkipEscapeContexts, []string{"file-view", "wiki", "diff"})()
|
||
|
||
assertCase(t, false, false, false)
|
||
})
|
||
|
||
t.Run("Disabled detection", func(t *testing.T) {
|
||
defer test.MockVariableValue(&setting.UI.SkipEscapeContexts, []string{})()
|
||
defer test.MockVariableValue(&setting.UI.AmbiguousUnicodeDetection, false)()
|
||
|
||
assertCase(t, false, false, false)
|
||
})
|
||
})
|
||
}
|
||
|
||
func TestInHistoryButton(t *testing.T) {
|
||
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
||
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
||
session := loginUser(t, user2.Name)
|
||
repo, commitID, f := CreateDeclarativeRepo(t, user2, "",
|
||
[]unit_model.Type{unit_model.TypeCode, unit_model.TypeWiki}, nil,
|
||
[]*files_service.ChangeRepoFile{
|
||
{
|
||
Operation: "create",
|
||
TreePath: "test.sh",
|
||
ContentReader: strings.NewReader("Hello there!"),
|
||
},
|
||
},
|
||
)
|
||
defer f()
|
||
|
||
req := NewRequestWithValues(t, "POST", repo.Link()+"/wiki?action=new", map[string]string{
|
||
"_csrf": GetCSRF(t, session, repo.Link()+"/wiki?action=new"),
|
||
"title": "Normal",
|
||
"content": "Hello world!",
|
||
})
|
||
session.MakeRequest(t, req, http.StatusSeeOther)
|
||
|
||
t.Run("Wiki revision", func(t *testing.T) {
|
||
defer tests.PrintCurrentTest(t)()
|
||
|
||
req := NewRequest(t, "GET", repo.Link()+"/wiki/Normal?action=_revision")
|
||
resp := session.MakeRequest(t, req, http.StatusOK)
|
||
htmlDoc := NewHTMLParser(t, resp.Body)
|
||
|
||
htmlDoc.AssertElement(t, fmt.Sprintf(".commit-list a[href^='/%s/src/commit/']", repo.FullName()), false)
|
||
})
|
||
|
||
t.Run("Commit list", func(t *testing.T) {
|
||
defer tests.PrintCurrentTest(t)()
|
||
|
||
req := NewRequest(t, "GET", repo.Link()+"/commits/branch/main")
|
||
resp := session.MakeRequest(t, req, http.StatusOK)
|
||
htmlDoc := NewHTMLParser(t, resp.Body)
|
||
|
||
htmlDoc.AssertElement(t, fmt.Sprintf(".commit-list a[href='/%s/src/commit/%s']", repo.FullName(), commitID), true)
|
||
})
|
||
|
||
t.Run("File history", func(t *testing.T) {
|
||
defer tests.PrintCurrentTest(t)()
|
||
|
||
req := NewRequest(t, "GET", repo.Link()+"/commits/branch/main/test.sh")
|
||
resp := session.MakeRequest(t, req, http.StatusOK)
|
||
htmlDoc := NewHTMLParser(t, resp.Body)
|
||
|
||
htmlDoc.AssertElement(t, fmt.Sprintf(".commit-list a[href='/%s/src/commit/%s/test.sh']", repo.FullName(), commitID), true)
|
||
})
|
||
})
|
||
}
|