forgejo/models/migrations/fixtures/Test_RepositoryFormat/comment.yml at cf2d8b57ae2ba4bf57c37810153cfe88c7e6b10f - fedi/forgejo - git.minimally.online

fedi/forgejo

mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-17 14:55:11 +00:00

Lunny Xiao 97c8dbf332

Fix bug hidden on CI and make ci failed if tests failure (#29254 )

The tests on migration tests failed but CI reports successfully

https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141

This PR will fix the bug on migration v283 and also the CI hidden
behaviour.

The reason is on the Makefile

`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.

But

`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
	done`

will not work.

This also fix #29602

(cherry picked from commit 45277486c2c6213b7766b1da708a991cdb1f3565)

Conflicts:
	.github/workflows/pull-db-tests.yml
	Makefile
	models/migrations/v1_22/v283.go
	models/migrations/v1_22/v286_test.go
	models/migrations/v1_22/v287_test.go
	already in Forgejo for the Makefile & CI logic but Gitea changes
	otherwise rule

2024-03-11 23:36:59 +07:00

4 lines

65 B

YAML

Raw Blame History

	`-`
	`id: 1`
	`commit_sha: 19fe5caf872476db265596eaac1dc35ad1c6422d`