mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-05 01:40:04 +00:00
716fcfcf72
A lot of our code is repeatedly testing if individual errors are specific types of Not Exist errors. This is repetitative and unnecesary. `Unwrap() error` provides a common way of labelling an error as a NotExist error and we can/should use this. This PR has chosen to use the common `io/fs` errors e.g. `fs.ErrNotExist` for our errors. This is in some ways not completely correct as these are not filesystem errors but it seems like a reasonable thing to do and would allow us to simplify a lot of our code to `errors.Is(err, fs.ErrNotExist)` instead of `package.IsErr...NotExist(err)` I am open to suggestions to use a different base error - perhaps `models/db.ErrNotExist` if that would be felt to be better. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de> |
||
---|---|---|
.. | ||
filebuffer | ||
compare.go | ||
error.go | ||
file_unix.go | ||
file_unix_test.go | ||
file_windows.go | ||
io.go | ||
legacy.go | ||
legacy_test.go | ||
paginate.go | ||
paginate_test.go | ||
path.go | ||
path_test.go | ||
remove.go | ||
sanitize.go | ||
sanitize_test.go | ||
sec_to_time.go | ||
sec_to_time_test.go | ||
shellquote.go | ||
shellquote_test.go | ||
slice.go | ||
string.go | ||
string_test.go | ||
timer.go | ||
truncate.go | ||
truncate_test.go | ||
url.go | ||
util.go | ||
util_test.go |