mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-25 01:39:31 +00:00
c9e402afdc
Modifies forms: - (new) org team - (new) repo webhook - (new) repo protected branch The forms are not completely rewritten to semantic HTML yet. The focus of this change was on standard elements, some custom solutions were left untouched for now. - swaps the order fo permission radio buttons as per https://codeberg.org/forgejo/forgejo/issues/4983 - uses fieldsets to group related inputs - ensures consistent styling across forms - can be improved later, e.g. using horizontal lines between sections - fixes: previous font size of labels was smaller than the font size of the help text - help text are now part of the label, clicking them now also activates the input - drop unused CSS (no required checkboxes in grouped class remain) - playwright testing: - move login boilerplate to utils - automated form accessibility checking - allow defining the scope, because legacy parts of the forms are not yet accessible - assert some CSS properties that should not be overriden - the Makefile adjustment was necessary, because eslint scanned some internal files in the tests/e2e/reports directory
26 lines
1 KiB
JavaScript
26 lines
1 KiB
JavaScript
// @ts-check
|
|
import {expect} from '@playwright/test';
|
|
import {test, login_user, login} from './utils_e2e.js';
|
|
import {validate_form} from './shared/forms.js';
|
|
|
|
test.beforeAll(async ({browser}, workerInfo) => {
|
|
await login_user(browser, workerInfo, 'user2');
|
|
});
|
|
|
|
test('org team settings', async ({browser}, workerInfo) => {
|
|
test.skip(workerInfo.project.name === 'Mobile Safari', 'Cannot get it to work - as usual');
|
|
const page = await login({browser}, workerInfo);
|
|
const response = await page.goto('/org/org3/teams/team1/edit');
|
|
await expect(response?.status()).toBe(200);
|
|
|
|
await page.locator('input[name="permission"][value="admin"]').click();
|
|
await expect(page.locator('.team-units')).toBeHidden();
|
|
|
|
// we are validating the form here, because the now hidden part has accessibility issues anyway
|
|
// this should be moved up or down once they are fixed.
|
|
await validate_form({page});
|
|
|
|
await page.locator('input[name="permission"][value="read"]').click();
|
|
await expect(page.locator('.team-units')).toBeVisible();
|
|
});
|