oliverpool b6e81357bd Add Webhook authorization header (#20926) ... _This is a different approach to #20267, I took the liberty of adapting some parts, see below_ ## Context In some cases, a weebhook endpoint requires some kind of authentication. The usual way is by sending a static `Authorization` header, with a given token. For instance: - Matrix expects a `Bearer <token>` (already implemented, by storing the header cleartext in the metadata - which is buggy on retry #19872) - TeamCity #18667 - Gitea instances #20267 - SourceHut https://man.sr.ht/graphql.md#authentication-strategies (this is my actual personal need :) ## Proposed solution Add a dedicated encrypt column to the webhook table (instead of storing it as meta as proposed in #20267), so that it gets available for all present and future hook types (especially the custom ones #19307). This would also solve the buggy matrix retry #19872. As a first step, I would recommend focusing on the backend logic and improve the frontend at a later stage. For now the UI is a simple `Authorization` field (which could be later customized with `Bearer` and `Basic` switches):  The header name is hard-coded, since I couldn't fine any usecase justifying otherwise. ## Questions - What do you think of this approach? @justusbunsi @Gusted @silverwind - ~~How are the migrations generated? Do I have to manually create a new file, or is there a command for that?~~ - ~~I started adding it to the API: should I complete it or should I drop it? (I don't know how much the API is actually used)~~ ## Done as well: - add a migration for the existing matrix webhooks and remove the `Authorization` logic there _Closes #19872_ Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: delvh <dev.lh@web.de>		2022-11-03 20:23:20 +02:00
..
convert.go	Add Webhook authorization header (#20926)	2022-11-03 20:23:20 +02:00
git_commit.go	Add stat to ToCommit function for speed (#21337)	2022-10-06 11:21:04 +08:00
git_commit_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
issue.go	Add more linters to improve code readability (#19989)	2022-06-20 12:02:49 +02:00
issue_comment.go	Fix 500 on time tracking in timeline API (#21052)	2022-09-04 15:01:23 +01:00
issue_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
main_test.go
mirror.go	Add new API endpoints for push mirrors management (#19841)	2022-07-30 18:45:59 +02:00
notification.go	Move some files into models' sub packages (#20262)	2022-08-25 10:31:57 +08:00
package.go
pull.go
pull_review.go
pull_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
release.go	Move some files into models' sub packages (#20262)	2022-08-25 10:31:57 +08:00
repository.go	Make external issue tracker regexp configurable via API (#21338)	2022-10-07 20:49:30 +08:00
status.go
user.go	Include login_name in adminCreateUser response (#20283)	2022-07-15 16:52:11 +08:00
user_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797)	2022-08-16 10:22:25 +08:00
utils.go
utils_test.go
wiki.go