mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-26 18:12:17 +00:00
6b33152b7d
Replace #16455 Close #21803 Mixing different Gitea contexts together causes some problems: 1. Unable to respond proper content when error occurs, eg: Web should respond HTML while API should respond JSON 2. Unclear dependency, eg: it's unclear when Context is used in APIContext, which fields should be initialized, which methods are necessary. To make things clear, this PR introduces a Base context, it only provides basic Req/Resp/Data features. This PR mainly moves code. There are still many legacy problems and TODOs in code, leave unrelated changes to future PRs.
54 lines
1.9 KiB
Go
54 lines
1.9 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package markup
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
"code.gitea.io/gitea/models/user"
|
|
gitea_context "code.gitea.io/gitea/modules/context"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestProcessorHelper(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
userPublic := "user1"
|
|
userPrivate := "user31"
|
|
userLimited := "user33"
|
|
userNoSuch := "no-such-user"
|
|
|
|
unittest.AssertCount(t, &user.User{Name: userPublic}, 1)
|
|
unittest.AssertCount(t, &user.User{Name: userPrivate}, 1)
|
|
unittest.AssertCount(t, &user.User{Name: userLimited}, 1)
|
|
unittest.AssertCount(t, &user.User{Name: userNoSuch}, 0)
|
|
|
|
// when using general context, use user's visibility to check
|
|
assert.True(t, ProcessorHelper().IsUsernameMentionable(context.Background(), userPublic))
|
|
assert.False(t, ProcessorHelper().IsUsernameMentionable(context.Background(), userLimited))
|
|
assert.False(t, ProcessorHelper().IsUsernameMentionable(context.Background(), userPrivate))
|
|
assert.False(t, ProcessorHelper().IsUsernameMentionable(context.Background(), userNoSuch))
|
|
|
|
// when using web context, use user.IsUserVisibleToViewer to check
|
|
req, err := http.NewRequest("GET", "/", nil)
|
|
assert.NoError(t, err)
|
|
base, baseCleanUp := gitea_context.NewBaseContext(httptest.NewRecorder(), req)
|
|
defer baseCleanUp()
|
|
giteaCtx := &gitea_context.Context{Base: base}
|
|
|
|
assert.True(t, ProcessorHelper().IsUsernameMentionable(giteaCtx, userPublic))
|
|
assert.False(t, ProcessorHelper().IsUsernameMentionable(giteaCtx, userPrivate))
|
|
|
|
giteaCtx.Doer, err = user.GetUserByName(db.DefaultContext, userPrivate)
|
|
assert.NoError(t, err)
|
|
assert.True(t, ProcessorHelper().IsUsernameMentionable(giteaCtx, userPublic))
|
|
assert.True(t, ProcessorHelper().IsUsernameMentionable(giteaCtx, userPrivate))
|
|
}
|