mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-11 12:40:16 +00:00
937b8e8184
Backport #24470
Fixes #24145
---
To solve the bug, I added a "computed" `TargetBehind` field to the
`Release` model, which indicates the target branch of a release. This is
particularly useful if the target branch was deleted in the meantime (or
is empty).
I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead
of checking that a branch exists and then call `GetBranchCommit`, I
immediately call `GetBranchCommit` and handle the `git.ErrNotExist`
error.
This optimization is covered by the added unit test.
_contributed in the context of @forgejo_
(cherry picked from commit cb7ba8969d)
160 lines
6.9 KiB
Handlebars
160 lines
6.9 KiB
Handlebars
{{template "base/head" .}}
|
|
<div role="main" aria-label="{{.Title}}" class="page-content repository releases">
|
|
{{template "repo/header" .}}
|
|
<div class="ui container">
|
|
{{template "base/alert" .}}
|
|
{{template "repo/sub_menu_release_tag" .}}
|
|
|
|
{{if .CanCreateRelease}}
|
|
<a class="ui right small green button" href="{{$.RepoLink}}/releases/new">
|
|
{{.locale.Tr "repo.release.new_release"}}
|
|
</a>
|
|
{{end}}
|
|
<ul id="release-list">
|
|
{{range $idx, $release := .Releases}}
|
|
<li class="ui grid">
|
|
<div class="ui four wide column meta gt-mt-2">
|
|
{{if .IsTag}}
|
|
{{if .CreatedUnix}}<span class="time">{{TimeSinceUnix .CreatedUnix $.locale}}</span>{{end}}
|
|
{{else}}
|
|
<a class="gt-df gt-ac gt-je muted" href="{{if not .Sha1}}#{{else}}{{$.RepoLink}}/src/tag/{{.TagName | PathEscapeSegments}}{{end}}" rel="nofollow">{{svg "octicon-tag" 16 "gt-mr-2"}}{{.TagName}}</a>
|
|
{{if .Sha1}}
|
|
<span class="commit">
|
|
<a class="gt-mono muted" href="{{$.RepoLink}}/src/commit/{{.Sha1}}" rel="nofollow">{{svg "octicon-git-commit" 16 "gt-mr-2"}}{{ShortSha .Sha1}}</a>
|
|
</span>
|
|
{{template "repo/branch_dropdown" dict "root" $ "release" .}}
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
<div class="ui twelve wide column detail">
|
|
{{if .IsTag}}
|
|
<div class="gt-df gt-ac gt-sb gt-fw gt-mb-3">
|
|
<h4 class="release-list-title gt-df gt-ac">
|
|
<a class="gt-df gt-ac" href="{{$.RepoLink}}/src/tag/{{.TagName | PathEscapeSegments}}" rel="nofollow">{{svg "octicon-tag" 24 "gt-mr-3"}}{{.TagName}}</a>
|
|
</h4>
|
|
</div>
|
|
<p class="text grey">
|
|
{{if gt .Publisher.ID 0}}
|
|
<span class="author">
|
|
{{avatar $.Context .Publisher 20}}
|
|
<a href="{{.Publisher.HomeLink}}">{{.Publisher.Name}}</a>
|
|
</span>
|
|
<span class="released">
|
|
{{$.locale.Tr "repo.released_this"}}
|
|
</span>
|
|
{{if .CreatedUnix}}
|
|
<span class="time">{{TimeSinceUnix .CreatedUnix $.locale}}</span>
|
|
{{end}}
|
|
|
|
|
{{end}}
|
|
<span class="ahead"><a href="{{$.RepoLink}}/compare/{{.TagName | PathEscapeSegments}}...{{.TargetBehind | PathEscapeSegments}}">{{$.locale.Tr "repo.release.ahead.commits" .NumCommitsBehind | Str2html}}</a> {{$.locale.Tr "repo.release.ahead.target" .TargetBehind}}</span>
|
|
</p>
|
|
<div class="download">
|
|
{{if $.Permission.CanRead $.UnitTypeCode}}
|
|
<a class="gt-mono muted" href="{{$.RepoLink}}/src/commit/{{.Sha1}}" rel="nofollow">{{svg "octicon-git-commit" 16 "gt-mr-2"}}{{ShortSha .Sha1}}</a>
|
|
{{if not $.DisableDownloadSourceArchives}}
|
|
<a class="archive-link muted" href="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.zip" rel="nofollow">{{svg "octicon-file-zip"}} ZIP</a>
|
|
<a class="archive-link muted" href="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.tar.gz" rel="nofollow">{{svg "octicon-file-zip"}} TAR.GZ</a>
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
{{else}}
|
|
<div class="gt-df gt-ac gt-sb gt-fw gt-mb-3">
|
|
<h4 class="release-list-title gt-df gt-ac">
|
|
<a href="{{$.RepoLink}}/releases/tag/{{.TagName | PathEscapeSegments}}">{{.Title}}</a>
|
|
{{if .IsDraft}}
|
|
<span class="ui yellow label gt-ml-3 gt-mt-1">{{$.locale.Tr "repo.release.draft"}}</span>
|
|
{{else if .IsPrerelease}}
|
|
<span class="ui orange label gt-ml-3 gt-mt-1">{{$.locale.Tr "repo.release.prerelease"}}</span>
|
|
{{else if not .IsTag}}
|
|
<span class="ui green label gt-ml-3 gt-mt-1">{{$.locale.Tr "repo.release.stable"}}</span>
|
|
{{end}}
|
|
</h4>
|
|
<div class="gt-df gt-ac">
|
|
{{if $.CanCreateRelease}}
|
|
<a class="muted tooltip gt-ml-3 gt-df gt-ac" data-content="{{$.locale.Tr "repo.release.edit"}}" href="{{$.RepoLink}}/releases/edit/{{.TagName | PathEscapeSegments}}" rel="nofollow">
|
|
{{svg "octicon-pencil"}}
|
|
</a>
|
|
{{end}}
|
|
</div>
|
|
</div>
|
|
<p class="text grey">
|
|
<span class="author">
|
|
{{if .OriginalAuthor}}
|
|
{{svg "octicon-mark-github" 16 "gt-mr-2"}}{{.OriginalAuthor}}
|
|
{{else if .Publisher}}
|
|
{{avatar $.Context .Publisher 20}}
|
|
<a href="{{.Publisher.HomeLink}}">{{.Publisher.GetDisplayName}}</a>
|
|
{{else}}
|
|
Ghost
|
|
{{end}}
|
|
</span>
|
|
<span class="released">
|
|
{{$.locale.Tr "repo.released_this"}}
|
|
</span>
|
|
{{if .CreatedUnix}}
|
|
<span class="time">{{TimeSinceUnix .CreatedUnix $.locale}}</span>
|
|
{{end}}
|
|
{{if not .IsDraft}}
|
|
| <span class="ahead"><a href="{{$.RepoLink}}/compare/{{.TagName | PathEscapeSegments}}...{{.TargetBehind | PathEscapeSegments}}">{{$.locale.Tr "repo.release.ahead.commits" .NumCommitsBehind | Str2html}}</a> {{$.locale.Tr "repo.release.ahead.target" .TargetBehind}}</span>
|
|
{{end}}
|
|
</p>
|
|
<div class="markup desc">
|
|
{{Str2html .Note}}
|
|
</div>
|
|
<details class="download gt-border-secondary-top gt-mt-4 gt-pt-4" {{if eq $idx 0}}open{{end}}>
|
|
<summary class="gt-mb-4">
|
|
{{$.locale.Tr "repo.release.downloads"}}
|
|
</summary>
|
|
<ul class="list">
|
|
{{if and (not $.DisableDownloadSourceArchives) (not .IsDraft) ($.Permission.CanRead $.UnitTypeCode)}}
|
|
<li>
|
|
<a class="archive-link" href="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.zip" rel="nofollow"><strong>{{svg "octicon-file-zip" 16 "gt-mr-2"}}{{$.locale.Tr "repo.release.source_code"}} (ZIP)</strong></a>
|
|
</li>
|
|
<li>
|
|
<a class="archive-link" href="{{$.RepoLink}}/archive/{{.TagName | PathEscapeSegments}}.tar.gz" rel="nofollow"><strong>{{svg "octicon-file-zip" 16 "gt-mr-2"}}{{$.locale.Tr "repo.release.source_code"}} (TAR.GZ)</strong></a>
|
|
</li>
|
|
{{end}}
|
|
{{if .Attachments}}
|
|
{{range .Attachments}}
|
|
<li>
|
|
<span class="ui text middle aligned right">
|
|
<span class="ui text grey">{{.Size | FileSize}}</span>
|
|
<span class="tooltip" data-content="{{$.locale.Tr "repo.release.download_count" (.DownloadCount | PrettyNumber)}}">
|
|
{{svg "octicon-info"}}
|
|
</span>
|
|
</span>
|
|
<a target="_blank" rel="noopener noreferrer" href="{{.DownloadURL}}">
|
|
<strong>{{svg "octicon-package" 16 "gt-mr-2"}}{{.Name}}</strong>
|
|
</a>
|
|
</li>
|
|
{{end}}
|
|
{{end}}
|
|
</ul>
|
|
</details>
|
|
{{end}}
|
|
<span class="dot"> </span>
|
|
</div>
|
|
</li>
|
|
{{end}}
|
|
</ul>
|
|
|
|
{{template "base/paginate" .}}
|
|
</div>
|
|
</div>
|
|
|
|
{{if (and ($.Permission.CanWrite $.UnitTypeCode) .PageIsTagList)}}
|
|
<div class="ui small basic delete modal">
|
|
<div class="ui header">
|
|
{{svg "octicon-trash" 16 "gt-mr-2"}}
|
|
{{.locale.Tr "repo.release.delete_tag"}}
|
|
</div>
|
|
<div class="content">
|
|
<p>{{.locale.Tr "repo.release.deletion_tag_desc"}}</p>
|
|
</div>
|
|
{{template "base/delete_modal_actions" .}}
|
|
</div>
|
|
{{end}}
|
|
|
|
{{template "base/footer" .}}
|