fedi/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-10 09:09:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
forgejo/routers/web
History
qwerty287 9d943bf374
Add missing X-Total-Count and fix some related bugs (#17968) 
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
2021-12-15 13:39:34 +08:00
..
admin Add Option to synchronize Admin & Restricted states from OIDC/OAuth2 along with Setting Scopes (#16766) 2021-12-14 16:37:11 +08:00
dev Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
events Move login related structs and functions to models/login (#17093) 2021-09-24 19:32:56 +08:00
explore Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
feed Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
org Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
repo Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
user Add Option to synchronize Admin & Restricted states from OIDC/OAuth2 along with Setting Scopes (#16766) 2021-12-14 16:37:11 +08:00
base.go Fix nil checking on typed interface (#17598) 2021-11-15 21:16:11 +08:00
goget.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
home.go Refactor routers directory (#15800) 2021-06-09 01:33:54 +02:00
metrics.go Refactor routers directory (#15800) 2021-06-09 01:33:54 +02:00
nodeinfo.go Add nodeinfo endpoint for federation purposes (#16953) 2021-09-28 01:38:06 +02:00
swagger_json.go Refactor routers directory (#15800) 2021-06-09 01:33:54 +02:00
web.go Support sorting for project board issuses (#17152) 2021-12-08 14:57:18 +08:00